* [dpdk-dev] [PATCH] doc: use glob terminology
@ 2020-04-12 14:40 jerinj
2020-04-12 15:04 ` [dpdk-dev] [PATCH v2] " jerinj
2020-04-12 15:05 ` [dpdk-dev] [PATCH] " Thomas Monjalon
0 siblings, 2 replies; 6+ messages in thread
From: jerinj @ 2020-04-12 14:40 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, olivier.matz, mattias.ronnblom, Jerin Jacob
From: Jerin Jacob <jerinj@marvell.com>
Globbing is the word used on fnmatch man page. Use globing
terminology accross dpdk repo for shell pattern.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
devtools/check-includes.sh | 2 +-
lib/librte_eal/include/rte_log.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/check-includes.sh b/devtools/check-includes.sh
index 3629ab4c7..743e77675 100755
--- a/devtools/check-includes.sh
+++ b/devtools/check-includes.sh
@@ -23,7 +23,7 @@
# PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict
# C/C++ compilation flags.
#
-# IGNORE contains a list of shell patterns matching files (relative to the
+# IGNORE contains a list of globbing matching files (relative to the
# include directory) to avoid. It is set by default to known DPDK headers
# which must not be included on their own.
#
diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
index a497e195d..05761a3b6 100644
--- a/lib/librte_eal/include/rte_log.h
+++ b/lib/librte_eal/include/rte_log.h
@@ -158,7 +158,7 @@ __rte_experimental
bool rte_log_can_log(uint32_t logtype, uint32_t loglevel);
/**
- * Set the log level for a given type based on shell pattern.
+ * Set the log level for a given type based on globbing.
*
* @param pattern
* The match pattern identifying the log type.
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] doc: use glob terminology
2020-04-12 14:40 [dpdk-dev] [PATCH] doc: use glob terminology jerinj
@ 2020-04-12 15:04 ` jerinj
2020-04-25 17:26 ` Thomas Monjalon
2020-05-04 13:45 ` [dpdk-dev] [PATCH v3] " jerinj
2020-04-12 15:05 ` [dpdk-dev] [PATCH] " Thomas Monjalon
1 sibling, 2 replies; 6+ messages in thread
From: jerinj @ 2020-04-12 15:04 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, olivier.matz, mattias.ronnblom, Jerin Jacob
From: Jerin Jacob <jerinj@marvell.com>
Glob is the terminology used in fnmatch man page.
Use glob terminology across DPDK for shell pattern.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v2:
- Fix typo
devtools/check-includes.sh | 2 +-
lib/librte_eal/include/rte_log.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/check-includes.sh b/devtools/check-includes.sh
index 3629ab4c7..ca49cd722 100755
--- a/devtools/check-includes.sh
+++ b/devtools/check-includes.sh
@@ -23,7 +23,7 @@
# PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict
# C/C++ compilation flags.
#
-# IGNORE contains a list of shell patterns matching files (relative to the
+# IGNORE contains a list of glob matching files (relative to the
# include directory) to avoid. It is set by default to known DPDK headers
# which must not be included on their own.
#
diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
index a497e195d..fa60177c0 100644
--- a/lib/librte_eal/include/rte_log.h
+++ b/lib/librte_eal/include/rte_log.h
@@ -158,7 +158,7 @@ __rte_experimental
bool rte_log_can_log(uint32_t logtype, uint32_t loglevel);
/**
- * Set the log level for a given type based on shell pattern.
+ * Set the log level for a given type based on glob.
*
* @param pattern
* The match pattern identifying the log type.
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: use glob terminology
2020-04-12 14:40 [dpdk-dev] [PATCH] doc: use glob terminology jerinj
2020-04-12 15:04 ` [dpdk-dev] [PATCH v2] " jerinj
@ 2020-04-12 15:05 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-04-12 15:05 UTC (permalink / raw)
To: jerinj; +Cc: dev, olivier.matz, mattias.ronnblom, Jerin Jacob
12/04/2020 16:40, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Globbing is the word used on fnmatch man page. Use globing
> terminology accross dpdk repo for shell pattern.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
[...]
> --- a/lib/librte_eal/include/rte_log.h
> +++ b/lib/librte_eal/include/rte_log.h
> - * Set the log level for a given type based on shell pattern.
> + * Set the log level for a given type based on globbing.
> *
> * @param pattern
> * The match pattern identifying the log type.
"match pattern" can be replaced with "globbing pattern".
I think there are few other places which can be improved.
I see this one in lib/librte_eal/common/eal_common_log.c:
glob (file match) pattern
I suggest "globbing pattern"
And "Glob match string option" -> "Globbing pattern option"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: use glob terminology
2020-04-12 15:04 ` [dpdk-dev] [PATCH v2] " jerinj
@ 2020-04-25 17:26 ` Thomas Monjalon
2020-05-04 13:45 ` [dpdk-dev] [PATCH v3] " jerinj
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-04-25 17:26 UTC (permalink / raw)
To: Jerin Jacob; +Cc: dev, olivier.matz, mattias.ronnblom, david.marchand
12/04/2020 17:04, jerinj@marvell.com:
> --- a/devtools/check-includes.sh
> +++ b/devtools/check-includes.sh
> @@ -23,7 +23,7 @@
> # PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict
> # C/C++ compilation flags.
> #
> -# IGNORE contains a list of shell patterns matching files (relative to the
> +# IGNORE contains a list of glob matching files (relative to the
> # include directory) to avoid. It is set by default to known DPDK headers
> # which must not be included on their own.
> #
> diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
> index a497e195d..fa60177c0 100644
> --- a/lib/librte_eal/include/rte_log.h
> +++ b/lib/librte_eal/include/rte_log.h
> @@ -158,7 +158,7 @@ __rte_experimental
> bool rte_log_can_log(uint32_t logtype, uint32_t loglevel);
>
> /**
> - * Set the log level for a given type based on shell pattern.
> + * Set the log level for a given type based on glob.
> *
> * @param pattern
> * The match pattern identifying the log type.
My comment on v1 was sent at the same time as this v2. Pasting it here:
"match pattern" can be replaced with "globbing pattern".
I think there are few other places which can be improved.
I see this one in lib/librte_eal/common/eal_common_log.c:
glob (file match) pattern
I suggest "globbing pattern"
And "Glob match string option" -> "Globbing pattern option"
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v3] doc: use glob terminology
2020-04-12 15:04 ` [dpdk-dev] [PATCH v2] " jerinj
2020-04-25 17:26 ` Thomas Monjalon
@ 2020-05-04 13:45 ` jerinj
2020-05-19 14:05 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: jerinj @ 2020-05-04 13:45 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, david.marchand, Jerin Jacob
From: Jerin Jacob <jerinj@marvell.com>
Glob is the terminology used in fnmatch man page.
Use glob terminology across DPDK for shell pattern.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v3:
- Address Thomas's comments
http://patches.dpdk.org/patch/68225/
v2:
- Fix typo
devtools/check-includes.sh | 2 +-
lib/librte_eal/common/eal_common_log.c | 4 ++--
lib/librte_eal/include/rte_log.h | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/devtools/check-includes.sh b/devtools/check-includes.sh
index 3629ab4c7..749b9b26d 100755
--- a/devtools/check-includes.sh
+++ b/devtools/check-includes.sh
@@ -23,7 +23,7 @@
# PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict
# C/C++ compilation flags.
#
-# IGNORE contains a list of shell patterns matching files (relative to the
+# IGNORE contains a list of globbing patterns matching files (relative to the
# include directory) to avoid. It is set by default to known DPDK headers
# which must not be included on their own.
#
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index d7a5f9b64..8835c8fff 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -29,7 +29,7 @@ struct rte_eal_opt_loglevel {
TAILQ_ENTRY(rte_eal_opt_loglevel) next;
/** Compiled regular expression obtained from the option */
regex_t re_match;
- /** Glob match string option */
+ /** Globbing pattern option */
char *pattern;
/** Log level value obtained from the option */
uint32_t level;
@@ -207,7 +207,7 @@ int rte_log_save_regexp(const char *regex, int tmp)
return rte_log_save_level(tmp, regex, NULL);
}
-/* set log level based on glob (file match) pattern */
+/* set log level based on globbing pattern */
int
rte_log_set_level_pattern(const char *pattern, uint32_t level)
{
diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
index c020a3d7e..1789ede56 100644
--- a/lib/librte_eal/include/rte_log.h
+++ b/lib/librte_eal/include/rte_log.h
@@ -158,10 +158,10 @@ __rte_experimental
bool rte_log_can_log(uint32_t logtype, uint32_t loglevel);
/**
- * Set the log level for a given type based on shell pattern.
+ * Set the log level for a given type based on globbing pattern.
*
* @param pattern
- * The match pattern identifying the log type.
+ * The globbing pattern identifying the log type.
* @param level
* The level to be set.
* @return
--
2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: use glob terminology
2020-05-04 13:45 ` [dpdk-dev] [PATCH v3] " jerinj
@ 2020-05-19 14:05 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-05-19 14:05 UTC (permalink / raw)
To: Jerin Jacob; +Cc: dev, david.marchand
04/05/2020 15:45, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Glob is the terminology used in fnmatch man page.
> Use glob terminology across DPDK for shell pattern.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>
> v3:
> - Address Thomas's comments
> http://patches.dpdk.org/patch/68225/
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-19 14:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-12 14:40 [dpdk-dev] [PATCH] doc: use glob terminology jerinj
2020-04-12 15:04 ` [dpdk-dev] [PATCH v2] " jerinj
2020-04-25 17:26 ` Thomas Monjalon
2020-05-04 13:45 ` [dpdk-dev] [PATCH v3] " jerinj
2020-05-19 14:05 ` Thomas Monjalon
2020-04-12 15:05 ` [dpdk-dev] [PATCH] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).