From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8F4BA058A; Sun, 12 Apr 2020 17:05:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA12E293C; Sun, 12 Apr 2020 17:05:26 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AD5EFFFA for <dev@dpdk.org>; Sun, 12 Apr 2020 17:05:25 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 16EA15C00DF; Sun, 12 Apr 2020 11:05:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 12 Apr 2020 11:05:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=6np2mav9wacXnNXaC3ikUtM16xgpKhRftx3kI2uTF38=; b=Fd8OQ6JpUPld hkiZYM8Cya9Sp1aEoZfTp3bTh5gYnCu9CCCFudWvnWQ6p/LLQvuiS4kClO3cyWuy 05yyaby0nme6GqN2LkPGf+sihM9dxhsLmFT46F0d1Yhtwv7vZyLpngqINBpmJjls UHRr/2BC/VKOETpnlOakPburQJZabmo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=6np2mav9wacXnNXaC3ikUtM16xgpKhRftx3kI2uTF 38=; b=SJDpjC2mvqCQOneLkrfYenFNeQhlm2FfyOZzpFByJHdhGbXfZpQcmf4Hl FuDqKTtIXggKWaEbJzZGXP9PIkpBS3Yr1otS8c92SeF2BsqSbpg+g0M5V1OuX2e2 Bsqes5/N+yq8HEooYsQU8fTI1jCq/rvdr2hikbwMUrZBZBY0Y1FDNFWqSXOpWPNA Z6/tUvEJC8zcphUepOFW/4Kta2eGc/K05+iqW8qoTugdeboOu/7bse9svz1gn5yP JN9+7oEQjtqQH++B2pdbwC+TZAjnLns+CR8tVHImsTWqPXwJxZHfQSpSKj/BaoAT vM1jFaZ3+6VUQ89zGFOF5hwPVUKTA== X-ME-Sender: <xms:NC6TXtN5oNJ-5hfo3267LVZLOCglC_4wYF8aQiJh3mTOAvw2qh5Weg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvdejgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:NC6TXk1IHaFVRUFTxAy3o13srlt_sMIvuDTKPQpDRLpJ7bYE7xqQkQ> <xmx:NC6TXk0_tYgqumeZQyDsnuja0A2CW7H_fj589HGceoDf1RL3Po0kyA> <xmx:NC6TXq9wCgnAzKjpomgYVJr42s8fOVy6VJ4m-RbJTnp2PSoC91sLSQ> <xmx:NS6TXv7rpxcToI_CMPmt1-88MOhgXS-k_yi5FUBV42we3ylDoEp7Wg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7E1CD3280063; Sun, 12 Apr 2020 11:05:23 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: jerinj@marvell.com Cc: dev@dpdk.org, olivier.matz@6wind.com, mattias.ronnblom@ericsson.com, Jerin Jacob <jerinj@marvell.com> Date: Sun, 12 Apr 2020 17:05:22 +0200 Message-ID: <8516363.EvYhyI6sBW@thomas> In-Reply-To: <20200412144047.2125201-1-jerinj@marvell.com> References: <20200412144047.2125201-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: use glob terminology X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 12/04/2020 16:40, jerinj@marvell.com: > From: Jerin Jacob <jerinj@marvell.com> > > Globbing is the word used on fnmatch man page. Use globing > terminology accross dpdk repo for shell pattern. > > Signed-off-by: Jerin Jacob <jerinj@marvell.com> [...] > --- a/lib/librte_eal/include/rte_log.h > +++ b/lib/librte_eal/include/rte_log.h > - * Set the log level for a given type based on shell pattern. > + * Set the log level for a given type based on globbing. > * > * @param pattern > * The match pattern identifying the log type. "match pattern" can be replaced with "globbing pattern". I think there are few other places which can be improved. I see this one in lib/librte_eal/common/eal_common_log.c: glob (file match) pattern I suggest "globbing pattern" And "Glob match string option" -> "Globbing pattern option"