From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E93CA14E8 for ; Mon, 19 Feb 2018 14:55:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2018 05:55:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,535,1511856000"; d="scan'208";a="18911913" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 19 Feb 2018 05:55:34 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 19 Feb 2018 05:55:34 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.243]) by fmsmsx121.amr.corp.intel.com ([169.254.6.69]) with mapi id 14.03.0319.002; Mon, 19 Feb 2018 05:55:34 -0800 From: "Wiles, Keith" To: Matan Azrad CC: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "Thomas Monjalon" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 Thread-Index: AQHTqH9YhrarJeV/c02BHfwy89nKE6Oq0lgAgADxi4CAAIPYAA== Date: Mon, 19 Feb 2018 13:55:33 +0000 Message-ID: <8522C580-BFB3-4D1B-A331-45DA05427D50@intel.com> References: <20180217104934.17291-1-pbhagavatula@caviumnetworks.com> <28F3DAA5-CCAB-4D2E-A6C9-FEB685A619C8@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.32.238] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2018 13:55:36 -0000 > On Feb 19, 2018, at 12:03 AM, Matan Azrad wrote: >=20 >=20 >>=20 >> Is this the type of API that needs to be marked experimental, >=20 > I think it is relevant to any exposed API(not only for internal libraries= ). >=20 >> we should be able to prove these functions, correct? >=20 > Don't we need to prove any function in DPDK? > What is your point? My point is this is a inline function and can not be placed in the .map fil= e as a external API. These simple type of APIs are easy to prove and making= them experimental seems to just cause an extra step. If the functions are = not required that is a different problem or if the API is really only ever = used by a single function or module of files then it should be moved to the= module/file and made locate to the module/file. >=20 >>> Matan >>=20 >> Regards, >> Keith Regards, Keith