From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id E2BA35A6C for ; Thu, 19 Nov 2015 13:33:58 +0100 (CET) Received: by wmww144 with SMTP id w144so114467827wmw.0 for ; Thu, 19 Nov 2015 04:33:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=NU0swo/ijvqSWWRPOYDYJl167n0v25lRJvZ/bOmmKhQ=; b=TmJjMuDnvExuoJa3kNF33ILodS1ytWsxzFv9DG+LLUO6Xk18uCEg5LsgROZqsFHxmU 29Gct8CYh0ufBdRQM67jg7cCM+bQSYezT8Ts2Kn0KEN+ZWz4W1IqoJ6SYcWJ6KmiOZv1 raf2kxyPe17Mt45Up0jLkvrxRCHg1i0tyc822MzmoRxUf1xRZu6+/SU9ALGxoih6BDfn Kn9iRQCIJk9JcV3O5Tr7CszNufdMmj2w4wwJzzhTFg505+5pJbYSJ1iLbSyoPTRNsFXx RzBY3GpIJUYYHNCYmlqPERH5sSPy3ZCB34BDkKaVwxf0A0MLRwmHOJqYhuG+XXMveX5l upwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=NU0swo/ijvqSWWRPOYDYJl167n0v25lRJvZ/bOmmKhQ=; b=h+RVyu7nEVCe44YfZ5yG0FDfqHDluQEF5Txx+EJVLDmiNUnjF7ljqgE2Aq7ARHS/yZ 4Oq6SvcSLunTrwgorKSiBRWqJopiUDtdA7YfD0CF/gWzw9VbB7baGLGeiL0H8XGb36ZY QjzeV7WH9K8J54pPfrGZh05yIxT4DWfuKW7lQSgcjOkol/AHBfg6om0wfZLFIQe4yUOn WjMRPX0MHEtvqlhCNj4adodPVpK5W7QFz3spjoejFLPZyaS5mG8AchOxYPQMa/EujGc6 O7zwKJxCO1d71NSXrkirdLo7h0Ef0u/GrWfZ0bVXYabB5GwGHYBo7rGI4plXYp5cv2jO tv+g== X-Gm-Message-State: ALoCoQn9BSrcT+89X6oQHsm5gYksJQfVF7v+JqDBpUmv3pYD/4fg52FwOeZj3rENeFwkp8W7FPY5 X-Received: by 10.28.182.134 with SMTP id g128mr16204381wmf.95.1447936438733; Thu, 19 Nov 2015 04:33:58 -0800 (PST) Received: from xps13.localnet ([192.54.209.32]) by smtp.gmail.com with ESMTPSA id b12sm34109574wma.6.2015.11.19.04.33.57 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 19 Nov 2015 04:33:58 -0800 (PST) From: Thomas Monjalon To: ferruh.yigit@intel.com Date: Thu, 19 Nov 2015 13:32:44 +0100 Message-ID: <8530847.T7t25DiR7m@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <564DB761.5090203@redhat.com> References: <103431910.iACTIb73WP@xps13> <1447932137-16886-1-git-send-email-ferruh.yigit@intel.com> <564DB761.5090203@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Revert "eal: set name to threads" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 12:33:59 -0000 2015-11-19 13:49, Panu Matilainen: > On 11/19/2015 01:22 PM, Ferruh Yigit wrote: > > This reverts commit 67b6d3039e9edbc4624c878c6930be5e126e8b58. > > > > Reverted patch uses pthread_setname_np() function, this function added > > into glibc in version 2.12 and cause a compile error in older glibc > > versions: > > error: implicit declaration of function "pthread_setname_np" > > > > Main purpose of reverted patch is to name threads, without > > pthread_setname_np() function, patch does not mean much, so reverting > > patch for sake of compatibility with older glibc versions. > > Debuggability is important too. Rather than revert, why not wrap it in > rte_thread_setname() or such and just make it a no-op with glibc > versions where pthread_setname_np() is not available? +1