From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com
 [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 4E6C5231C
 for <dev@dpdk.org>; Wed, 12 Oct 2016 22:33:20 +0200 (CEST)
Received: by mail-qk0-f181.google.com with SMTP id z190so54101021qkc.2
 for <dev@dpdk.org>; Wed, 12 Oct 2016 13:33:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=83HVZg5+8aaTuKzuJ2lKjDv3UUzp5/t9wcWK5CKPWlo=;
 b=Kbsbr9C148eaiheQbREL4xxt/di8sf7CtoNx3DtWOUO0bvih08AJxX6z3vMzE+cdpu
 D3iGiWchvWfueDVvON0Z4DW1ahD7UbGUzSGHZEa4yNHWV+QtlPZX4v5FX0Q2Ri45WCKt
 S8BRstmYqD4z+Ge0dApbuIICEJZ+7Ok63O5+b6vh7S5MqNu0dYUibNnxVEWRKgHs7RRV
 nxefcFo8bwcimlfpNvU/EfP2sbMhxZQskuwFs0PLOiNPRdB8DMhjB2kL9U0dhXJuWolY
 uWvJuToGSpoq7BTEhj/Wbu1GY6+p4hHxEkW+TGHqfPeAhUnGw1F+7aQiC102EL4xL65T
 MxcA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=83HVZg5+8aaTuKzuJ2lKjDv3UUzp5/t9wcWK5CKPWlo=;
 b=E/5zHPy0GqAVaajKjiu+4QSs66OeXivbY2AbRvhznxZQmUz26PgyNaccPiwDA0vy/z
 0ZMf1RlNs7ICpRGHuwys4ogDl387ls8grgqIPxhnWNjJqlgDecQA3HP+e75ql5hEpuWk
 JomjrsFG+/Cd3u9F76JWH+CUP9I+smvqE7kCPhCjl10WPuobScXooB1apTJTEjPAxdSD
 3H4KVj6qMx0+z6JiNZA01IxVartS70f6Nrm1+CQysVTO9Pa6+oT2qTfq/MV6ZzO13Han
 1pIcNlCgQUn1VmmK+l1tHkXQD60gwo4qfvHMBc/nwxwlQm2t4wUKI7ZvOXwYwiewrYDJ
 ZGIw==
X-Gm-Message-State: AA6/9RnyEbChsI1tf08cwFGzsTQ/E4Hjds9ID/Q2dRGcRAudLYtXtqcSuTVhn80R1rxYDhF+
X-Received: by 10.194.75.165 with SMTP id d5mr3908221wjw.190.1476304399774;
 Wed, 12 Oct 2016 13:33:19 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id q8sm15820837wjj.7.2016.10.12.13.33.18
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 12 Oct 2016 13:33:18 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
Date: Wed, 12 Oct 2016 22:33:17 +0200
Message-ID: <8534270.5teDzHbgep@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1472999921-43283-1-git-send-email-jasvinder.singh@intel.com>
References: <1470432064-59047-1-git-send-email-jasvinder.singh@intel.com>
 <1472999921-43283-1-git-send-email-jasvinder.singh@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file
	descriptor port support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2016 20:33:20 -0000

2016-09-04 15:38, Jasvinder Singh:
> +#define RTE_PORT_FD_READER_STATS_PKTS_IN_ADD(port, val) \
> +       do { port->stats.n_pkts_in += val } while (0)
> +#define RTE_PORT_FD_READER_STATS_PKTS_DROP_ADD(port, val) \
> +       do { port->stats.n_pkts_drop += val } while (0)
> +

It does not compile because of missing ;

> + *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.

The years seem outdated.

This patchset was probably not tested as it does not compile.
And it could be useless if a TAP PMD is integrated.
I suggest to wait 17.02 cycle and see.