From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 6FABE2C55 for ; Wed, 29 Mar 2017 09:53:56 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id l43so4989598wre.1 for ; Wed, 29 Mar 2017 00:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=J5VTRSieMbRXRV/jxGzA/9W7TQcY2Big5vDevKgnDJk=; b=ei+3FTAVD/QrfL0v6Rhjy12A442nsitIzt1hYSn1Y9LMkq3Zse/4/447ymXB7twkX7 C6dPrKkOwfHGNxxLEdJ6562yhBE2MtH4DX4LJb5+7sxqPyCyS35+CVn/HjnjbrsHZrIN 7WuYC9cjLDpaB3j5B9snmivwdQozhKuMJxcw+qVwcKvC2gL/0JDbwhzeyl2iqP3fe/pc 2NmsJIion8YLNeAmuwOXtXk8Fosr6tRKbU+4ZPMzuMB0W3t+CpZkCGnMYGJcNrCeok9n 6KAzNmPrEVakwzyE4JfIsXke6Ny8tGXB3DUs2bXZF5TZUq4oKrvDHEfBRvEEvsikcqLv rLhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=J5VTRSieMbRXRV/jxGzA/9W7TQcY2Big5vDevKgnDJk=; b=eE52tEQV25LNngnZliZNDTba7b5FXcSgWbbaoJTPhA9UFqKMCR47pEdOxS6AcFUvKW +zbSHguPtEFky4ykOrCzI9uT4EW1fhBeV5Ejd8dqmlPPs5yqbwZN4mH/hhXFLix6KcCh Jk7A5QWoHK95fE2dF2InZS/dM4F6QpqNGCXb04Zf0wVtmGsJK245O83x85Jk2KlYRY7V 7SmEYevfr1l+4NHNuTdPs7M3f5fIdXWRiCLGNV8ezAE6s0BhDUOU6pz5kRDVV9X9KDX1 yBXOcE15eeEY9ZLlE0vExvOcuCfXFoBoHCZvAkFKtqDg7LPHKumW+fq3/aY29cLh1Lve uxjA== X-Gm-Message-State: AFeK/H0LAkenFlV+okDHImOxAi4nXuYRW2DpkIiMgWdc8rNjPa9lQJ8SXn34sA3fpUzzaycF X-Received: by 10.223.179.195 with SMTP id x3mr31974257wrd.119.1490774036247; Wed, 29 Mar 2017 00:53:56 -0700 (PDT) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id b42sm8190981wra.36.2017.03.29.00.53.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 29 Mar 2017 00:53:55 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil , Yongseok Koh Date: Wed, 29 Mar 2017 09:53:39 +0200 Message-Id: <853462d73e9e7da238c88f18418c1428b592a9eb.1490773631.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <2a99263e0ab95c4af08ffb2dc17084a72b9265ee.1490773631.git.nelio.laranjeiro@6wind.com> References: <2a99263e0ab95c4af08ffb2dc17084a72b9265ee.1490773631.git.nelio.laranjeiro@6wind.com> In-Reply-To: <2a99263e0ab95c4af08ffb2dc17084a72b9265ee.1490773631.git.nelio.laranjeiro@6wind.com> References: <2a99263e0ab95c4af08ffb2dc17084a72b9265ee.1490773631.git.nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix RSS flow rule with non existing queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 07:53:56 -0000 RSS flow rule validation accepts any queue even non existing ones which causes a segmentation fault at creation time. Fixes: fb4db56ea074 ("net/mlx5: support RSS action flow rule") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index b34be55..3691e95 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -488,16 +488,18 @@ priv_flow_validate(struct priv *priv, break; } } - if (action->queues_n && !found) { + if (action->queues_n > 1 && !found) { rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, actions, "queue action not in RSS queues"); return -rte_errno; } - action->queue = 1; - action->queues_n = 1; - action->queues[0] = queue->index; + if (!found) { + action->queue = 1; + action->queues_n = 1; + action->queues[0] = queue->index; + } } else if (actions->type == RTE_FLOW_ACTION_TYPE_RSS) { const struct rte_flow_action_rss *rss = (const struct rte_flow_action_rss *) @@ -524,6 +526,16 @@ priv_flow_validate(struct priv *priv, return -rte_errno; } } + for (n = 0; n < rss->num; ++n) { + if (rss->queue[n] >= priv->rxqs_n) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "queue id > number of" + " queues"); + return -rte_errno; + } + } action->queue = 1; for (n = 0; n < rss->num; ++n) action->queues[n] = rss->queue[n]; -- 2.1.4