From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id ED9481B173 for ; Tue, 6 Feb 2018 10:47:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 80D5C20D73; Tue, 6 Feb 2018 04:47:17 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 06 Feb 2018 04:47:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=sRx7Hx7G1aOG2GjbL++7gN/19u zqcYRsJnxRhVGOLeM=; b=f2f6N0k/Iirrm0bTPyn1lpE2ujhFc//ZbsKEqUE5i1 aB3iI22tX4roZElYbk0osRIpYbggNAyirDoZpsja8YZTIrFwdJ70XXqn8nMXzUDj eJnujBBTZ6R+Qy2IHidrmHxPzrFHeiwQLAuTBFL46ee9pbS6deF86LWFbCZLaGFJ Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=sRx7Hx 7G1aOG2GjbL++7gN/19uzqcYRsJnxRhVGOLeM=; b=nPty7fFyuc7TTNFuw00882 lMh6uBfAu15t7RY7i3eyQv7KLHWtZ8ZmSvpv7sfu5D8WUBWgDxTYDn7X4iqgOMvH 2F1cEdRL5Z4igpv/eo7zCuc3DFHHYzwIPb8ZfjIeHchdBGaJhTfsQIGQajmB8V0e 1Q+2KLlsjqJSsbte+zlGuRIvcwiLNNp6VPRaY5pmhZ3xcYSX/PLhuv1DEP5MR8Cl duBtAin0MMDp9uSEFPIyR/21s0nwd5O/8bfMjY7oyGa/LgAimXssVleGM50kg2Lu wabrDXdjVCDfzTw08pVWvISNziB5u3b9AaRfazexxIXJNi2ch7a2fZirMiRVDFnA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2DD077E41F; Tue, 6 Feb 2018 04:47:17 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org Date: Tue, 06 Feb 2018 10:47:13 +0100 Message-ID: <8555507.QN0AfJDokS@xps> In-Reply-To: References: <3cf7f9aa904a5ba53ba63d7c32539e8b78638939.1513946317.git.anatoly.burakov@intel.com> <4220934.KFJTx7yznj@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal: add function to return number of detected sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 09:47:18 -0000 06/02/2018 10:28, Burakov, Anatoly: > On 05-Feb-18 10:45 PM, Thomas Monjalon wrote: > > 05/02/2018 18:39, Burakov, Anatoly: > >> On 05-Feb-18 4:37 PM, Anatoly Burakov wrote: > >>> During lcore scan, find maximum socket ID and store it. > >>> > >>> Signed-off-by: Anatoly Burakov > >>> --- > >>> > >>> Notes: > >>> v3: > >>> - Added ABI backwards compatibility > >>> > >>> v2: > >>> - checkpatch changes > >>> - check socket before deciding if the core is not to be used > >>> > >>> lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++---------- > >>> lib/librte_eal/common/include/rte_eal.h | 25 +++++++++++++++++++++ > >>> lib/librte_eal/common/include/rte_lcore.h | 8 +++++++ > >>> lib/librte_eal/linuxapp/eal/eal.c | 27 +++++++++++++++++++++- > >>> lib/librte_eal/rte_eal_version.map | 9 +++++++- > >>> 5 files changed, 92 insertions(+), 14 deletions(-) > >>> > >> > >> This patch does not break ABI, but does it in a very ugly way. Is it > >> worth it? > > > > I think we agreed to not get this patch in 18.02. > > Did you change your mind? > > > > Sorry, how do i mark this patch as for 18.05? Is it a patch header? So your answer is "yes, it is for 18.05" :) Next time, you could add 18.05 near "PATCH v3", or say it in annotations.