From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id EF7055A7A
 for <dev@dpdk.org>; Thu,  5 Mar 2015 00:16:37 +0100 (CET)
Received: by wiwh11 with SMTP id h11so34673754wiw.3
 for <dev@dpdk.org>; Wed, 04 Mar 2015 15:16:37 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=r0zgICMxpaxGD+bwhSitMqfhZ/ecVSpQQvS8l6X8DM8=;
 b=I3qblaoglQEcfJprWtSNOD4wZoE2db5YGg7ngPjBjmOyBU7nYhRPxtWp2/ZelcMqTr
 LgoU1w14s3sayU+GELvtY08wKUzATIDN5JeiEzfx/dR9aZIOwVdKhZKDBI9BHukw1zHO
 8iuS+vdxblAhP07EU8Tv3sNrM8INveRhWMAWwvzdfUR+cNIT2YBQo0XD+Cp0i8fAH+q8
 2m3n+kqUQbt1b7JH5loyJr35UGxV10ZLwFAQ7nMFgiV6j2imlh4cxSscpPw9mQKcFmJI
 nOMs+13kOx2nNW6g5paeLFOx7Yw4Baa0IfrV2n7JXMa7j28nxpgovNaPXMzwQ2dww4OI
 ucPg==
X-Gm-Message-State: ALoCoQkWlrZbVRessypABn25JMRgWHbaeDa91xUb1QBfHePfMBHwHrJMh9om/q09GKMCufuaPs7p
X-Received: by 10.180.9.111 with SMTP id y15mr17250309wia.86.1425510997778;
 Wed, 04 Mar 2015 15:16:37 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id lb6sm7918640wjb.22.2015.03.04.15.16.36
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 04 Mar 2015 15:16:36 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 05 Mar 2015 00:16:02 +0100
Message-ID: <8562501.9F7O0EyhDp@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <6701277.4xurLSZEjD@xps13>
References: <20141227151300.7b62f5bf@urahara> <6701277.4xurLSZEjD@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC] resolve conflict between net/ethernet.h and
	rte_ethdev.h
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2015 23:16:38 -0000

2015-01-06 11:44, Thomas Monjalon:
> 2014-12-27 15:13, Stephen Hemminger:
> > This is a patch to address the conflict between <net/ethernet.h>
> > and the definitions in <rte_ethdev.h>. It has two side effects
> > worth discussion:
> >   1. It forces inclusion of net/ethernet.h
> >   2. It has definition to deal with the differing structure elements
> >      in the two versions of struct ether_addr.
> > 
> > By doing this ether_ntoa and related functions can be used without
> > messing with prototypes.
> > 
> > Alternative is more complex #ifdef magic like linux/libc-compat.h
> 
> [...]
> 
> > +#include <net/ethernet.h>
> 
> [...]
> 
> > +/* Deprecated definition to allow for compatiablity with net/ethernet.h */
> > +#define addr_bytes	ether_addr_octet
> 
> This is defining a common identifier without prefix.
> So it will be forbidden to use addr_bytes as variable name.
> I understand you are trying to keep compatibility with both structures,
> but the drawback is really nasty.
> Is there another solution? Or at least, we could mark it as deprecated and
> remove it in release 2.1.

ping
Any opinion?