From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4669AA00C5; Wed, 2 Feb 2022 16:35:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDB1C40DF4; Wed, 2 Feb 2022 16:35:01 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 3F4F440689 for ; Wed, 2 Feb 2022 16:35:00 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 1DAC4320233B; Wed, 2 Feb 2022 10:34:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 02 Feb 2022 10:34:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=Kec3DB1A8KYtXs 5z+2djxXj9Ka5NZ+wnAfo+3CFYhGg=; b=h1H7jXEartIykJW38MVL+JZw7S4qXC jo9ieGquFCJVxt97Lu6ktHy/F02qGSysV3Gq0iPb5KA9CwA8rMdI9edBefIZ1fdM t79b8oSXYDDC67haWPIo35XMgz7wrXGbLLizHqKC0GMaoOVfEpC56I2f1QZGYp+j u15Jpx2Jin2vy5nkU1EWZA40vkVH9W6euQqSB7cOepWLDZC+h+tNyVR+WfV8cDL6 ShPllVwkYvRtFvRQhThlXTdP/Ff/l2WXBIzoRB58ZUIztukO9qpNQC9FkRUsgjT6 D3ahDJ38E8YxyaIV4WSIUhPFLhr9Jh7uYd89KioE72JBBI3cjBxNKR4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Kec3DB1A8KYtXs5z+2djxXj9Ka5NZ+wnAfo+3CFYh Gg=; b=YfsFFNOWaFIskW4oLp7GiJ0pIMDY780n+TA+hKAot30UdvmZnnCbuKbAO wUq1hAsA9QukHSbIcwMzX81T338Q2tbeTAnCfjVauhKue/xQ8YEFRm+X0ePPlM6k cNbPgKdfPaxm8LuIzlUYutcN5rFqM2Yn7rz4m7hZGSYt+EtXOw1yo2YYV+vf4UJt NdRvf/rewaOpVAM45mWY0Lz6lhDZniAtal0QkuDUnm6xsxuDcAbQ+7rHjzArIkEg BcZaEAdKLhbRA6OceRPPJnt+KquzBMpjmrQ/kXb7aB4drUKSf/+6lMcw3oSZ30+d Qe2J6rs5vLy4GJobrrtKcqe0ZdQTg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeehgdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Feb 2022 10:34:57 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Luca Boccassi Subject: Re: [PATCH] build: fix meson warning about using compiler warning flags Date: Wed, 02 Feb 2022 16:34:55 +0100 Message-ID: <8563208.VV5PYv0bhD@thomas> In-Reply-To: <746d3b6884eeb51c2d565763a54734db0400cfbc.camel@debian.org> References: <20220121155346.1994682-1-bruce.richardson@intel.com> <746d3b6884eeb51c2d565763a54734db0400cfbc.camel@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/01/2022 17:41, Luca Boccassi: > On Fri, 2022-01-21 at 15:53 +0000, Bruce Richardson wrote: > > Each build, meson would issue a warning reporting that the > > "warning_level" setting should be used in place of adding -Wextra > > directly to our build commands. Testing with meson 0.61 shows that the > > only difference for gcc and clang builds between warning levels 1 and > > 2 is the addition of -Wextra, so we can remove the warning by deleting > > our explicit set of Wextra and changing the build defaults to > > warning_level 2. > > > > Fixes: 524a0d5d66b9 ("build: enable extra warnings with meson") > > > > Signed-off-by: Bruce Richardson > > --- > > > > NOTE1: Not putting CC stable for this patch, I don't believe it's worth > > the risk of backporting. > > > > NOTE2: For reference, when building a test "hello world" project with > > different warning levels, the following flags are used by meson: > > > > warning_level=0: > > warning_level=1: -Wall -Winvalid-pch > > warning_level=2: -Wall -Winvalid-pch -Wextra > > warning_level=3: -Wall -Winvalid-pch -Wextra -Wpedantic > > --- > > Acked-by: Luca Boccassi Applied, thanks.