From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46E82432E9; Thu, 9 Nov 2023 19:51:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34B4340ED0; Thu, 9 Nov 2023 19:51:42 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2068.outbound.protection.outlook.com [40.107.94.68]) by mails.dpdk.org (Postfix) with ESMTP id 0B28440E96 for ; Thu, 9 Nov 2023 19:51:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EgwYu/nquWtgANoH067sPrhgTikmHACaq3kgKCNJWEmJyCIwNPkXLZBBx+sLT0dRxX2zL00U0AfIGGIvJgtlVX8jxevYU5zISFtdR2w2KJQpjdGiKu3UYMFr9YWzio33w6vUOu0deaTlWBoriZO1PDh2YNn3R4c0NH3HY3vrZzO3emOxQZvT3XaqHyTu5CfeN+3YREZ0DccKnqZsrhsbtxJwd0f6JfLBoRr7BUM0OZaN+DqMOK/nYCU6cB0h4GKzYq8VKPfWGQg129aDLX/AuJumu3mAkt3xu0gYHm7OhwSIfma88F2730dGs4hhayM+q+YhCecTUqi2sbz7p8CBEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iaX2gwAwDnxM5YfF4y9YGfkxZnejO6q9ZScw+s31+Wk=; b=YeDbkw7LN6wqaLvp6J3SLOyyJQmaN4UGkQ7x0+MVZKsQpJvmo1qGo6yPYRiBgK7DkVwhDEL0VN0Y2F6Mmksu5vrWo+LUteYY7RHtczZfiFUWG/+YNJfsmFS3fiB5oo7Oe3qtzdxOdpOf6EhSh2jtlCkG1CvU+4njRhTibL99qvITwR688cOuxfKlgxMjCFWmXfaj+ZAcAKzeybEHUfoHSlnrTzxzdiJwGXSORGYrVC+KyfXTMPBBww2/eEPdbne9XNgE5BOMJMg329wYihz+LW0CXq0UN0ai9ht7T1osJfrMN+LAEGJT4USlPMX3XNbXeBmRLtQHFNp+NZdEpGQqVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iaX2gwAwDnxM5YfF4y9YGfkxZnejO6q9ZScw+s31+Wk=; b=b42E8RFGwUTpROl1JN000OCq811gEAUbZmCwWDxYMLwApJYZPD1/FN3HLTZmVQ8Rq009sBBfyPjuP/I1GuLNv5h+81abWvJCitZROHfDtFgXvJS/pc8ybpcvEhKxYuGU6u0k0xUsSanzXN1tHG9tBT70dJQImehMB40RdNzTqxo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ2PR12MB8134.namprd12.prod.outlook.com (2603:10b6:a03:4fa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Thu, 9 Nov 2023 18:51:36 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.029; Thu, 9 Nov 2023 18:51:36 +0000 Message-ID: <85645bae-2e33-4a5e-8e87-4252f15072e0@amd.com> Date: Thu, 9 Nov 2023 18:51:17 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] net/hns3: refactor VF mailbox message struct Content-Language: en-US To: Jie Hai , dev@dpdk.org, Yisen Zhuang , Ferruh Yigit , "Min Hu (Connor)" , Huisong Li , "Wei Hu (Xavier)" , Hao Chen References: <20231108034434.559030-1-haijie1@huawei.com> <20231108034434.559030-3-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231108034434.559030-3-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0259.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ2PR12MB8134:EE_ X-MS-Office365-Filtering-Correlation-Id: a2e563fb-e123-44f2-7267-08dbe154e69d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tmFpF78I5GfRn3UBQWS9EYA4u13A4SGuU6pfz1TcqLp77AV2lFHuNAiF+HCQ+UAouamaKOM5XqjnMy9pzrgpK0Oaf3j1tObAk5Fdxjeaydk9C5K1CJYmisESUNiaJl9Ja6YDr22c4tYsG5d8/XwNhSAJ3RTMVll8neMJa9ffrC0J9bh76VhzTamkONo2vDZKAl5ugotuOkNEwuEOTzR02N75/n7yQIDVHza0mSkPQlHZrLA5R8hExCOzCWH48MeEEimrcwQKn+0BYqG9H5sKzqTVmVCtHadpHT88cV+unOSjJeXNYToX7HayzGzvR+2W1r8w4Phcx3kUoRlIu9DT87B2+REUKrPYeCqcJvE7MfE2sDy6WmxmKHPHk0nEENkyNOvXYnP2pOHDhnaDO6JaPgj7S86yEmwDIXS3+q1QSzAxnlej8rEy8MHDwbIbhuT1rkKDxOqualRJg0MTJZG02j6yW8aq1z7D7SNwTdTkRPS2TDu3k0FPSceoKDVFMDcEQiByi8if53Ed6T9YI/A1ecdp+StLNhv9scw0+kTpVRhXkfRCqutsGD8J7K18t5JPKwg/cIWoIUmCpcADDbkiKaTPULdzpcPVX2Q8APEEqtGuMPsclf3oh1iAUzLrvR2/fgC0Ps27jVulCifQMV7z6w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(136003)(39860400002)(366004)(346002)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(31686004)(478600001)(6486002)(6506007)(86362001)(31696002)(36756003)(38100700002)(83380400001)(2616005)(66946007)(316002)(53546011)(2906002)(6512007)(110136005)(66476007)(26005)(6666004)(15650500001)(66556008)(4744005)(41300700001)(44832011)(8676002)(5660300002)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3EyQ3JzMG5xdCszWEtmL3V5bXVkdkJONmw5UEVJcm9jTUVwTWk2WE9BWlVh?= =?utf-8?B?VnRVS3J3d21YbjlYNDVDSWxaZGN6c1ZMREc5VTBUR01adGhjdnQ3MXFadmVn?= =?utf-8?B?WXlNYlFLbFZYQzl3Wmt4TkxDMzNXT0pwSFMvS2pXNDhRMnptYms1MEZrR25B?= =?utf-8?B?aTd2akJVNkNlWE1NbUtmc1NJbDJkOGx1cmFmeGNqUWJnRFI2SFIvam1Cd3N4?= =?utf-8?B?TWxlUElIck9QUzRrS1VKSmU5dG1LMGhRbHZQT2hyZXFDU3g4NlFLaDNpWmJS?= =?utf-8?B?d2tjcm1VQ092RnZPOEZ1ZTJ0a3dmeWYyRUlScWxVb3lDMmRpNkpEK0d1WkVZ?= =?utf-8?B?VDd4dW4vREhiSlo2N2ozbnlPMmIzZ2s3VGdFMGtZSmx3eUV3MUZwV1NBcCtl?= =?utf-8?B?Y0Rid2REQk5zc2JYNFcyL2x3NGg2d1JNWC8xRjhMM3NZMDRJT1ZCTE9YWTV2?= =?utf-8?B?aXgvNnlLQzhRalJBa0ZtaFRXYWlOUVNvNUVBcnVZZmRhL2sxK1JKZllwNXBz?= =?utf-8?B?ZEVQWVdYUWwwaHlGb0RKc2tWY05tNzl0MHRpemJZanYrL3B5WDBha1l2UmJ5?= =?utf-8?B?VFBsS0Q3MTJpODM5emZtTmFZTFBTbnlrenNzaTlWbEh5ZU9nNEkwNjc4Mm9G?= =?utf-8?B?dTNTZ3Q5bWoxVk96QW11aVF6RlNHbURqd3kwQ0U5ZExibUhRY1RTbVM5SGRO?= =?utf-8?B?Rjd1WHJpNGk0UlNtZEpncWo5bDZUSFJ6d2UrY0prVE1qVnFNd0ZyRk80WTRn?= =?utf-8?B?djA2bGdsSmRtOUpTSnFXRS9OQWRvWE5YRU1nTStjYzkrZVBoRHJpZXpPalF5?= =?utf-8?B?bFBQMUhZem9BeWtKUnlpNVdYckVUTytKSGZySTl2VVVCejV3NW56WldrdFll?= =?utf-8?B?dVRIWGlIT3FhN3RvMkY5N3NTZG9WVkhDY1Z0STZqdjFYRFBFbnN2b0lNYUtV?= =?utf-8?B?ZkdFay9pM2N0b1V2Z3c5Tm9Tb2RNUW5abHhEeVh1Q3hpVmdnLzVEb1NGSVRZ?= =?utf-8?B?WlhQZHpJUTFSYUlnUmdnUTV1OUQvaU13TDkrMzhFdjI3TlVzUG9STlM4emY4?= =?utf-8?B?T3RTYmdTcDJyRk12cUtHN0xSS3NOb0dhT0Q1UVFyYlFEL1pMQUVqaDRSNlph?= =?utf-8?B?ZndVRUVxMXc0bmdhcjM5WkhuOWx1U1lKYTR0K3Q5NmduYU5tQVVFclJqT3Z2?= =?utf-8?B?blRGSmVhaXNxV1RtS0t2SGVFYnFzYy9kc1JlaDFCWGdjRTUySXROMjJkV0M2?= =?utf-8?B?Mkt6SS9WMlNXQk5ZYXlQU1ZjekE5bTg3aSswWjVDTVdyOVZIcjBmZm5kUUFN?= =?utf-8?B?ZldHRmdDdkVqZnF2YldoWCt2elNZUkxOQStoSE5vc1VweG5DMlRiYTVqaHk0?= =?utf-8?B?SEdWazVpc2xzNURESWJBSVc3ajlqaVh2OE1lUXdjRzNyY3ZOTW1JMmJkcy9H?= =?utf-8?B?QUtoK2ViRmJjZjMwS3dxSFVwWW1XbFh5K1IrWDJZbW1QOFlESk9UOXBrMU9Z?= =?utf-8?B?Rktsak9hV0RYRmFtL0lCNW5OdUtKbDVyYWl2K1FXU3NzbnF5ajUyYjBkYW1P?= =?utf-8?B?Q0ZWbmdKYkJtVWVGL3dVT2FLZ1VNdW01NXFHUUpZTXo0RGQvMHpGUFh6d0Jm?= =?utf-8?B?YTd6L1B4WTExZjFOYnBjQ3NnT2YxWUF4Y2NEc0c2NkY0a1h3RVBjNWlvK2Vv?= =?utf-8?B?SUNWUjhqR3VUL05rZElIMnVmVDJxc1k3cWpaeG5tVVlnUlZDMmh3RFBkTndv?= =?utf-8?B?TVAzanM5RU5qNFJMTlFKYjRyNzg4a01VV3BoVXMyWUlQOGNMa2xUZmxKK3hu?= =?utf-8?B?RmFLNFRHY251U2Y5emVUN3F6bG5EbGsxVDBVZUg0Y00yZU04TW5nNlJHREIx?= =?utf-8?B?Q1VVblgzbGV4SjdEMkY5dVV2SnllaEZCMFJ6QzZ0MWhhWWZiWnhhL2loZXMz?= =?utf-8?B?VVdWWTBOVEFIbEExZ2U2Wll3eEJOejFIR3RSYWRKeGZuSFhLZko0dzlFMkNN?= =?utf-8?B?R3Z1VWIrUWE5dUhaWGdXN0VMTWlmMnRSRktKUFNuVDE3b0tUeWlxT3FocjE2?= =?utf-8?B?UzRMOWlXbXAwY0RqS3VXekQ1eGJpVk9STGlJMGNhdnM2bmh3U3VERUpDRHJo?= =?utf-8?Q?w0eg=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2e563fb-e123-44f2-7267-08dbe154e69d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2023 18:51:36.7808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NSWJ29liLjtJcyDH/mDfUUsBCawQ/cmfgyO63/whVutPwme1bRW+B8ydh4brenln X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8134 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/8/2023 3:44 AM, Jie Hai wrote: > From: Dengdui Huang > > The data region in VF to PF mbx memssage command is > s/memssage/message/ Same for next patch > used to communicate with PF driver. And this data > region exists as an array. As a result, some complicated > feature commands, like setting promisc mode, map/unmap > ring vector and setting VLAN id, have to use magic number > to set them. This isn't good for maintenance of driver. > So this patch refactors these messages by extracting an > hns3_vf_to_pf_msg structure. > > In addition, the PF link change event message is reported > by the firmware and is reported in hns3_mbx_vf_to_pf_cmd > format, it also needs to be modified. > > Fixes: 463e748964f5 ("net/hns3: support mailbox") > Cc: stable@dpdk.org > > Signed-off-by: Dengdui Huang > Signed-off-by: Jie Hai <...>