From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id DAB5C2BD9 for ; Mon, 25 Jul 2016 17:47:40 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id f65so140848208wmi.0 for ; Mon, 25 Jul 2016 08:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=84uJR40z1kpy7low3sS4Qv+WBUboPVmjbnF96VYNqsg=; b=dXgsJEX1yvjjaWcC0UVnw5ebMbJjpCRhZg22LtUKUT78LSLZkdx6oNRxKm7NOj2fgv 8vHWA2Biqs3IiI5O45BmO/sYfOSGLkkHzJ5+1u7dsVNlNANPJI7U2/WwyuUoLnhGgF1O 39gwHNGrduxpHQ7UzNVJkrtCah1LAXboHxVU64OZ16cSRr1otYz9Ge4ZKXsjQKZmLxDv ePKVpIN8/r+z/kmGWGaYaVNPpXqFYsAa12/YCFX1Eo8HFNn9u9B47zmTarMCydEhjKVr teD9PJjqEdgrDis4Jph4/P317OKGthR54Z/hF+SJkwRsH9os/YhdvnOyfkr4LyTiECcr fBkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=84uJR40z1kpy7low3sS4Qv+WBUboPVmjbnF96VYNqsg=; b=a6QkRK3W4gQ5HCdqmbxBHuhJallkSq7xEYjCPH+G7iJ6jMAzMkRwN0VrpkNJZ0+dDO Zhukhgf8Youg0H6X6MiRfAbwLGFiQclNFn4kZVwB48JdmIV/ickNcPhE0pL4jthozTLu QnqGt1dahScZwP2CMUk4QyU/jEGd/kp559lIOKZ5HhijgmLfLlkefaiEKorPG9y+oxnO 4D2tyeHnx7d8QGfbkmD5IlHhCDAdM359JrQgZsADv2pDcWctHmBJq+vv5lQufR6gWR/I ymIkzmdzUHAytdEqa/23n9biKw0Hka4GqPTY1sW/Tmcv3bcals1JgmzVV2QjvePryc0u Vj6w== X-Gm-Message-State: AEkoousA6wjTmoLYYjbd192LU7hMviaXOZMS4Ivzyoe4Vf6PiEsq/p7weAe+adVMhlzndPdA X-Received: by 10.194.61.205 with SMTP id s13mr15653566wjr.86.1469461660551; Mon, 25 Jul 2016 08:47:40 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q23sm28090582wme.17.2016.07.25.08.47.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jul 2016 08:47:39 -0700 (PDT) From: Thomas Monjalon To: Maxime Coquelin Cc: Yuanhan Liu , huawei.xie@intel.com, dev@dpdk.org Date: Mon, 25 Jul 2016 17:47:38 +0200 Message-ID: <8594081.HlfyGW5kfQ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160725152412.GS28708@yliu-dev.sh.intel.com> References: <1469455798-19790-1-git-send-email-maxime.coquelin@redhat.com> <20160725152412.GS28708@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vhost: fix off-by-one error on nr_desc check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2016 15:47:41 -0000 2016-07-25 23:24, Yuanhan Liu: > On Mon, Jul 25, 2016 at 04:09:58PM +0200, Maxime Coquelin wrote: > > nr_desc is not an index but the number of descriptors, > > so can be equal to the virtqueue size. > > > > Fixes: a436f53ebfeb ("vhost: avoid dead loop chain") > > > > Cc: Yuanhan Liu > > Signed-off-by: Maxime Coquelin > > Thanks for catching it! > > > --- > > Hi Yuanhan, > > > > I faced the bug while testing my indirect descriptor patch, it happens > > as soon as the number of chained descritors is above 2. > > > > But the bug may in theory also be faced with normal descriptors, > > In theory, yes, and only in one case, that there is a Tx has 256 > descriptors chained. If that happens, I doubt things work well. > So I would say it just happens __in theory__. > > > so it might > > be good to have it 16.07? > > Even though, it apparently fixes a bug, so I think we could have it > for 16.07. > > Acked-by: Yuanhan Liu Applied, thanks