From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 701B842C01; Thu, 1 Jun 2023 10:26:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3DB4406BA; Thu, 1 Jun 2023 10:26:36 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2045.outbound.protection.outlook.com [40.107.237.45]) by mails.dpdk.org (Postfix) with ESMTP id C5C96406B3 for ; Thu, 1 Jun 2023 10:26:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kw2xQkHYPIfXPGRPK4nKoX/wX7hHozoKWjd3kFVruXsVtq8Hskpoh6IIf/7taE8Wgc1aHD2+zr1lkqIjH1ksqC8RKffUHshGWKItDGjD1+y6h7GljfDKzLrv3tlhqxLF9AGOCr5434RmoeTKvWHDKYWZxn7MNzbVl+vTDrq3IE837nMZ9MhffGNWUYH3Ab0uDW+ywoGQ4eo4yUJH0u3IJzdWPuu3AG7GPx7gSSoE2Jmrqwu+750Di/fQKfMgy13Tlyn3h0QiSj6IFF00jdUxzzjIn++la/8El56vgidxv9O7rbLz+Mk4I+B9mVrONBKyPEkSPRun0RlQjkpKuYgoeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/siU+R0pw3Bh+csMWJ3CpSdGLUv3Ju2O97NUK7/lh4=; b=XB524zNGw/SfDDorNzbmtGgz8kvGpjUYVZbbPn529BabKeI4Mf8eGzKrxlmFoqw2HT6BatlblgIZPLQn30iMbc0KRyfUmS0OhcsNQIdKkuHtZHbaIbYbvh/JWRfQbPdWxWrwctTNKhYoq4zuUr8x3S+dwAsJAaRgFXvxAAS7g3jhQT4Ult/00GJO8K8SRv44dL9VRqhu3k3a5dXFKF4JGwF3G1ntEYCaAulrmM4x/9hKAIfUNVzlGPXGPLXt5n5vIxHBzsPwFxa1GKWsQELokA4M1kNiUQbyRPEjqgWYoexzD8sZ35D5Mpzhbx1Cc12kpYxFsgB88iOlvqC3UqcgyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w/siU+R0pw3Bh+csMWJ3CpSdGLUv3Ju2O97NUK7/lh4=; b=snB3jHx8m4Go0Mdea83B1qamwV/Cu4G3lUnDWgWl69V6G61+/ySUxJA3eAECxnZVErn67gh9eSg+QpkzAmXTlc+D+8gXZ1FZAuXWI/MfaERPnVfiDvpRTcR25ZsRlwPAcFvQYOj093jR6YvhmG6hRGy2PIv3AcaYKMjDQCYYPt0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB7684.namprd12.prod.outlook.com (2603:10b6:930:87::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Thu, 1 Jun 2023 08:26:33 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6433.022; Thu, 1 Jun 2023 08:26:33 +0000 Message-ID: <859b86f2-888f-b60b-b10e-d83d3a37fe7e@amd.com> Date: Thu, 1 Jun 2023 09:26:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Rushil Gupta , qi.z.zhang@intel.com Cc: junfeng.guo@intel.com, dev@dpdk.org References: <20230601031513.453016-1-rushilg@google.com> <20230601044950.465926-1-rushilg@google.com> From: Ferruh Yigit Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility In-Reply-To: <20230601044950.465926-1-rushilg@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0457.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB7684:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bf6d21b-8e28-46d5-b889-08db6279e84f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z1WUsXoHn9tkL1swpCfBjSVzm4oim3AzrY1dvNMB4Mz1/mvJL4PDiuRYVfD45bvvoaxnW+eBE1EFPnGeBuxaoZVrfNSy2bJsWdBp7hz3d5NTfDROORkwp4bv+Vr7XyV8yoPg5JliudfJsNjaajsYMAeUB0nsjlbSMvMeiWXvnS9EH86RzxqI+GwZkradMK+J0ikkG9ohzQaqfYuphV7e0EQI9DzSW/OFy1bxPk04kBwu41J9CC3PMTaSkIfLtmQdpfMGtknz/JYySfpnGC9CtNvp0BHVZRh84GvvZFsdB3B5t9jS7cs5ZFWFFCUlLZz/xKq4WpoHMXPZOIT/cIqQZwKtIZvggQ6xsP2eWwhUHhoTPObSYWMTS4rGeGYTLnrKhcKBdbQiN29WqjqzgVewGaPUYO64/Zdgwtmgb+mj6Cc9eC5bfvfuRN3LTn9xbfTlrie6MUmsSHVkf3PPLQaT1TXzqUw/eQm5fyZUtK4lJlCJKB2lFhL/Yi1/YXWwk0QUm7c2a1H+L74JVHob3QsOPTrUsRTBXV226jbOXFRYK9gnL9oyIATmBstqE6LJv+GqCEZgfXnDQ8zVH7qymm7a/nsef4HMnpHLsFnH8qVq86zHf+V5a7hl4F+ZTJHNgvgO15lObxwXE/eahWX9+AJtkg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(451199021)(4326008)(478600001)(8676002)(8936002)(44832011)(36756003)(86362001)(31696002)(2906002)(4744005)(5660300002)(66556008)(66946007)(66476007)(316002)(38100700002)(41300700001)(2616005)(186003)(26005)(53546011)(6512007)(6506007)(6666004)(6486002)(31686004)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnorOHMrU2pWeGROeER2N29tT2JxL2NGZERUblAyNTVEcC90L2o3SWQzSVp6?= =?utf-8?B?T2tUU1ZwS0g3VUIxMkxBS1NNSmN0dGdlamM2T3QzYVRnUG9xN2RwZUMyMkd4?= =?utf-8?B?ODVPaDdqRm5neFFtUjhsTjlSMFh0RWgwSFhhbjNaZzdJVEtxL0FzSTg4c0ps?= =?utf-8?B?bEVHRndkSnY1VFBseTQwMmhDb2crMk9MYzd4dHN2SGtaSmU3N2RaUzZHVkxD?= =?utf-8?B?RFA1RzFyVzFCWDkrZkFlN28zLzZJRDFJejkrRWRZUkROVEFYOFljQVhuUHRY?= =?utf-8?B?czhBUEMwcklzZ2JxY2RtOU9hUHY2c3hvaDNIZjJrTVhXV0RoZ2lnOXJQZGZq?= =?utf-8?B?QTNSODNGbCtMWVVob0RGVU05RUkvTFJpa0FVWHp0eFpaN1dZNDVrOVNnVjR4?= =?utf-8?B?VXdQdmpLVGlaRThqWjNsa1lnZnd6U3kzSHJqNFdpbWFycnlUdFBzZkQ5Zjhv?= =?utf-8?B?NUtiUWtSektPT3FmRDJoTzVndjFaNUlZbURQK2RCbmtnei96SW9iL1IxRGQz?= =?utf-8?B?djBKcWd0U2R4WFEzc2tGQVJtc0VSUk1Uc1hSZldnVTMrUEpsUGZDdmVMaHF3?= =?utf-8?B?bkFIYlYveXZNZWRGc1d4Z3o5cnllTXQ2ZWgraXVHbExxS0tFOWUybXN1VExX?= =?utf-8?B?QllhYnQvdll1Q2pkMWFHdUNSckVmSVdYeTNVUWxrVXVHazN1VU5WMTY3THB2?= =?utf-8?B?UC8vdXlLU0x2VEF4SVI2c0ZaTFh2ZjVFT0EyZ1BSR3RoUU5iSE5JTkhCNWdj?= =?utf-8?B?ZXBqSXN5KzVQQ0NTQTNxVWpuSk1qdEd0ODVzT1FqNHcyL3l4eFY2VjdyckNB?= =?utf-8?B?ZmNwTlFvcVVjd3J6UEJWMlNyUUhhL0NhVjJJUWxTNE5lUmF1RFhNWEVWRDNC?= =?utf-8?B?SDd0bWx1aEhVVDVUMWF1OGNBSXl3NitTemNpdE1XV0hsZXdIVzJGQzk1WWl6?= =?utf-8?B?WVdlT1lwN2VXYjBOVEY1NHgxNS9CcktvMy93a29kMXJSUEdWTmx3RXBXcGNX?= =?utf-8?B?TXE1VGFHbEpZeXFBVWozdGZqcjV2eVdacG53T1lGVG05UEUxZlc2SDMwV2VU?= =?utf-8?B?dlQyaFRIZUxTbURtQ3k1a3hrcEVuVHV4QW9seVRka1hjdHhCN1IraVFKMmpN?= =?utf-8?B?UmRFbTYxTkwzbjFqTEpqTmZDK1VvRWRKYlpwSy9lY2lPK091bEpHdkVGdUZn?= =?utf-8?B?NDBzWlhybEhuT0NBK1RRTExaUWtBc3R3L240cDNRVHpyTzc2ZHdNQ0xpbFhM?= =?utf-8?B?VjUzbDZTWU1SaHJiNS9lUWk3a0xyb1l4ZHVZYXRJbm05RGZ1WDh6ZUxDTVB2?= =?utf-8?B?Zk5SeXgyMThIeFFoaHNIQUhoV01heEpicURqYk1OV1RMWHExOGkveXIweGhY?= =?utf-8?B?NVVEd3hpbjlVRS96SC9JRXFuMG80eWE1YXFxRTlSaDgrMGtyVWxUdzVzRUtS?= =?utf-8?B?QmJNV2tvaXNHeENBWTJINWFiRDNHaWFQN3Q3Zmo5c09JMUV2MFpUT1B6aC9O?= =?utf-8?B?R1FOakdBTmtDVjBzWWttcmlCSjI2bjFNRjIrNU9nbWQzZjJBZEMrUE1LSWZE?= =?utf-8?B?MXg2STg5Vk5xZ2JYRHJNa2l1OWlVRWFlTXJSZFBwMXVQdmg2RGQvbEhmUGIz?= =?utf-8?B?aFliTUQvWFRESC9iV3gySGJUekRLSGxOWG5YdmprZG1TUTNxQy9LTThla2Ix?= =?utf-8?B?c0h3aUlOa01PNzE2U1psSTZ1Rm9IT2twSHN6aXQ4bi9xT3hVeXl2TTJqeDRI?= =?utf-8?B?YXNqYW1GZEFJQUUrL2xOcUNHRENTeEY3WDVlYkN4aDFGZGNvS2lNWmN3RzZV?= =?utf-8?B?Ulk4TmswWGJPSGQ1eGN2YnBFZzRvWU9hQjZ6YVFHNStIZlBnS1Bld1kwMWJP?= =?utf-8?B?S3ZJYnBzU24vR2pqS29BVDROZ0RBWjc2RkVURWdrQ1dLZVhGbEdJYUdaa09D?= =?utf-8?B?c3F4Y0lpU2RUazNpV05ubVB1VkV1OGhacTg3UDY1QmduZWFlTVBGQmJlZENu?= =?utf-8?B?T2krelVPdnJFQ0N4cW1wL3hFZzhzT25SQkp2a3ZEd1Y1c1FYckpjb1huSzJk?= =?utf-8?B?TFpKRjNWVXkwMGN3RWJ5NGw1NklSdU1qZUlndXZmeFZNWWEzL2RoeTVHMktw?= =?utf-8?Q?eB+fIohFlgc+TMHk9MK+LT4YG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bf6d21b-8e28-46d5-b889-08db6279e84f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 08:26:33.3651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p6xPiHh+kdUTGUC1cWDizL3ST77mn7c2byiWvEJU7r3tMyMylwy6yRwUr7gWhV+u X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7684 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/1/2023 5:49 AM, Rushil Gupta wrote: > gVNIC requires physical address to be passed in the adminq command. > This was initially rightly pointed by ferruh.yigit@. > Fixed by passing 'driver_info_mem->iova'. > > Signed-off-by: Rushil Gupta > --- > drivers/net/gve/gve_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c > index 2c1e73d07a..aa75abe102 100644 > --- a/drivers/net/gve/gve_ethdev.c > +++ b/drivers/net/gve/gve_ethdev.c > @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv *priv) > (char *)driver_info->os_version_str2); > > err = gve_adminq_verify_driver_compatibility(priv, > - sizeof(struct gve_driver_info), (dma_addr_t)driver_info); > + sizeof(struct gve_driver_info), > + (dma_addr_t)driver_info_mem->iova); > Yep, this was my point, let me squashed onto original patch in next-net.