From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 740252935 for ; Fri, 28 Apr 2017 07:15:41 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 22:15:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="79918175" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.172.161]) ([10.252.172.161]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2017 22:15:39 -0700 To: Declan Doherty , wang wei , dev@dpdk.org References: <20170425063049.4705-1-lnykww@gmail.com> From: Ferruh Yigit Message-ID: <85cf5d3b-1f4a-4d0d-8da2-4035c3ec66d1@intel.com> Date: Fri, 28 Apr 2017 06:15:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix updating the slave link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 05:15:42 -0000 On 4/27/2017 3:28 PM, Declan Doherty wrote: > On 25/04/2017 7:30 AM, wang wei wrote: >> we need to update dev->data->dev_link before handling lsc event. >> Otherwise it will still have the initial value after the startup of >> the program before interrupt callback was executed. >> >> Signed-off-by: wang wei >> --- >> drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c >> index c94071ffb..57b1012c4 100644 >> --- a/drivers/net/bonding/rte_eth_bond_pmd.c >> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >> @@ -1435,9 +1435,11 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, >> } >> >> /* If lsc interrupt is set, check initial slave's link status */ >> - if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) >> + if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) { >> + slave_eth_dev->dev_ops->link_update(slave_eth_dev, 0); >> bond_ethdev_lsc_event_callback(slave_eth_dev->data->port_id, >> RTE_ETH_EVENT_INTR_LSC, &bonded_eth_dev->data->port_id); >> + } >> >> return 0; >> } >> > > Acked-by: Declan Doherty Applied to dpdk-next-net/master, thanks.