From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4079A45913; Wed, 11 Sep 2024 02:16:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7FF740DDB; Wed, 11 Sep 2024 02:16:34 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2078.outbound.protection.outlook.com [40.107.102.78]) by mails.dpdk.org (Postfix) with ESMTP id 128A7402DE for ; Wed, 11 Sep 2024 02:16:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=baP8YibZYfWmvZGEyMCSSZWvrGSdHFabOXGRYiQorvPq6fwKwSlERnzj0baTzhnRT/No0rYJB8jXywiPOxZBOeSc8chmLqdM6Edk02c9XkKemSccihRjMUnGaZSR4jqKGkiszc0k9XvsVxXHCd2oTyFNCx0xOEaoVFZb86VMpHMmDC5MQZlCDhXVVjCc225ntoZ8yL5JOIAqMVxzk6BhDl6x8UiyZnrMuHLPuMyetBT98vJ9m7Ice14O6faiWZa2bAN1oH5+bMG6NmPFjos4y+ZJL1MW2E6yRY9QH9J+qQaqhroCpr8v4JfPhC/7PUOk3ARQb1DYhnIZuh2nceF82A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ezS+/RW/Uwh0fxcVTyTJBvp4acraWY7O4CY76oSwyss=; b=Zr/2FEY9VJjGLN40D5yARDUEcBuKf5dLiCJsVtBcu0juHXXGFU0Ny88wlsYhHRmOWXeyegSLaF5W9LQrzhaY9zRKb0R8ZCT4VM/+nwg3sNuTsEo8HfbCSUzTbRN0j0ObNeSw8FiSY4GOGJ8aP1fLrs00ZuxwZcsoMMGuCJUEcFguAqpwWNel57G9pJv71kUZuV6ggxVCt/3UQCxrRalHxHNDP8WDwEF5AoYExiMkfgRNgYBiVgt2JV9QR2phugh2ppoTOeF24sfUoXPBy8fP1dLwlvHmaph0uR2M4Od0F1a5OE57RU/XvIjXoHAS5TDokfVbZQNlv8+KXQ7nShSDBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ezS+/RW/Uwh0fxcVTyTJBvp4acraWY7O4CY76oSwyss=; b=NfsLvwuySZ7Rz8tuSl0tgdx1d/lxfl6rUf5zxRxvc6R0zqKcdB2B6+p8QMoShp9/KzkU8EnyR9cKBpe3M3l4vGdkZStnm6+1sduG45XsEQbopLTpzhO8bYCLM2dhzVolpFUPAksFZy4R0zMUrjxsMWid2G0g6NiERlvULznnMgY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB5766.namprd12.prod.outlook.com (2603:10b6:8:75::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.28; Wed, 11 Sep 2024 00:16:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7939.017; Wed, 11 Sep 2024 00:16:30 +0000 Message-ID: <85f2e676-046b-4f2d-8c31-d0a5532fda6e@amd.com> Date: Wed, 11 Sep 2024 01:16:26 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] doc: add new driver guidelines To: Nandini Persad , dev@dpdk.org Cc: Thomas Mojalon , Chengwen Feng References: <20240814190901.14912-1-stephen@networkplumber.org> <20240910145801.46186-1-nandinipersad361@gmail.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240910145801.46186-1-nandinipersad361@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0617.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB5766:EE_ X-MS-Office365-Filtering-Correlation-Id: 38aafb55-da19-4b67-4a53-08dcd1f6fc56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SjZOdXRlcy9OaGVpZzdVRmxTelFsa3hSVnV5N3Q3VGE5MzdtV0RuSmt4b2xr?= =?utf-8?B?NjNPRG9PdDYycXhFUFJlVVBuZXRsSXBlbnM4WDBZSW1xQ3RSWm9DQjFZRHFP?= =?utf-8?B?aVY3dWJjSHN4RUxDQkZHQXIrQndyVkZ5bk1GdmVPVFlUc3ZlQm5WcnlrbXBo?= =?utf-8?B?bVNFakJodEFDcFdZMVdObmt5T0xHdDZDZHJlc3JiS3FhU1ZCcFBWbTBsaW94?= =?utf-8?B?QVJOLzFSS2IxUnRya1VuSm54MlFjMTJlZnNXemo5Z0g2ejhJMlZSNS96UlZ2?= =?utf-8?B?UHptb2RZVTYzdnlicGZ0SzdNc1pMd2N2ZFhIUXBHMWY0eFlmUTZMT3I5TkdS?= =?utf-8?B?bTRZcWpMWTVHZTQ2MDkyTUpEQUs0bE5pSGZPdXRRTUFpQVlBeUozNmpxTm9O?= =?utf-8?B?N1d3SUcvOWFyd2xuUThUMHFwcENrUHB0dVN4a2ErcGw2bTVuaHJWMWJ5cC9U?= =?utf-8?B?cnJmV0VDUXpEMGI0bisvL1NkUGJkTVk3bU5TeGI5SVVsbjBMS3VMQjB0Q2pq?= =?utf-8?B?dGxOOW5sYzNLd2xlYmJndmk0VlBuY1B3SlRXN28zVG1MdDZEZTF6Q0RXSDlR?= =?utf-8?B?ZUdpRDlCZlAydnZSRmRpV0hDSEd4UCswaXdBYjUyN3hUNnpsdTc4UXp4QU5u?= =?utf-8?B?TEVKL2puTm5TY3VHUzVMTHV4NnNhekhkaGZwTXRYQkVMaGRpL3dKd2dDWlUy?= =?utf-8?B?U3I0Y3NKSFBZZWEzRzkweDFsbHF1WTNrKzRqMEcydS9PZmpKcmdZZW9LVlpm?= =?utf-8?B?SVV5WEsvUWQ0NndoTDJHRVJwNUFIL0d5NHZ4VUlZS3YxSGJvVmpidWZ4L3VP?= =?utf-8?B?QVA2ZlNZUnd2MHppQzFuRmRoUzUrMDlnZmhBODhXUHZnMTA2QXhKc1paU1hn?= =?utf-8?B?ZnNPWW0yUGtsenBHdERteXJDM0k5NGVRT08rWDlKNzl3WFN6anZveUYreVRF?= =?utf-8?B?M0djOU1FK255WnRxMWgrT2ttYXlQSFR3WElzSDFxRjVPRnord2hZL2x2aVBj?= =?utf-8?B?Z0dvRUdlOHMzRVlWR201MVByM3NIYkVPOUZZUk9kTGxJb2R5MFc3SEtLTDlu?= =?utf-8?B?QWozTExhSmFwS1R4UW5hK1NkTkpiaVl3LzBoSXM3eDBZZWFzU2tjQVdTQk5a?= =?utf-8?B?bE1rVlN3aldLV2JGcUduWTh1MVN6dFZKZWROeFlybVNrMkpuSEIrV2NxTVB2?= =?utf-8?B?eWZTUWR6dm9EeHBZU2VSODNpa1VQUjFNVFJ1alJBTGVCMHAyVk1vZmJYTGwv?= =?utf-8?B?OGNaQS9oT0svcC9nOEQxUkgwWVRrcjVQb1VNeHNoWnkxamJnb1NVTk90QkJl?= =?utf-8?B?Z09BQTBMdzZnTnQwUUIyTzVhYkVKSHFyMm05eURXanBES09zL3ExejArZnU5?= =?utf-8?B?OXNQenlMbE91d0F6Q1J4azFIRDlUUFZQT2pWaUEwbXJOdkpKQ2d3TmdldThO?= =?utf-8?B?eC90WExydFJCcC94aFZnQVh0Ly9vTXJQQlJXejhLNlhBa0pQcmlialJtUGZR?= =?utf-8?B?dm02MlpDbHFkN1A4elZqU3ZRWWZSN3hXUUtaZEJiMTdtTVRyMi9Vd0pMVms3?= =?utf-8?B?OUpLdFNyZVdJVWRhQytFRFVSSWtWVytRcDh5SDJFMW8ydWpUbXY2aVRraC9p?= =?utf-8?B?ZVFyY0NWTzBndUFKdkZKMmF5eVd6S3kzdmdma0NzYTZwNmFGcFQrZkd6cTlF?= =?utf-8?B?a0lSNWlQbHl2ajJUTHZEaXVqbjJVN1plWFNyUHhVc0FUbkNrdTBZcTBOTng2?= =?utf-8?B?VnVvMkQvWCs2OHdKT3ZYVHhJeXVqSWVsRkVJUnBvS1IySytDUFRjOXFpcmN0?= =?utf-8?B?SWJKZDMwK2QyWWJEMGpNZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDJnNGQyNGpYUnFwVmgxeThaTlh1ZmVVOEdjeUhNa09ENFJrdlpxUlZUL3VS?= =?utf-8?B?RHo4U3ZNV0x3YXNuaysrNHVWempsei8wZnZEVGZLL1ZsdXEvUUVIb2RBYUJD?= =?utf-8?B?UE5INmFLdDgraGF5QWFmYnVDaUt1Tjc5ZVloWlNxK3R1a2R5UWowRkJ4czZR?= =?utf-8?B?SEh0ZVFuTXdYellpY2x5MGhNdWY0cXQxOThkSTkxeHFQVU1GT3g2UnJqZ1pK?= =?utf-8?B?NmFUUlI4T0RrSjVTeHRhcjdGTHY1L2VTN2d0RkRYK04zQjI1VHJ5ZlAwNzVQ?= =?utf-8?B?VnFqVC8wNzdUK1E2Q0NlaFMwTWtYa1E3SWpVTE9CQVZkc2VxTXhmZnNQVmxu?= =?utf-8?B?MGV3bmJzc0hadjZNc0xXR0RxdmlybExtckFpb0JsQXNOY0ZRTitmWmpkUkJ6?= =?utf-8?B?dUZCVzB4QVUwV1ZQWDREY3RlVGk4WmJ3WnJDMXY0YTJMbFVYbjBKUXp4TkZC?= =?utf-8?B?Mng2MU10RWZud29ic2RZclV5TjFaNmM5TStYQ1JnMTVZQk4xWmp0UmdFbE1p?= =?utf-8?B?bWRvWkJlM0VFSjd5Nm1vU09HVVI3TVA0TGJVUDdRc1VZdFp2aENaSTcyS0k3?= =?utf-8?B?QzAyVzdicDA2NTNsSDAvQlB6emcySGJrMVdvTnQwUWVvbm9XbEJSeDZ3Y2p5?= =?utf-8?B?eC8vZFFpVEJJYldPeXNuUkJ3ZEJSYlF5eFdsQVVkMHNzbVFpTUlpdEFUMUla?= =?utf-8?B?VTdJS21DTzVNM2RVZ2loVXZlbHhWNkVleWNtcGZyRGl0dm5PazNGTjJxYnZU?= =?utf-8?B?L1FhU1dzQ0t5UDc4M0lBWHNWNkNRVzRKNFRGS1dubjVhUlhBQi9rb0RVMW1k?= =?utf-8?B?STdCZWNXcGpjeDlac253ZjNLdXJoejNDbFdEVFhRQXVZcDVXbzZNQ2RadXN5?= =?utf-8?B?WHNFS3ZLRGlJZXFKaUdsQURvS0kxR08yc1kzeExMYW5UUU92Wk9PU3REWnBB?= =?utf-8?B?elEya2pRbFJjL0NkRVAybC8rWVFFbnExejBNbTcvQmNoN0gyL1dyMjg3V2Zo?= =?utf-8?B?MndCMUprZmhxOWh0eEQvYmxkYjlCVVJ2TllhWVEyMzlJbEVueGgwQjVqRk9Q?= =?utf-8?B?NUFMeHh6YWhnRUROZy82c1hZdUdWUmhyV0dvVVR0NFB3b3lkdXlJTlFiOWVC?= =?utf-8?B?NU4vTkk1dy80aVJjRTNWU2RsT3J0MFplVGZ4ZThPVG5oaUMrTTJtaDFLYTRV?= =?utf-8?B?eGRYOGhWZGVNWjY1bGpjN2IyTGtaYk1HRFB1MTVweDUwM09DTkpjamtqL0ts?= =?utf-8?B?Tm1xMkl3K0RnaTlKeS9ZZDRLemtVamRHS2djbHY4THYrQ0IrNkw3WVlIQ2dB?= =?utf-8?B?RU9QRHJTb2pkUGxwNFdVTWovd2xrS1FBeUtCSnJPZ3NudVhORnNVYkdSNDdB?= =?utf-8?B?Q2FpeVc1ZWIzYjd2Z3EyZDM0TnNsNG1jUEpnOWpVWEs3SWFpek40dWNtTnVW?= =?utf-8?B?QTdwMXVQY2g3dmh4cjJOdVRJLzdkUTA4N2FOUHRaVnp2c2RNVDBJTzlicStk?= =?utf-8?B?TjFJdDlDSlVTcUhPTEZOeEd0Y0RlYktVS2w4bnU1TUpBbjhyT1JFclZsMUM5?= =?utf-8?B?WmZ5WGE0VnFuT2ZFRTRSVFdUTEwxVUU1Z3I4TnVQbGIxd0VKdEI5VVFaaUxK?= =?utf-8?B?Z1BuU3djZ2JmeWhCWXhPeGFOdVo1dW0rMXA3eHRGb1BmeFZnaUZrb3E2LytE?= =?utf-8?B?MGN1b3NVWWpUVHZSL3ZKR1BsdFJaTWdoT2w4a3Q0K29aT0V1RmJuQUpWTEx1?= =?utf-8?B?ZitXYmh1b1VMaEYzOE5qd0svanhZU09CK1orUVRZdVBKWm5nK1RTU3pOdXoy?= =?utf-8?B?RnJTOGVRSjFWS0kzMFdjNk5PQVhBQUJKSCtscWVZZDFTVHViY3p1SFF1UHE5?= =?utf-8?B?cE9mZit6QUQ3RVRMd2V6Vnd4MXRLQ1l5NXpZRlhlL2Z6Um1wV2NPTUN5d1Fp?= =?utf-8?B?WEhEeTViWWxORkYzMTA5d1poZ005UHRMMmVOWFB0TjlZVjVXc0QwSVZyb1pJ?= =?utf-8?B?a3M0ekJQN3YwbDcyWWhIQmYyNmMrcCszS2VPb3dHSi9JTHN1WktRbzJDWjZu?= =?utf-8?B?VC9FSjdVdmN2Y3pwdUw0N2Q0ZjhzdzBhbjE3RWl4dTl3V0JWTVZ2VDM3SmhM?= =?utf-8?Q?vwxr0+UMjW5F/e2hKhJMiHTKu?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38aafb55-da19-4b67-4a53-08dcd1f6fc56 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2024 00:16:30.7583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zyHpwxK0kT1HMKrFMj35/qt3j6KSLqaKrgXEN8mE8E2nP4F56iHnE0axGyFbPrq5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5766 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/10/2024 3:58 PM, Nandini Persad wrote: > This document was created to assist contributors > in creating DPDK drivers, providing suggestions > and guidelines for how to upstream effectively. > There are minor differences in this v3 and v2, isn't this version on top of v2, can those changes be from Stephen? <...> > + > +Additional Suggestions > +---------------------- > + > +* We recommend using DPDK macros instead of inventing new ones in the PMD. > +* Do not include unused headers (process-iwyu.py). > +* Do not disable compiler warning in the build file. > +* Do not use #ifdef with driver-defined macros, instead prefer runtime configuration. > +* Document device parameters in the driver guide. > +* Make device operations struct 'const'. > +* Use dynamic logging. > +* Do not use DPDK version checks (via RTE_VERSION_NUM) in the upstream code. > +* Be sure to have SPDX license tags and copyright notice on each side. > +* Do not introduce public Apis directly from the driver. > API (Application Programming Interface) is an acronym and should be all uppercase, like 'APIs'. Overall the language in this list is imperative, I think it helps to make it simple, but I am not sure about the tone, I wonder if we can do better, do you have any suggestions? > + > + > +Dependencies > +------------ > + > +At times, drivers may have dependencies to external software. > +For driver dependencies, same DPDK rules for dependencies applies. > +Dependencies should be publicly and freely available to > +upstream the driver. > + > + > +Test Tools > +---------- > + > +Per patch in a patch series, be sure to use the proper test tools. > + > +* checkpatches.sh > +* check-git-log.sh > +* check-meson.py > +* check-doc-vs-code.sh > +* check-spdx-tag.sh > `check-spdx-tag.sh` seems moved in v2 to "additional suggestions", I am for keeping it here, as "additional suggestions" are more things to take into consideration during design/development, above are actual scripts that we can use to verify code. And long term intention was to move this "tools to run list" to a more generic documentation, as these are not really specific to new PMD guide, but "additional suggestions" will stay in this document.