From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CF16431EB; Tue, 24 Oct 2023 04:03:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0384F402CE; Tue, 24 Oct 2023 04:03:01 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mails.dpdk.org (Postfix) with ESMTP id F13B440298 for ; Tue, 24 Oct 2023 04:02:58 +0200 (CEST) Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39O1xhMq010660; Tue, 24 Oct 2023 02:02:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=k7igJM03xUI3G1PpIiA+HHXRfvMl3ZC0TxJym/s+FF0=; b=szowzwHirlcBUOIMZfzJtK+RgdnkykKfFtDxjBrzbugfFme+gGKMoG92E2IK6GMQHwAu vsXOk/EPSc4gJDje7T+3Ds8ph/3erQR8OnwRQgjFwWJqtKtjl9uV6xmXGa7D07mxFQk7 jvBOpQ5US/ZDmkbZfRV3yMCCGHcplq4JseA2O1RVchV1pYeSCPNIdMZvte9/GQ9R5Tdi 9okSBvqrQ8cLcdsUhBreGgL95oAq8e1zRp98WeIN0jYdb8v7cFLerFhL+bHQlT2c5opj sA5B1Gl4usNSp6S864UafrrNpLjA2X7pXYLnlYWI9svrvvMYq72eCWXsSCRR4wbgSlXF Ng== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tx4rf87kj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Oct 2023 02:02:56 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 39O20AbV012895; Tue, 24 Oct 2023 02:02:55 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tx4rf87jb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Oct 2023 02:02:55 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 39O15Djc010224; Tue, 24 Oct 2023 02:02:54 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3tvsbycjn3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Oct 2023 02:02:54 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 39O22sKM57803064 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Oct 2023 02:02:54 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1ED7158056; Tue, 24 Oct 2023 02:02:54 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8C2FF58069; Tue, 24 Oct 2023 02:02:53 +0000 (GMT) Received: from [9.61.122.13] (unknown [9.61.122.13]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTPS; Tue, 24 Oct 2023 02:02:53 +0000 (GMT) Message-ID: <85f828e2-6880-0619-a829-4e139ce9ac73@linux.vnet.ibm.com> Date: Mon, 23 Oct 2023 19:02:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2] eal/linux: eal/linux: verify mmu type for DPDK support (ppc64le) Content-Language: en-US To: thomas@monjalon.net, Ruifeng Wang , Min Zhou , Stanislaw Kardach , Bruce Richardson , Konstantin Ananyev Cc: dev@dpdk.org References: <20231010225100.335049-1-drc@linux.vnet.ibm.com> <20231023231939.188417-1-drc@linux.vnet.ibm.com> From: David Christensen In-Reply-To: <20231023231939.188417-1-drc@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: mRH9NxK4t5p2F5Q53dL6fjo6HfkUIjos X-Proofpoint-GUID: rHV7tX90KUQm3-cCYTs1aXYJFdW7GIT4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-24_01,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=729 priorityscore=1501 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 impostorscore=0 suspectscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001 definitions=main-2310240016 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/23/23 4:19 PM, David Christensen wrote: > diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h > index ebd496b537cf..7d84adb5b328 100644 > --- a/lib/eal/common/eal_private.h > +++ b/lib/eal/common/eal_private.h > @@ -354,6 +354,13 @@ unsigned eal_cpu_core_id(unsigned lcore_id); > */ > int eal_cpu_detected(unsigned lcore_id); > > +/** > + * Check for architecture supported MMU. > + * > + * This function is private to the EAL. > + */ > +bool eal_mmu_supported_arch(void); > + ... > diff --git a/lib/eal/ppc/rte_mmu.c b/lib/eal/ppc/rte_mmu.c > new file mode 100644 > index 000000000000..017a8768bce3 > --- /dev/null > +++ b/lib/eal/ppc/rte_mmu.c > @@ -0,0 +1,53 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright (C) IBM Corporation 2023 > + */ > + > +#include "rte_log.h" > +#include "eal_private.h" > + > +bool > +eal_mmu_supported_arch(void) > +{ > + static const char proc_cpuinfo[] = "/proc/cpuinfo"; Belatedly recognized that I'd implemented an OS specific detection mechanism for a function in the "common" library. I'll resubmit a v3 under the "linux" subtree shortly. Dave