From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 633F8C3F0
 for <dev@dpdk.org>; Mon,  3 Aug 2015 02:51:45 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 02 Aug 2015 17:51:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,598,1432623600"; d="scan'208";a="617947572"
Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86])
 by orsmga003.jf.intel.com with ESMTP; 02 Aug 2015 17:51:43 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Mon, 3 Aug 2015 08:51:42 +0800
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.38]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.213]) with mapi id 14.03.0224.002;
 Mon, 3 Aug 2015 08:51:40 +0800
From: "Liu, Yong" <yong.liu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match
 limited cache_size
Thread-Index: AQHQya3JcUa2FCIzzkCV0t3XWriZwp34ulUAgAC5reA=
Date: Mon, 3 Aug 2015 00:51:40 +0000
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10EB3A52@SHSMSX103.ccr.corp.intel.com>
References: <1438140121-9011-1-git-send-email-yong.liu@intel.com>
 <3134557.VXyn7jiyUM@xps13>
In-Reply-To: <3134557.VXyn7jiyUM@xps13>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match
 limited cache_size
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2015 00:51:45 -0000

Thanks Thomas.

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, August 03, 2015 5:27 AM
> To: Liu, Yong
> Cc: dev@dpdk.org; olivier.matz@6wind.com; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH] app test: fix mempool cache_size not matc=
h
> limited cache_size
>=20
> 2015-07-29 11:22, Yong Liu:
> > In previous setting, mempool size and cache_size are both 32.
> > This is not satisfied with cache_size checking rule by now.
> > Cache size should less than CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE and
> mempool size / 1.5.
>=20
> Sorry I don't really understand this explanation.
>=20

This information is stripped from the description for parameter cache_size =
of function rte_mempool_create.
Now rte_mempool_create function will check cache_size value less than mempo=
ol size /1.5.=20

In test_sched.c, mempool size and cache size are all 32 and not match mempo=
ol cache size checking rule.
This will cause sched_autotest not work.=20


> >  #define NB_MBUF          32
> >  #define MBUF_DATA_SZ     (2048 + RTE_PKTMBUF_HEADROOM)
> > -#define PKT_BURST_SZ     32
> > +#define PKT_BURST_SZ     0
> >  #define MEMPOOL_CACHE_SZ PKT_BURST_SZ
>=20
> Shouldn't be MEMPOOL_CACHE_SZ to set to 0?

Macro PKT_BURST_SZ not used in this file, MEMPOOL_CACHE_SZ should be set to=
 0.