From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E0D93C320 for ; Tue, 4 Aug 2015 11:12:16 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 04 Aug 2015 02:12:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,607,1432623600"; d="scan'208";a="776382972" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by fmsmga002.fm.intel.com with ESMTP; 04 Aug 2015 02:12:04 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 4 Aug 2015 17:12:02 +0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.38]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.213]) with mapi id 14.03.0224.002; Tue, 4 Aug 2015 17:12:01 +0800 From: "Liu, Yong" To: "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] i40e:remove unlikely check in i40e_xmit_pkts for checksum offload Thread-Index: AQHQzotBRbA5pl7CzE6sq0K/MUtJHp37jf2A Date: Tue, 4 Aug 2015 09:12:00 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10EB490B@SHSMSX103.ccr.corp.intel.com> References: <1438675031-13872-1-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1438675031-13872-1-git-send-email-jijiang.liu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e:remove unlikely check in i40e_xmit_pkts for checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2015 09:12:17 -0000 Acked-by: Marvin Liu > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > Sent: Tuesday, August 04, 2015 3:57 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] i40e:remove unlikely check in i40e_xmit_pkts > for checksum offload >=20 > The i40e_xmit_pkts() is called, which often means HW offload is used here= , > so we had better remove 'unlikely' check for checksum offload. >=20 > Signed-off-by: Jijiang Liu > --- > drivers/net/i40e/i40e_rxtx.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 6cc069b..eae4ab0 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -1917,12 +1917,12 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf > **tx_pkts, uint16_t nb_pkts) >=20 > /* Enable checksum offloading */ > cd_tunneling_params =3D 0; > - if (unlikely(ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK)) { > + if (ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK) { > i40e_txd_enable_checksum(ol_flags, &td_cmd, &td_offset, > tx_offload, &cd_tunneling_params); > } >=20 > - if (unlikely(nb_ctx)) { > + if (nb_ctx) { > /* Setup TX context descriptor if required */ > volatile struct i40e_tx_context_desc *ctx_txd =3D > (volatile struct i40e_tx_context_desc *)\ > -- > 1.7.7.6