From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 56001937A
 for <dev@dpdk.org>; Fri, 13 Nov 2015 07:08:23 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 12 Nov 2015 22:08:22 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,286,1444719600"; d="scan'208";a="836586975"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
 by fmsmga001.fm.intel.com with ESMTP; 12 Nov 2015 22:08:22 -0800
Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 12 Nov 2015 22:08:21 -0800
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 12 Nov 2015 22:08:21 -0800
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.138]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.42]) with mapi id 14.03.0248.002;
 Fri, 13 Nov 2015 14:08:19 +0800
From: "Liu, Yong" <yong.liu@intel.com>
To: "Liang, Cunming" <cunming.liang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error
Thread-Index: AQHRHb4TqoZIHYUxRkeCWQsDZtdJ4J6ZduBg
Date: Fri, 13 Nov 2015 06:08:19 +0000
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F666EB@SHSMSX103.ccr.corp.intel.com>
References: <1447383027-11140-1-git-send-email-cunming.liang@intel.com>
In-Reply-To: <1447383027-11140-1-git-send-email-cunming.liang@intel.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2015 06:08:23 -0000

Tested-by: Yong Liu <yong.liu@intel.com>

> -----Original Message-----
> From: Liang, Cunming
> Sent: Friday, November 13, 2015 10:50 AM
> To: dev@dpdk.org
> Cc: Liu, Yong; Liang, Cunming
> Subject: [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error
>=20
> The vector number may change during 'dev_start'. Before enabling a new
> vector mapping,
> it's necessary to disable/unmap the previous setting.
>=20
> Fixes: 7ab8500037f6 ("ixgbe: fix VF start with PF stopped")
>=20
> Reported-by: Yong Liu <yong.liu@intel.com>
> Signed-off-by: Cunming Liang <cunming.liang@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 19ddb52..c2be264 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -1976,6 +1976,9 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
>  		return -EINVAL;
>  	}
>=20
> +	/* disable uio/vfio intr/eventfd mapping */
> +	rte_intr_disable(intr_handle);
> +
>  	/* stop adapter */
>  	hw->adapter_stopped =3D 0;
>  	ixgbe_stop_adapter(hw);
> --
> 2.4.3