From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8682B475D for ; Mon, 11 Apr 2016 11:46:26 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 11 Apr 2016 02:46:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,462,1455004800"; d="scan'208";a="952405138" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 11 Apr 2016 02:46:03 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 11 Apr 2016 02:46:03 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.155]) with mapi id 14.03.0248.002; Mon, 11 Apr 2016 17:46:01 +0800 From: "Liu, Yong" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] examples/vm_power_manager: fix build with libvirt version < 0.9.3 Thread-Index: AQHRk89H1zNvwiDE/USbaSdXQz5Ncp+D+t2AgACHsKA= Date: Mon, 11 Apr 2016 09:46:00 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E14EF01D0@SHSMSX101.ccr.corp.intel.com> References: <1460346357-26592-1-git-send-email-yong.liu@intel.com> <1460364631-28381-1-git-send-email-yong.liu@intel.com> <1729179.ZFCP7VmEgh@xps13> In-Reply-To: <1729179.ZFCP7VmEgh@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzZiMWFlNGEtOGRjZC00YjJlLWJmZDgtM2IyYzA2NjczN2Y1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InJVZ1RLa1VUcW11K0xxWFR5OTl5ZkFZZ0FEakFvdXoyRUp3Tkk1QjJWZlk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/vm_power_manager: fix build with libvirt version < 0.9.3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2016 09:46:27 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, April 11, 2016 5:27 PM > To: Liu, Yong > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] examples/vm_power_manager: fix build > with libvirt version < 0.9.3 >=20 > 2016-04-11 16:50, Marvin Liu: > > Fixes: 2e099bc5d104 ("fix split of compiler and linker options") >=20 > As commented earlier, I don't think it is the origin of the issue. >=20 Yes, this issue existed from the original. 2e099bc5d104 is the first builda= ble version. I will change commit to original version.=20 > > +$(info "vm_power_manager required libvirt version >=3D 0.9.3, please > update libvirt-devel first") >=20 > "required" should be "requires". > libvirt-devel is the name of the package on some distributions, but > it is not always the case. Moreover, the whole libvirt package must be > updated atomically, not only the headers. That's why I think it's better > to remove this part and just keep: > "vm_power_manager requires libvirt version >=3D 0.9.3" >=20 > Other issue: it would better to use $(error to generate a compilation > error. > But the example should not be skipped from examples/Makefile in this case= . Thanks, will generate error when libvirt not meet requirement.