From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 93E34FA70 for ; Fri, 20 Jan 2017 03:19:20 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 19 Jan 2017 18:19:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,256,1477983600"; d="scan'208";a="811069521" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jan 2017 18:19:19 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 18:19:19 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 18:19:19 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Fri, 20 Jan 2017 10:18:36 +0800 From: "Liu, Yong" To: "Lu, Wenzhuo" , Adrien Mazarguil , Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter Thread-Index: AQHSchWEFialo9zbtU26LrRz/fagIaE+/GIAgACh2wCAAH1vgIAAhmGg Date: Fri, 20 Jan 2017 02:18:35 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D4E325@SHSMSX103.ccr.corp.intel.com> References: <1484804043-50156-1-git-send-email-yong.liu@intel.com> <2857373.EhiM2j9T0R@xps13> <20170119184552.GB3779@6wind.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B55C21C@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B55C21C@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 02:19:21 -0000 Wenzhou, thanks for note. > -----Original Message----- > From: Lu, Wenzhuo > Sent: Friday, January 20, 2017 10:15 AM > To: Adrien Mazarguil ; Thomas Monjalon > > Cc: Liu, Yong ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter >=20 > Hi Adrien, Thomas, Yong, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil > > Sent: Friday, January 20, 2017 2:46 AM > > To: Thomas Monjalon > > Cc: Liu, Yong; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cloud > > filter > > > > On Thu, Jan 19, 2017 at 10:06:34AM +0100, Thomas Monjalon wrote: > > > 2017-01-19 13:34, Yong Liu: > > > > +* ABI changes are planned for 17.05: structure > > > > +``rte_eth_tunnel_filter_conf`` > > > > + will be extended with a new member ``vf_id`` in order to enable > > > > +cloud filter > > > > + on VF device. > > > > > > I think we should stop rely on this API, and migrate to rte_flow inst= ead. > > > Adrien any thought? > > > > I'm all for using rte_flow in any case. I've already documented an > > approach to convert TUNNEL filter rules to rte_flow rules [1], > > although it may be incomplete due to my limited experience with this > > filter type. We already know several tunnel item types must be added > > (currently only VXLAN is defined). > > > > I understand ixgbe/i40e currently map rte_flow on top of the legacy > > framework, therefore extending this structure might still be needed in > > the meantime. Not sure we should prevent this change as long as such > > rules can be configured through rte_flow as well. > > > > [1] > > http://dpdk.org/doc/guides/prog_guide/rte_flow.html#tunnel-to-eth-ipv4 > > - > > ipv6-vxlan-or-other-queue > The problem is we haven't finished transferring all the functions from th= e regular > filters to the generic filters. > For example, igb, fm10k and enic haven't support generic filters yet. Ixg= be and > i40e have supported the basic functions, but some advance features are no= t > transferred to generic filters yet. > Seems it's not the time to remove the regular filters. Yong, I suggest to= support > both generic filter and regular filter in parallel. > So, we need to announce ABI change for the regular filter, until someday = we > remove the regular filter API. I will enable VF support both in generic filter and original cloud filter A= PI. So I think we still need ABI announcement for structure modification. >=20 > > > > -- > > Adrien Mazarguil > > 6WIND