From: "Liu, Yong" <yong.liu@intel.com>
To: 'Maxime Coquelin' <maxime.coquelin@redhat.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Cc: "'dev@dpdk.org'" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: fix batch enqueue only handle few packets
Date: Thu, 7 Nov 2019 09:59:20 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E633F441B@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E633F430F@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: Liu, Yong
> Sent: Thursday, November 07, 2019 4:29 PM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; Bie, Tiwei
> <tiwei.bie@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] vhost: fix batch enqueue only handle few packets
>
>
>
> > -----Original Message-----
> > From: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Sent: Thursday, November 07, 2019 4:20 PM
> > To: Liu, Yong <yong.liu@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>;
> Wang,
> > Zhihong <zhihong.wang@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH] vhost: fix batch enqueue only handle few packets
> >
> >
> >
> > On 11/7/19 3:37 PM, Marvin Liu wrote:
> > > After enqueue function finished, packet index has been increased.
> Batch
> > > enqueue function should retrieve mbuf structure pointed by that index.
> > >
> > > Fixes: 0294211bb6dc ("vhost: optimize packed ring enqueue")
> > >
> > > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> > > ---
> > > lib/librte_vhost/virtio_net.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > Applied to dpdk-next-virtio/master
> >
> > Can you please run again the performance benchmarks, and see what is the
> > loss, if any?
> >
> Sure, I will rerun the performance benchmarks.
>
latest result with gcc9.0.1.
+---------------------------------------------------+
| | 19.08 | + opt |
|-----------------------------------|-------|-------|
| 1518B PvP | 2.63M | 3.07M |
|-----------------------------------|-------|-------|
| 64B loopback | 7.81M | 12.3M |
|-----------------------------------|-------|-------|
| 1518B loopback | 3.59M | 4.54M |
|-----------------------------------|-------|-------|
| 16K chained loopback | 297K | 322K |
|-----------------------------------|-------|-------|
| 50% 256B + 50% 16K | 688K | 959K |
|-----------------------------------|-------|-------|
| pktgen_sample03_burst_single_flow | 5.78M | 5.80M |
+---------------------------------------------------+
> Thanks,
> Marvin
>
> > Thanks,
> > Maxime
prev parent reply other threads:[~2019-11-07 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 14:37 Marvin Liu
2019-11-07 8:11 ` Maxime Coquelin
2019-11-07 8:20 ` Maxime Coquelin
2019-11-07 8:29 ` Liu, Yong
2019-11-07 9:59 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E633F441B@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).