From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 402D746048; Fri, 10 Jan 2025 10:27:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3FFC41148; Fri, 10 Jan 2025 10:27:04 +0100 (CET) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id B835140648 for ; Fri, 10 Jan 2025 10:27:02 +0100 (CET) Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YTx8q4kFvz6L4wL; Fri, 10 Jan 2025 17:25:47 +0800 (CST) Received: from frapeml500005.china.huawei.com (unknown [7.182.85.13]) by mail.maildlp.com (Postfix) with ESMTPS id 8374B14022E; Fri, 10 Jan 2025 17:27:01 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml500005.china.huawei.com (7.182.85.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 10 Jan 2025 10:27:01 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Fri, 10 Jan 2025 10:27:01 +0100 From: Konstantin Ananyev To: Andre Muezerie CC: "dev@dpdk.org" , "thomas@monjalon.net" , "david.marchand@redhat.com" Subject: RE: [PATCH v13 00/21] remove use of VLAs for Windows Thread-Topic: [PATCH v13 00/21] remove use of VLAs for Windows Thread-Index: AQHbXxw6vyrPsK5bA0yO55sxHLiWRbMM4QoggAJ3vwCAAGucIA== Date: Fri, 10 Jan 2025 09:27:01 +0000 Message-ID: <8624ce0535e24e8887eaed79809abf73@huawei.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1736045218-15957-1-git-send-email-andremue@linux.microsoft.com> <53d15efde9454580a120c7775829ba6a@huawei.com> <20250110035820.GA18907@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20250110035820.GA18907@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.48.155.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Wed, Jan 08, 2025 at 01:30:13PM +0000, Konstantin Ananyev wrote: > > > > > > > As per guidance technical board meeting 2024/04/17. This series > > > removes the use of VLAs from code built for Windows for all 3 > > > toolchains. If there are additional opportunities to convert VLAs > > > to regular C arrays please provide the details for incorporation > > > into the series. > > > > > > MSVC does not support VLAs, replace VLAs with standard C arrays > > > or alloca(). alloca() is available for all toolchain/platform > > > combinations officially supported by DPDK. > > > > > > v13: > > > * increase stack allocated buffer size in > > > ipv4_reassembly_interleaved_flows_perf and > > > ipv6_reassembly_interleaved_flows_perf to avoid > > > STATUS_STACK_BUFFER_OVERRUN on Windows using MSVC > > > > > > v12: > > > * update commit message for patch 06/21 to avoid warning > > > > > > v11: > > > * add include stdlib.h for alloca() declaration on FreeBSD > > > * zero-initialize array without code loop > > > * increase maximum tuple length > > > > > > v10: > > > * add ifdef to scope gcc's diagnostic error down to gcc only > > > > > > v9: > > > * fix sender's email address > > > * fix gcc's diagnostic error string to make clang happy > > > > > > v8: > > > * rebase > > > * reduce scope for disabling error "-Warray-bounds=3D" to only > > > the place that needs it > > > * remove parentesis around numbers from defines in test_bitset.c > > > > > > v7: > > > * remove use of VLA from new file which sneaked in during review > > > > > > v6: > > > * remove use of VLA from new test code added recently > > > * fix title for patch 08/20 > > > > > > v5: > > > * add patches for net/ice, net/ixgbe and gro > > > from Konstantin Ananyev from > > > https://patchwork.dpdk.org/project/dpdk/list/?series=3D31972&archive= =3Dboth&state=3D* > > > * address debug_autotest ASan failure > > > * address array-bound error in bitset_autotest with gcc-13 > > > > > > v4: > > > * rebase and adapt for changes made in main since v3 was sent > > > * use fixed maximum array size instead of VLA when doable > > > > > > v3: > > > * address checkpatch/check git log warnings (minor typos) > > > > > > v2: > > > * replace patches for ethdev, hash, rcu and include new > > > patches for eal from Konstantin Ananyev > > > from https://patchwork.dpdk.org/project/dpdk/list/?series=3D31781 > > > > > > Andre Muezerie (3): > > > test: remove use of VLAs for Windows built code in bitset tests > > > app/testpmd: remove use of VLAs for Windows built code in > > > shared_rxq_fwd > > > hash: remove use of VLAs by using standard arrays > > > > > > Konstantin Ananyev (10): > > > eal/linux: remove use of VLAs > > > eal/common: remove use of VLAs > > > ethdev: remove use of VLAs for Windows built code > > > hash: remove use of VLAs for Windows built code > > > hash/thash: remove use of VLAs for Windows built > > > rcu: remove use of VLAs for Windows built code > > > gro: fix overwrite unprocessed packets > > > gro: remove use of VLAs > > > net/ixgbe: remove use of VLAs > > > net/ice: remove use of VLAs > > > > > > Tyler Retzlaff (8): > > > eal: include header required for alloca > > > app/testpmd: remove use of VLAs for Windows built > > > test: remove use of VLAs for Windows built code > > > common/idpf: remove use of VLAs for Windows built code > > > net/i40e: remove use of VLAs for Windows built code > > > common/mlx5: remove use of VLAs for Windows built code > > > net/mlx5: remove use of VLAs for Windows built code > > > build: enable vla warnings on Windows built code > > > > > > -- > > > > Series-Acked-by: Konstantin Ananyev > > > > One extra thing I would like to suggest: can we for each lib/driver/app= /etc. > > we made VLA free add an '-Wvla' option into corresponding meson.build? > > To prevent people re-introducing VLA code. > > > > > 2.47.0.vfs.0.3 > > >=20 > Yes, I'll do so. It will add many small patches to the patchset though. I > hope that is fine. That's ok with me, hope tree maintainers will not complain too.=20 Another possible option - combine it with particular lib changes, i.e. patch that fixing VLA usage in lib/hash can also enable -Wvla for it, and so on.