From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by dpdk.org (Postfix) with ESMTP id 8FB822BD6 for ; Wed, 23 Mar 2016 14:42:39 +0100 (CET) Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u2NDgcHa005720 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Mar 2016 13:42:38 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u2NDgcq2025197 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 23 Mar 2016 13:42:38 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u2NDgcqp013423; Wed, 23 Mar 2016 13:42:38 GMT Received: from [10.197.178.140] (/10.197.178.140) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 23 Mar 2016 06:42:37 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) From: Michael Frasca In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D04464381@shsmsx102.ccr.corp.intel.com> Date: Wed, 23 Mar 2016 09:42:36 -0400 Cc: "dev@dpdk.org" Content-Transfer-Encoding: quoted-printable Message-Id: <8634D5E0-C1B2-4194-B9A4-E0BDC982B36B@oracle.com> References: <1458665888-4577-1-git-send-email-michael.frasca@oracle.com> <4341B239C0EFF9468EE453F9E9F4604D04464381@shsmsx102.ccr.corp.intel.com> To: "Chen, Jing D" X-Mailer: Apple Mail (2.3112) X-Source-IP: userv0022.oracle.com [156.151.31.74] Subject: Re: [dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 13:42:40 -0000 Hi Jing, I ran into this issue while trying to run experiments with different RSS configurations (no RSS being one cases). It is not clear to me that = setting this register to zero is the best way to disable RSS. After digging further, I have a theory that I'm having this issues = because I've only attached my DPDK application to SR-IOV ports. In fm10k_dev_dglort_map_configure(), I see that 'RSS Length' is set for the = DGLORT decoder. However, it appears that this is only invoked for physical = functions. Could this be my problem? Is it required that I bind to the physical = function if I want to properly manipulate RSS?=20 Thanks, Mike > On Mar 22, 2016, at 11:14 PM, Chen, Jing D = wrote: >=20 > Hi, >=20 >> -----Original Message----- >> From: Michael Frasca [mailto:michael.frasca@oracle.com] >> Sent: Wednesday, March 23, 2016 12:58 AM >> To: Chen, Jing D >> Cc: dev@dpdk.org; Michael Frasca >> Subject: [PATCH] fm10k: conditionally disable RSS during device = initialization >>=20 >> If the provided configuration does not call for RSS, then RSS is >> explicitly disabled. Without this change, the device continues to >> operate under the previous RSS configuration. >>=20 >> Fixes: 57033cdf8fdc ("fm10k: add PF RSS") >>=20 >> Signed-off-by: Michael Frasca > Acked-by : Jing Chen >=20