From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 705531BA1A for ; Wed, 25 Oct 2017 18:11:32 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 25 Oct 2017 09:11:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,432,1503385200"; d="scan'208";a="167493766" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.45]) ([10.241.225.45]) by fmsmga006.fm.intel.com with ESMTP; 25 Oct 2017 09:11:30 -0700 From: Ferruh Yigit To: Gaetan Rivet , dev@dpdk.org Cc: Ajit Khaparde , Alejandro Lucero , Beilei Xing , Bruce Richardson , Cristian Dumitrescu , Declan Doherty , Jing Chen , John Miller , "John W. Linville" , Konstantin Ananyev , Matt Peters , Nelio Laranjeiro , Pascal Mazon , Shrikrishna Khare , Srisivasubramanian Srinivasan , Tetsuya Mukawa , Wenzhuo Lu , Yongseok Koh References: <946cf36f-796b-d00e-b583-2c2cf794df70@intel.com> Message-ID: <863a8065-b2dd-edf5-642d-2cbb84d69d1a@intel.com> Date: Wed, 25 Oct 2017 09:11:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <946cf36f-796b-d00e-b583-2c2cf794df70@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 16:11:33 -0000 On 10/24/2017 4:56 PM, Ferruh Yigit wrote: > On 10/24/2017 3:35 AM, Gaetan Rivet wrote: >> This flag was deprecated in the previous release, and this is its removal. > > This change was in wait list, but it would be much more better if not received > just before rc2, but in early stages in the release, at worst before rc1. > > Although patch looks good to me, getting ethdev layer update in rc2 is creating > some stress. > >> We are going from an explicit support of device detach, to an implicit one, >> with specific checks in place for PMDs not supporting the feature. > > Removing this flag implies all ethdev devices are detachable, right. > That is why you need to update error value handling in pci hotplug code, and > return error in nfp remove path, since there is no way to say not detachable. > >> >> Attempting to Cc all relevant maintainers: >> >> Cc: Ajit Khaparde >> Cc: Alejandro Lucero >> Cc: Beilei Xing >> Cc: Bruce Richardson >> Cc: Cristian Dumitrescu >> Cc: Declan Doherty >> Cc: Ferruh Yigit >> Cc: Jing Chen >> Cc: John Miller >> Cc: John W. Linville >> Cc: Konstantin Ananyev >> Cc: Matt Peters >> Cc: Nelio Laranjeiro >> Cc: Pascal Mazon >> Cc: Shrikrishna Khare >> Cc: Srisivasubramanian Srinivasan >> Cc: Tetsuya Mukawa >> Cc: Wenzhuo Lu >> Cc: Yongseok Koh >> >> Sorry for any undue ML traffic going your way if you are not interested >> in this series. >> >> I'd like to highlight Alejandro Lucero for the NFP PMD, as the patch is >> somewhat more involved for this PMD and I don't have the hardware available >> to validate the change. > > Let's give one more day to Alejandro to comment on NFP update. > > And others to comment on overall, if there is no objection include this into rc2. btw, not directly related to this patch, but related to the hotplug, testpmd crashes after detaching a port and start forwarding, anyone have bandwidth to look at this? > >> >> v2: >> >> + Split ether patch: >> First remove the use of the flag, then remove the flag >> >> + Restore RTE_ETH_DEV_BONDED_SLAVE check, >> previously hastily removed along the DETACHABLE one. >> >> + Added release note, removed deprecation notice >> >> Gaetan Rivet (6): >> ethdev: do not rely on detachable flag in detach >> ethdev: remove detachable device flag >> pci: propagate PMD removal error value for unplug >> doc: follow detachable flag disappearance >> doc: update detachable flag deprecation notice >> doc: note ether API change for detachable flag > > <...> >