From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A466DA034F; Thu, 29 Jul 2021 14:19:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6755A40DFB; Thu, 29 Jul 2021 14:19:00 +0200 (CEST) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 07F5740687 for ; Thu, 29 Jul 2021 14:18:59 +0200 (CEST) Received: by mail-wr1-f53.google.com with SMTP id q3so6741221wrx.0 for ; Thu, 29 Jul 2021 05:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=P9Ex5b09Yi7AujZlq+zs27is2+hr1qWkHSOmuvt+EfE=; b=lZr4SxT63iWTiEz6Ym5Pjkw9EdhOrYRRLMlgH1gz7B5rJGgHuQzdSwkFPO9QzX7arj wXqtgtq4bLA/ljNpy4LEaZLVh4VJKqLQbJ4BVOzv1IawMnFst7rwjgY67NNFZKQAfJwD Vhn59POD7pfvvoy8R51BW74MqiWCwx7CnzHmuzY8c4baVP19ufA8MTpJjvPd0kvUkQdq OO/bHE+lO2G0u6rTYek+bc0yPZVqfRzJRqsSqgYgd135wSwxNc9tr4tX+TdNmW+0jJ9k 5z31xsSZpGOceYGwpfzcekxAsJX5SO9s1AuG5Hp3dAmojFq+N/chcj5l6tjA4OB8s/P0 yYGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=P9Ex5b09Yi7AujZlq+zs27is2+hr1qWkHSOmuvt+EfE=; b=TjW8isDNMRkcP65/7+QIKWbzReWBa8/Cwvl9p5tNYms6BPe6Rdvf5/rUqGnPM9EbkN XNOaO5i8OzcXJWe8WJ2zHxpOtekv6zosCEVpjfc0YZDYkY5NaUXJNEKcfdmya8qN1Q/T sZuRwMq4Tmq2WV+Uas8qR5UxiNfU3gZP1bnqzGsM7fKNylRQNymGy2Ae76y2Lul8YBNh Vw82urcJZiqS2SHzW1dKZ8XDLqXXOV85u8vbUD3h4EBELEy28HGMpPrToVoru7JEZAcJ q2vutaevHUIG48SgcxKea8Up0qk6McHOlXemdIzL153Q66IkZg5NG+bYb/NfXOluPAPZ f41Q== X-Gm-Message-State: AOAM533FKZeRWOgU4EX8exgilUH8RJO2rB1El2dTTL4Ni9wAV4/ti2EZ zuBaqYJQwGGX0aKrdiHCm0ot X-Google-Smtp-Source: ABdhPJzzTkZxEuM0zbqlwJhEoFWXYLr7O1UPrigpzNErurRjqiZX+GeCPbld9C5zqJlbY0rTvJdsnw== X-Received: by 2002:a5d:6891:: with SMTP id h17mr4392433wru.324.1627561138793; Thu, 29 Jul 2021 05:18:58 -0700 (PDT) Received: from [192.168.1.63] (dsl-197-245-41-228.voxdsl.co.za. [197.245.41.228]) by smtp.gmail.com with UTF8SMTPSA id b14sm3585840wrm.43.2021.07.29.05.18.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 05:18:58 -0700 (PDT) Message-ID: <864ea6a9-68cb-cb91-4d73-7329ac2e95c1@netronome.com> Date: Thu, 29 Jul 2021 14:18:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Thomas Monjalon Cc: dev@dpdk.org, Ferruh Yigit , Andrew Rybchenko References: <20210518104115.1427712-1-ferruh.yigit@intel.com> <691e140d-ecd2-c963-0dc6-709b40be7f2b@oktetlabs.ru> <2313145.lpj6sdKJKW@thomas> From: Heinrich Kuhn In-Reply-To: <2313145.lpj6sdKJKW@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/07/23 16:14, Thomas Monjalon wrote: > Please review. > > 28/06/2021 13:13, Andrew Rybchenko: >> Hi Heinrich, >> >> could you take a look at the patch? >> >> Thanks, >> Andrew. >> >> On 5/18/21 1:41 PM, Ferruh Yigit wrote: >>> Logging should be converted to dynamic log. >>> >>> Signed-off-by: Ferruh Yigit >>> --- >>> drivers/net/nfp/nfp_net_logs.h | 7 ------- >>> 1 file changed, 7 deletions(-) >>> >>> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h >>> index 27dd87611b94..76cc94cb6565 100644 >>> --- a/drivers/net/nfp/nfp_net_logs.h >>> +++ b/drivers/net/nfp/nfp_net_logs.h >>> @@ -30,14 +30,7 @@ extern int nfp_logtype_init; >>> #define ASSERT(x) do { } while (0) >>> #endif >>> >>> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP >>> - >>> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP >>> -#define PMD_CPP_LOG(level, fmt, args...) \ >>> - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) >>> -#else >>> #define PMD_CPP_LOG(level, fmt, args...) do { } while (0) >>> -#endif >>> >>> extern int nfp_logtype_driver; >>> #define PMD_DRV_LOG(level, fmt, args...) \ > > > Hi Andrew, Apologies for the delay, looks good thanks Reviewed-by: Heinrich Kuhn