From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0A7BCA0C47;
	Mon, 14 Jun 2021 20:01:37 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BEBF84067E;
	Mon, 14 Jun 2021 20:01:36 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id E0A494067A
 for <dev@dpdk.org>; Mon, 14 Jun 2021 20:01:34 +0200 (CEST)
Received: from [192.168.1.71] (unknown [188.170.85.171])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 54F437F504;
 Mon, 14 Jun 2021 21:01:34 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 54F437F504
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1623693694;
 bh=BBKd0p41HdsKitU6OQPqRiGtJCJojnwXC/XSITCsh2Y=;
 h=Subject:To:References:From:Date:In-Reply-To;
 b=qB5tKwHJX11BYngu49NYJweWHd3mNYthwozQBHAmvsiW1fKM0UqCBPy5q4DpiOKPN
 MWCdFtn43jaiRI5S7GUHYfg8NxVIIhM9cbYFLCC/JYYoBhLGmuEZtzB0h4NapT8WS6
 tY/toF1igM2SwS8EcmwjiseU3K3Tq6rbi+FO/9F8=
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
References: <20210602094108.1575640-1-jiawenwu@trustnetic.com>
 <20210602094108.1575640-10-jiawenwu@trustnetic.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <866305b6-aa92-0155-7373-9cbc295d8628@oktetlabs.ru>
Date: Mon, 14 Jun 2021 21:01:27 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <20210602094108.1575640-10-jiawenwu@trustnetic.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 09/24] net/ngbe: add HW initialization
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/2/21 12:40 PM, Jiawen Wu wrote:
> Initialize the hardware by resetting the hardware in base code.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

[snip]

> diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
> index c2f92a8437..bb5923c485 100644
> --- a/drivers/net/ngbe/ngbe_ethdev.c
> +++ b/drivers/net/ngbe/ngbe_ethdev.c
> @@ -109,6 +109,13 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
>   		return -EIO;
>   	}
>   
> +	err = hw->mac.init_hw(hw);
> +
> +	if (err) {

Explicit comparison with 0 should be used.

> +		PMD_INIT_LOG(ERR, "Hardware Initialization Failure: %d", err);
> +		return -EIO;
> +	}
> +
>   	return 0;
>   }
>   
>