From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0AE5037B7 for ; Thu, 9 May 2019 20:55:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5D2D325936; Thu, 9 May 2019 14:55:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 14:55:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SY+gDe973u2Aqky0GM/0j/6wLg/wUddMy1VZFnC+yvI=; b=r3vNjm2sr8uq 5pWH7ND+oTtn4+9Tj9jDtXNUdjE6JhUBi3sbOr2UCIUgFExHeaVREA//YQGnlaFJ MfGvscaH5RygHCNh63PrQ3RiMMyt+QXSykTptvJ9N5lhY1iZwf8oXnNVSKO46Z8D o3ya12gyg7Tmz82yDt9KrBsQIVSAG3s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=SY+gDe973u2Aqky0GM/0j/6wLg/wUddMy1VZFnC+y vI=; b=N95J2KAMn0laTawAsHs0DXJPG2yhzaLVnt2fIIoKGX9jJ/WLrMzFDtJJt A7Y1+SFZHzVXqlQjssbluDbfz5/5gijEQm94AAJi9myUY5HT3qyTp3SxYyrrmZU+ et0M7hBpm1k6pamD2/1f8S2doIrOa1d44MNgCDki1zUsWDWkmV0ibBRELy15oezD GdRqY8S2xnhGd+5n7XFhC8dqta3lT+VshPjgglxjEHFL2yCXLH/F8NjHf4NXEcLX 4w5INHkZhq2cQ01rcwLJBMlzq5sAx4caVACEwX2TjXDqL+2VZxoIUG8BfZK2Tn3U EfjXUS1lRLvBXJBiDw8RyTVfbEYHQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CFC6B80064; Thu, 9 May 2019 14:55:50 -0400 (EDT) From: Thomas Monjalon To: Mattias =?ISO-8859-1?Q?R=F6nnblom?= Cc: dev@dpdk.org, david.hunt@intel.com Date: Thu, 09 May 2019 20:55:48 +0200 Message-ID: <8676746.4dla93uciG@xps> In-Reply-To: <20190505181216.30192-1-mattias.ronnblom@ericsson.com> References: <20190505181216.30192-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] power: fix struct cache line-alignment issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 18:55:53 -0000 05/05/2019 20:12, Mattias R=F6nnblom: > The ACPI and PState CPU frequency scaling drivers used the > __rte_cache_aligned attribute without including rte_memory.h, which > turns what looks as the declaration of a cache line-aligned struct > into a non-aligned struct declaration and the definition of an > instance of the struct. >=20 > Fixes: e6c6dc0f96 ("power: add p-state driver compatibility") > Fixes: 445c6528b5 ("power: common interface for guest and host") >=20 > Signed-off-by: Mattias R=F6nnblom No review was done but it seems to be a good fix. Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AF3B6A0096 for ; Thu, 9 May 2019 20:55:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8735544C3; Thu, 9 May 2019 20:55:54 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0AE5037B7 for ; Thu, 9 May 2019 20:55:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5D2D325936; Thu, 9 May 2019 14:55:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 14:55:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SY+gDe973u2Aqky0GM/0j/6wLg/wUddMy1VZFnC+yvI=; b=r3vNjm2sr8uq 5pWH7ND+oTtn4+9Tj9jDtXNUdjE6JhUBi3sbOr2UCIUgFExHeaVREA//YQGnlaFJ MfGvscaH5RygHCNh63PrQ3RiMMyt+QXSykTptvJ9N5lhY1iZwf8oXnNVSKO46Z8D o3ya12gyg7Tmz82yDt9KrBsQIVSAG3s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=SY+gDe973u2Aqky0GM/0j/6wLg/wUddMy1VZFnC+y vI=; b=N95J2KAMn0laTawAsHs0DXJPG2yhzaLVnt2fIIoKGX9jJ/WLrMzFDtJJt A7Y1+SFZHzVXqlQjssbluDbfz5/5gijEQm94AAJi9myUY5HT3qyTp3SxYyrrmZU+ et0M7hBpm1k6pamD2/1f8S2doIrOa1d44MNgCDki1zUsWDWkmV0ibBRELy15oezD GdRqY8S2xnhGd+5n7XFhC8dqta3lT+VshPjgglxjEHFL2yCXLH/F8NjHf4NXEcLX 4w5INHkZhq2cQ01rcwLJBMlzq5sAx4caVACEwX2TjXDqL+2VZxoIUG8BfZK2Tn3U EfjXUS1lRLvBXJBiDw8RyTVfbEYHQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CFC6B80064; Thu, 9 May 2019 14:55:50 -0400 (EDT) From: Thomas Monjalon To: Mattias =?ISO-8859-1?Q?R=F6nnblom?= Cc: dev@dpdk.org, david.hunt@intel.com Date: Thu, 09 May 2019 20:55:48 +0200 Message-ID: <8676746.4dla93uciG@xps> In-Reply-To: <20190505181216.30192-1-mattias.ronnblom@ericsson.com> References: <20190505181216.30192-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] power: fix struct cache line-alignment issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509185548.4FZPrDmbrAZcqdSFCGXB-MASnEB4WnddzJRBDffMqKI@z> 05/05/2019 20:12, Mattias R=F6nnblom: > The ACPI and PState CPU frequency scaling drivers used the > __rte_cache_aligned attribute without including rte_memory.h, which > turns what looks as the declaration of a cache line-aligned struct > into a non-aligned struct declaration and the definition of an > instance of the struct. >=20 > Fixes: e6c6dc0f96 ("power: add p-state driver compatibility") > Fixes: 445c6528b5 ("power: common interface for guest and host") >=20 > Signed-off-by: Mattias R=F6nnblom No review was done but it seems to be a good fix. Applied, thanks