* [dpdk-dev] [PATCH] power: fix struct cache line-alignment issues
@ 2019-05-05 18:12 Mattias Rönnblom
2019-05-05 18:12 ` Mattias Rönnblom
2019-05-09 18:55 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Mattias Rönnblom @ 2019-05-05 18:12 UTC (permalink / raw)
To: dev; +Cc: david.hunt, Mattias Rönnblom
The ACPI and PState CPU frequency scaling drivers used the
__rte_cache_aligned attribute without including rte_memory.h, which
turns what looks as the declaration of a cache line-aligned struct
into a non-aligned struct declaration and the definition of an
instance of the struct.
Fixes: e6c6dc0f96 ("power: add p-state driver compatibility")
Fixes: 445c6528b5 ("power: common interface for guest and host")
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
lib/librte_power/power_acpi_cpufreq.c | 5 +++--
lib/librte_power/power_pstate_cpufreq.c | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
index 5672c594e..7c386f891 100644
--- a/lib/librte_power/power_acpi_cpufreq.c
+++ b/lib/librte_power/power_acpi_cpufreq.c
@@ -12,9 +12,10 @@
#include <signal.h>
#include <limits.h>
-#include <rte_string_fns.h>
-#include <rte_memcpy.h>
#include <rte_atomic.h>
+#include <rte_memcpy.h>
+#include <rte_memory.h>
+#include <rte_string_fns.h>
#include "power_acpi_cpufreq.h"
#include "power_common.h"
diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c
index c2c4e8e14..30727f04b 100644
--- a/lib/librte_power/power_pstate_cpufreq.c
+++ b/lib/librte_power/power_pstate_cpufreq.c
@@ -14,9 +14,10 @@
#include <errno.h>
#include <inttypes.h>
-#include <rte_string_fns.h>
-#include <rte_memcpy.h>
#include <rte_atomic.h>
+#include <rte_memcpy.h>
+#include <rte_memory.h>
+#include <rte_string_fns.h>
#include "power_pstate_cpufreq.h"
#include "power_common.h"
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH] power: fix struct cache line-alignment issues
2019-05-05 18:12 [dpdk-dev] [PATCH] power: fix struct cache line-alignment issues Mattias Rönnblom
@ 2019-05-05 18:12 ` Mattias Rönnblom
2019-05-09 18:55 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Mattias Rönnblom @ 2019-05-05 18:12 UTC (permalink / raw)
To: dev; +Cc: david.hunt, Mattias Rönnblom
The ACPI and PState CPU frequency scaling drivers used the
__rte_cache_aligned attribute without including rte_memory.h, which
turns what looks as the declaration of a cache line-aligned struct
into a non-aligned struct declaration and the definition of an
instance of the struct.
Fixes: e6c6dc0f96 ("power: add p-state driver compatibility")
Fixes: 445c6528b5 ("power: common interface for guest and host")
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
lib/librte_power/power_acpi_cpufreq.c | 5 +++--
lib/librte_power/power_pstate_cpufreq.c | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
index 5672c594e..7c386f891 100644
--- a/lib/librte_power/power_acpi_cpufreq.c
+++ b/lib/librte_power/power_acpi_cpufreq.c
@@ -12,9 +12,10 @@
#include <signal.h>
#include <limits.h>
-#include <rte_string_fns.h>
-#include <rte_memcpy.h>
#include <rte_atomic.h>
+#include <rte_memcpy.h>
+#include <rte_memory.h>
+#include <rte_string_fns.h>
#include "power_acpi_cpufreq.h"
#include "power_common.h"
diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c
index c2c4e8e14..30727f04b 100644
--- a/lib/librte_power/power_pstate_cpufreq.c
+++ b/lib/librte_power/power_pstate_cpufreq.c
@@ -14,9 +14,10 @@
#include <errno.h>
#include <inttypes.h>
-#include <rte_string_fns.h>
-#include <rte_memcpy.h>
#include <rte_atomic.h>
+#include <rte_memcpy.h>
+#include <rte_memory.h>
+#include <rte_string_fns.h>
#include "power_pstate_cpufreq.h"
#include "power_common.h"
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] power: fix struct cache line-alignment issues
2019-05-05 18:12 [dpdk-dev] [PATCH] power: fix struct cache line-alignment issues Mattias Rönnblom
2019-05-05 18:12 ` Mattias Rönnblom
@ 2019-05-09 18:55 ` Thomas Monjalon
2019-05-09 18:55 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2019-05-09 18:55 UTC (permalink / raw)
To: Mattias Rönnblom; +Cc: dev, david.hunt
05/05/2019 20:12, Mattias Rönnblom:
> The ACPI and PState CPU frequency scaling drivers used the
> __rte_cache_aligned attribute without including rte_memory.h, which
> turns what looks as the declaration of a cache line-aligned struct
> into a non-aligned struct declaration and the definition of an
> instance of the struct.
>
> Fixes: e6c6dc0f96 ("power: add p-state driver compatibility")
> Fixes: 445c6528b5 ("power: common interface for guest and host")
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
No review was done but it seems to be a good fix.
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-09 18:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-05 18:12 [dpdk-dev] [PATCH] power: fix struct cache line-alignment issues Mattias Rönnblom
2019-05-05 18:12 ` Mattias Rönnblom
2019-05-09 18:55 ` Thomas Monjalon
2019-05-09 18:55 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).