From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nikita@elyzion.net>
Received: from mail.elyzion.net (ks3307715.kimsufi.com [178.32.223.91])
 by dpdk.org (Postfix) with ESMTP id 644E9298F
 for <dev@dpdk.org>; Thu,  9 Jun 2016 16:54:48 +0200 (CEST)
Received: from [10.2.213.222] (unknown [137.122.64.52])
 by mail.elyzion.net (Postfix) with ESMTPSA id 954D31CE01C0;
 Thu,  9 Jun 2016 16:34:22 +0200 (CEST)
To: Stephen Hemminger <stephen@networkplumber.org>
References: <1465433634-6667-1-git-send-email-nikita@elyzion.net>
 <1465433634-6667-3-git-send-email-nikita@elyzion.net>
 <20160608175848.28bff0d1@xeon-e3>
Cc: dev@dpdk.org
From: Nikita Kozlov <nikita@elyzion.net>
Message-ID: <867a1095-3df7-0278-90b7-aa852764a566@elyzion.net>
Date: Thu, 9 Jun 2016 16:54:45 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <20160608175848.28bff0d1@xeon-e3>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/3] librte_eal: Import FreeBSD sys/tree.h
 into librte_eal/common
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jun 2016 14:54:48 -0000

On 06/ 9/16 02:58 AM, Stephen Hemminger wrote:
> On Thu,  9 Jun 2016 02:53:53 +0200
> Nikita Kozlov <nikita@elyzion.net> wrote:
>
>> This structure is used inside the rte_lpm6 lib for storing added rules.
>> It's imported from FreeBSD-10.3 from /usr/include/sys/tree.h, another
>> solution could have been to use on Linux the version from libbsd but it
>> would create an external dependency.
>>
>> Signed-off-by: Nikita Kozlov <nikita@gandi.net>
> Using Red-black tree is a good idea, and we have been doing it for a while
> both on v4 and v6.
Yes, like I said in 1/3, the idea is taken from your patch.
I have tested it and it seemed to work pretty fine, maybe we could try
to split it a little bit and try to send it again ?
It's quite difficult to tell what was wrong with it since I cannot see
any public discussion about it.
>
> But this is not the way to handle it.
> Please don't copy a header file which is available already on both BSD and Linux.
>
>
I was quite hesitant on how to handle it. I had the feeling that dpdk
wanted to avoid external dependency so I copied that file. If it's not
the case I would be happy to resend the patches without that external
import.