From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B856A0547; Tue, 19 Oct 2021 20:17:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C67040142; Tue, 19 Oct 2021 20:17:51 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 445854003E for ; Tue, 19 Oct 2021 20:17:50 +0200 (CEST) Received: from [192.168.1.192] (unknown [188.242.181.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 9F4FA7F59B; Tue, 19 Oct 2021 21:17:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9F4FA7F59B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634667469; bh=c3nHPlRkl0QbOQJ47RJSWULf34aFLDa0Kc2tVDxDieo=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=uJO8QMxRM7VAGHxQ45wndgTurXfLBZrO9AYEK3eAlsft2T5JZEV0mO2WGzKuMyKF8 w/HeNAX5YcCVeguX3Y57HVC9RAcUOWvTyypfmXVFMwdgc93mLh6aD5lPx89pXKsFY6 jGgSzS4gfLebnsBO3HX24cofSaV+ZwP5+u9ukEoQ= To: David Marchand Cc: Olivier Matz , Dmitry Kozlyuk , Ray Kinsella , Stephen Hemminger , dev References: <20211018082635.2054-1-david.marchand@redhat.com> <79f4f029-ca13-6048-396c-232fe5ef5fb7@oktetlabs.ru> From: Andrew Rybchenko Message-ID: <8684166e-fb6b-b90f-6d95-d4f437147287@oktetlabs.ru> Date: Tue, 19 Oct 2021 21:17:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mempool: accept user flags only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/21 4:42 PM, David Marchand wrote: > On Mon, Oct 18, 2021 at 10:37 AM Andrew Rybchenko > wrote: >>> diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h >>> index 88bcbc51ef..d2bf2843f7 100644 >>> --- a/lib/mempool/rte_mempool.h >>> +++ b/lib/mempool/rte_mempool.h >>> @@ -258,6 +258,15 @@ struct rte_mempool { >>> #define MEMPOOL_F_POOL_CREATED 0x0010 /**< Internal: pool is created. */ >>> #define MEMPOOL_F_NO_IOVA_CONTIG 0x0020 /**< Don't need IOVA contiguous objs. */ >>> >>> +/** >>> + * This macro lists all the mempool flags an application may request. >>> + */ >>> +#define MEMPOOL_VALID_USER_FLAGS (MEMPOOL_F_NO_SPREAD \ >> >> I think RTE_ prefix is missing here since it is in a public >> header now. >> >>> + | MEMPOOL_F_NO_CACHE_ALIGN \ >>> + | MEMPOOL_F_SP_PUT \ >>> + | MEMPOOL_F_SC_GET \ >>> + | MEMPOOL_F_NO_IOVA_CONTIG \ >>> + ) >>> /** >>> * @internal When debug is enabled, store some statistics. >>> * >>> >> >> Should we make a patch to add defines with RTE_ prefix and >> add a deprecation for old flags without RTE_ prefix? >> >> Olivier, what do you think? If you have time to care about it, >> it would be great. (I'm unfamiliar with coccinelle yet). > > Andrew, > > RTE_ prefixing subject put aside, are you ok with this patch? > > Yes, Acked-by: Andrew Rybchenko