From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E4D945CBE; Sat, 9 Nov 2024 14:51:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6880640263; Sat, 9 Nov 2024 14:51:46 +0100 (CET) Received: from fhigh-b4-smtp.messagingengine.com (fhigh-b4-smtp.messagingengine.com [202.12.124.155]) by mails.dpdk.org (Postfix) with ESMTP id 6729A4021F for ; Sat, 9 Nov 2024 14:51:44 +0100 (CET) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.stl.internal (Postfix) with ESMTP id 68D05254015E; Sat, 9 Nov 2024 08:51:43 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Sat, 09 Nov 2024 08:51:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731160303; x=1731246703; bh=Kk8VwPLAyTzv+nGx5dQPJCM3cPD3X47MZ/huRrarzsc=; b= J+pmr31/TPORcjHFuwffJIWghHjV2M3u54K3JXx2Sun/iVmgs8OMcsqxVkYRsn2f iOOqhUp92K9gRpZvVInNZwe8QW7kZKIk/zP2anM8IhkUlsk4T8ZVpXEmm2+u0xwh 5Zi7QZvCZKO6DhlSSoiS87EPeNe8L9X/Y6HSFevD4+Exr1ZG0XU6Hs2gkP6aYeJW UPkNlIwiA0FN8YtX1GXD7bB0VTUEDDRQ3SuiGlNBe9X5fJUfNg3KShFfiKF5aOpV yaG29u9TvuHw9dyPdokFQgvNuZRKeVm9sFu8P550Q4PYrLxB8P1mTR7z4YE5VFY3 a7TgHylC4F8Taxtjwc5c3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731160303; x= 1731246703; bh=Kk8VwPLAyTzv+nGx5dQPJCM3cPD3X47MZ/huRrarzsc=; b=W ilMGShpMIfIWfOYS9x2olM88HXgbkbYctAX3HjxtZcJ1dRjjFkzN4ENEkduejkkY TO68wzMJECpAxhOmmI6p4DxhkPgjVgxjjD5uc4Dn3S1uxiNdBIQiJ01+UWoMA822 OL6KmbYo0dxCmDuEepN65H8sFkUnmW8fN73GZeXfCi311ciCe+vykaBuxeML0i62 GFe+CvXu0r3OqYubbgadO34jjkQaymQlkW1b1bdscA46BJPS0uO+V85S8eaIZFuA F06KlJEkDhLqTOkEPkQt4rMrdkj1WLa2HebksHQxjTDFK+p/fAV5MJcziLEfuFrd G32zVrs4m9NoNoTxKIYvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdekgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeu veejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohephhgvmhgrnh htrdgrghhrrgifrghlsehngihprdgtohhmpdhrtghpthhtohepghdrshhinhhghhesnhig phdrtghomhdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprhgtphhtthhopegrnh grthholhihrdgsuhhrrghkohhvsehinhhtvghlrdgtohhmpdhrtghpthhtohepjhhunhdr higrnhhgsehngihprdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Nov 2024 08:51:41 -0500 (EST) From: Thomas Monjalon To: Hemant Agrawal , Gagandeep Singh Cc: dev@dpdk.org, Anatoly Burakov , Jun Yang Subject: Re: [v7 02/15] dma/dpaa2: refactor driver code Date: Sat, 09 Nov 2024 14:51:40 +0100 Message-ID: <868876048.0ifERbkFSE@thomas> In-Reply-To: <118706529.nniJfEyVGO@thomas> References: <20241014093639.553467-1-g.singh@nxp.com> <20241015071403.1940833-3-g.singh@nxp.com> <118706529.nniJfEyVGO@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/11/2024 14:37, Thomas Monjalon: > 15/10/2024 09:13, Gagandeep Singh: > > diff --git a/drivers/dma/dpaa2/version.map b/drivers/dma/dpaa2/version.map > > deleted file mode 100644 > > index 43e8b2d5c5..0000000000 > > --- a/drivers/dma/dpaa2/version.map > > +++ /dev/null > > @@ -1,13 +0,0 @@ > > -DPDK_25 { > > - local: *; > > -}; > > - > > -EXPERIMENTAL { > > - global: > > - > > - # added in 22.07 > > - rte_dpaa2_qdma_completed_multi; > > - rte_dpaa2_qdma_copy_multi; > > - rte_dpaa2_qdma_vchan_fd_us_enable; > > - rte_dpaa2_qdma_vchan_internal_sg_enable; > > -}; > > What did you do here? With a second look, I see you really removed these functions. Note it is an API change that you should have written in the release notes (and in the commit log to avoid surprise). > Obviously it breaks compilation: > drivers/dma/dpaa2/version.map', needed by 'drivers/librte_dma_dpaa2.so.25.0', missing and no known rule to make it It works when doing a fresh build.