From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4809C42C3E; Tue, 6 Jun 2023 10:56:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C96C040A84; Tue, 6 Jun 2023 10:56:05 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 172B440697 for ; Tue, 6 Jun 2023 10:56:04 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B19255C00E4; Tue, 6 Jun 2023 04:56:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 06 Jun 2023 04:56:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686041761; x=1686128161; bh=uLw+ZsUoNxb/4d3X6B9d+z7cefSzQe/a8FD 57ZS0Ams=; b=dUBpCgnel1gIXq6cu8QW6wNl8z1yyhmrxP9b843G0w+5t6ZkwCO ey7OxlGpVKuZL9b68dyv9xCz/GXVzGTV8SlgKNUysCZQXGINDpj1VYTC08j5gjIw gGRrBVXawfXRMpe2IrZcX0jYc9UIU12dY+N0MoFodbcQBWjfEzc6ZI+JVwmUBYO8 2k8NwVb+YwK0GV8LSeHMENCsPQcx5LTyv6SF6LpTeD28mZCqglu3h1GhtY+W07iJ z7PbROd/VwPgIcSEgoLfi1Ifl8Q3XtOhJrTkLM5DMiCijQOHcWgAHXoQnS+tZ4y7 KX5wkxx3ZDfkp8txuzzkP6XnEz4H2+oFlXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686041761; x=1686128161; bh=uLw+ZsUoNxb/4d3X6B9d+z7cefSzQe/a8FD 57ZS0Ams=; b=Bmy1pjAPDlSBNC//e6Zsj7CkMckvR/B2KtFCZYQIxm4K6EnVDsR tP5a1YWGjyDxArcdgU778CSK9VuF5NSQD247hyluzxKjgPdfMrHvv7NbGy13M8RQ u6an8m+wjWFSfp3go08kGxFJKt+ce52YdeDRscAyjQuXFAhS0B/01g6P3kD3kzkv M4QLSV+Wijjmp8mitkbvmIvErpkY/zSzx5zqyhTSNmIvuWDuHEAe76MFmbytiTJg 9TSwjt+KSQQH+0+TVnRbL6nFIRcwK1KloNGgcNm3Ge174qNeFwprJdumdhNkaooP 0NYdU8td/9WBZOhVkYWDnh4/TTYDV8OdYhg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtuddgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Jun 2023 04:56:00 -0400 (EDT) From: Thomas Monjalon To: Nipun Gupta , Nipun Gupta Cc: dev@dpdk.org, david.marchand@redhat.com, hkalra@marvell.com, anatoly.burakov@intel.com, stephen@networkplumber.org, ferruh.yigit@amd.com, harpreet.anand@amd.com, nikhil.agarwal@amd.com Subject: Re: [PATCH v6 1/4] bus/cdx: introduce AMD CDX bus Date: Tue, 06 Jun 2023 10:55:58 +0200 Message-ID: <8693521.OUTRe80PYV@thomas> In-Reply-To: <20230605132624.8626-2-nipun.gupta@amd.com> References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230605132624.8626-1-nipun.gupta@amd.com> <20230605132624.8626-2-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/06/2023 15:26, Nipun Gupta: > +INTERNAL { > + global: > + > + rte_cdx_get_sysfs_path; Why exporting this function to the drivers? Another minor comment: please make sure all doxygen comments are ended with a dot.