From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com [209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 7530C2C38 for ; Mon, 23 Jan 2017 07:44:02 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id 236a5885.2b5ed2676940.1928139.00-2462.3952136.nbfkord-smmo02.seg.att.com (envelope-from ); Mon, 23 Jan 2017 06:44:02 +0000 (UTC) X-MXL-Hash: 5885a6327665636b-31a3b3868b1924c09e8d9a55fe77e635bea82552 Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id e26a5885.0.1928135.00-2281.3952129.nbfkord-smmo02.seg.att.com (envelope-from ); Mon, 23 Jan 2017 06:44:00 +0000 (UTC) X-MXL-Hash: 5885a630098fe79e-c7e367e9e0a73bc95be5e2e01a84e1553e4c6b92 Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 23 Jan 2017 06:43:53 +0000 To: Rasesh Mody , References: <1485147758-21809-1-git-send-email-rasesh.mody@cavium.com> CC: , From: Andrew Rybchenko Message-ID: <8698363e-60a6-0eba-e0f2-821c1f409798@solarflare.com> Date: Mon, 23 Jan 2017 09:43:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1485147758-21809-1-git-send-email-rasesh.mody@cavium.com> X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22840.003 X-TM-AS-Result: No--9.839000-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=ALPOwa1d c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=IgFoBzBjUZAA:10 a=zAyngx5bAAAA:8 a] X-AnalysisOut: [=zRKbQ67AAAAA:8 a=6l4Tn0C62ftuYd90FFgA:9 a=Cbrz7UxLjiOcBUN] X-AnalysisOut: [4:21 a=bAIc5cldVOKuziFi:21 a=QEXdDO2ut3YA:10 a=E4vv9DSvw_F] X-AnalysisOut: [GgL_VqyEA:9 a=jGcodjMshrTRwEHr:21 a=cwHUQ8WGRZxsPB5U:21 a=] X-AnalysisOut: [vvUkUlbCGFv8cmWd:21 a=_W_S_7VecoQA:10 a=4LA4qAFo6bo561LpWN] X-AnalysisOut: [DU:22 a=PA03WX8tBzeizutn5_OT:22] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2017 06:44:02 -0000 On 01/23/2017 08:02 AM, Rasesh Mody wrote: > This patch addresses compilation errors on FreeBSD 11.0 clang 3.8.0. > > Fixes: ec94dbc57362 ("qede: add base driver") > > Signed-off-by: Rasesh Mody > --- > drivers/net/qede/base/ecore_init_fw_funcs.c | 2 +- > drivers/net/qede/base/reg_addr.h | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/qede/base/ecore_init_fw_funcs.c b/drivers/net/qede/base/ecore_init_fw_funcs.c > index a5437b5..77f9152 100644 > --- a/drivers/net/qede/base/ecore_init_fw_funcs.c > +++ b/drivers/net/qede/base/ecore_init_fw_funcs.c > @@ -89,7 +89,7 @@ enum CmInterfaceEnum { > #define QM_STOP_CMD_STRUCT_SIZE 2 > #define QM_STOP_CMD_PAUSE_MASK_OFFSET 0 > #define QM_STOP_CMD_PAUSE_MASK_SHIFT 0 > -#define QM_STOP_CMD_PAUSE_MASK_MASK -1 > +#define QM_STOP_CMD_PAUSE_MASK_MASK 0xffffffff /* @DPDK */ > #define QM_STOP_CMD_GROUP_ID_OFFSET 1 > #define QM_STOP_CMD_GROUP_ID_SHIFT 16 > #define QM_STOP_CMD_GROUP_ID_MASK 15 > diff --git a/drivers/net/qede/base/reg_addr.h b/drivers/net/qede/base/reg_addr.h > index ab88671..3c369aa 100644 > --- a/drivers/net/qede/base/reg_addr.h > +++ b/drivers/net/qede/base/reg_addr.h > @@ -30,7 +30,7 @@ > 24 > > #define CDU_REG_CID_ADDR_PARAMS_NCIB ( \ > - 0xff << 24) > + 0xffUL << 24) /* @DPDK */ > > #define XSDM_REG_OPERATION_GEN \ > 0xf80408UL > @@ -436,11 +436,11 @@ > #define NIG_REG_LLH_FUNC_FILTER_VALUE 0x501a00UL > #define XMAC_REG_CTRL_TX_EN (0x1 << 0) > #define XMAC_REG_CTRL_RX_EN (0x1 << 1) > -#define CDU_REG_SEGMENT0_PARAMS_T0_TID_SIZE (0xff << 24) > +#define CDU_REG_SEGMENT0_PARAMS_T0_TID_SIZE (0xffUL << 24) /* @DPDK */ > #define CDU_REG_SEGMENT0_PARAMS_T0_TID_BLOCK_WASTE (0xff << 16) > #define CDU_REG_SEGMENT0_PARAMS_T0_TID_BLOCK_WASTE_SHIFT 16 > #define CDU_REG_SEGMENT1_PARAMS_T1_TID_BLOCK_WASTE (0xff << 16) > -#define CDU_REG_SEGMENT1_PARAMS_T1_TID_SIZE (0xff << 24) > +#define CDU_REG_SEGMENT1_PARAMS_T1_TID_SIZE (0xffUL << 24) /* @DPDK */ > #define CDU_REG_SEGMENT1_PARAMS_T1_NUM_TIDS_IN_BLOCK (0xfff << 0) > #define CDU_REG_SEGMENT1_PARAMS_T1_NUM_TIDS_IN_BLOCK_SHIFT 0 > #define CDU_REG_SEGMENT0_PARAMS_T0_NUM_TIDS_IN_BLOCK (0xfff << 0) FreeBSD build is OK for me with the patch applied. Tested-by: Andrew Rybchenko