From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 1289510D88 for ; Thu, 22 Dec 2016 16:13:22 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id g23so178300500wme.1 for ; Thu, 22 Dec 2016 07:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=iUwKJxOkbP9GkOkAfgQpkL6W8AR9pVehJrN/1DuRK4U=; b=psoz0AdFQEMJtM4Py2yqxtWyfpKO0iol+LYJYrAflGxJuhuUpPZCks78RxM08t5Qbq oBf0J6oGGmmmTLQgRR/tsIAHG0+9WHx42lCm0m+/eElo+kS2ppHd/sGjEE6KDD+M5m51 3jLQJMg1tPBMnuNGs0yXx48n6tuur0B0JfjxeFBEkPKMYv4RW/sQrapOj1Pm8IABRQCj E8FKHOePY/1AoY+48N6m2WAMPB5rR08zu31rndvBV8Ofp4wuKT9s3XJyhK8ZRnP1YtcE wpCZwCC9MyEWqUa5qYJhRtOuv763sPx5gOB/zROJA5rbKzkKh+JV/05FDOHz3+rvPBCr W7JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=iUwKJxOkbP9GkOkAfgQpkL6W8AR9pVehJrN/1DuRK4U=; b=Reyahs50IpSdadzEozTNMOiRbow++Nn+bB8zujFI2mhhpc+MGdIwkL71dnD5Qdd0Ki NKOANcXXsT4W4CunBG520OxLNSu9IGGxmh3+35vHaFUBsDQ9cJb0+0F07JcIGcekeV6V sf2ms/kAIgeK0RpwqYIpObsmkv1EUpXbniS+/ZonrDMggwXvumnqST/VX+7Bfq+WvdMt 92gMe5GGOAVyo6KdoP438RM67wpzYw/RyOJyfl1X27aRh6JBWk/buXlR30xUS6nuz6iK KEa0zckqP8R056rKSCUsvifWnx/3uawjDT9mlk9EwW6a7gpUHxvTma8kKMQlWnmArBP6 fK2g== X-Gm-Message-State: AIkVDXKgIRW7x1c7wdOvnDHcM/9MPMjEg2JzZWgpRRbJD5dHfHgEXJZc1s/7gxqZlKy7/7DS X-Received: by 10.28.23.137 with SMTP id 131mr9942834wmx.121.1482419601794; Thu, 22 Dec 2016 07:13:21 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 204sm32621256wmj.7.2016.12.22.07.13.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 07:13:21 -0800 (PST) From: Thomas Monjalon To: Jan Blunck Cc: dev@dpdk.org, shreyansh.jain@nxp.com, david.marchand@6wind.com, stephen@networkplumber.org Date: Thu, 22 Dec 2016 16:13:20 +0100 Message-ID: <8699988.5R756v89bM@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1482332986-7599-23-git-send-email-jblunck@infradead.org> References: <1482332986-7599-1-git-send-email-jblunck@infradead.org> <1482332986-7599-23-git-send-email-jblunck@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 22/23] ethdev: Decouple interrupt handling from PCI device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 15:13:22 -0000 2016-12-21 16:09, Jan Blunck: > The struct rte_intr_handle is an abstraction layer for different types of > interrupt mechanisms. It is embedded in the low-level device (e.g. PCI). > On allocation of a struct rte_eth_dev a reference to the intr_handle > should be stored for devices supporting interrupts. [...] > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1629,6 +1629,7 @@ struct rte_eth_dev { > const struct eth_driver *driver;/**< Driver for this device */ > const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ > struct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */ > + struct rte_intr_handle *intr_handle; /**< Device interrupt handle */ > /** User application callbacks for NIC interrupts */ > struct rte_eth_dev_cb_list link_intr_cbs; > /** Why adding interrupt in ethdev? Shouldn't it be a property of rte_device?