From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 692AAA04B5; Wed, 30 Sep 2020 10:34:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96CBD1D6F7; Wed, 30 Sep 2020 10:34:46 +0200 (CEST) Received: from qrelay190.mxroute.com (qrelay190.mxroute.com [172.82.139.190]) by dpdk.org (Postfix) with ESMTP id ACB521D68D for ; Wed, 30 Sep 2020 10:34:44 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay190.mxroute.com (ZoneMTA) with ESMTPA id 174de26359c0004a7d.001 for ; Wed, 30 Sep 2020 08:34:40 +0000 X-Zone-Loop: 8dbc556821e68cc1591e77e65a98014a605d2e85e300 X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id 8A37B60044; Wed, 30 Sep 2020 08:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=B520FExPsyT64t5DljrsOi+lvFyb2wLopioW3w6fO9w=; b=YacaD8oxZmC+IK53tGW2J4YCGF CMOeQn+9JFBYgCIxY7C7nCuqCtUriq9Q4d8JV43nbrlSyzGoM+NuWojUz6IZ8KB9ixgYsJRugQHmq O6qZ/OAC7hjntE6LoExqxMaevSyCbF+nNVkedgIC4bnlb6DhBIn+gGN9Sj4Ilot/Iz/pk9IYOFUpd Qxg0dYA9CVK7I4UQGwcihibneXCqQ8J0LMle0ZwnYFaLet9Z2lNtF0s4I13OeaHOM27cstLS3gqZo 2ND3IXo2xKbkGOqT09m0Cv1q4r+lOPSHk7KCEnK9Zpjhp+7w7Xxv84UBwTcQa/Xkh4r1bXcb/kiv/ pAaGhIkA==; To: Ferruh Yigit , "Min Hu (Connor)" , "techboard@dpdk.org" Cc: stephen@networkplumber.org, bruce.richardson@intel.com, "jerinj@marvell.com" , dev@dpdk.org References: <1598845317-55956-1-git-send-email-humin29@huawei.com> <1601176596-29900-1-git-send-email-humin29@huawei.com> <1601176596-29900-2-git-send-email-humin29@huawei.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <869b773f-00a7-e2bb-f12e-92666cc4d3c9@ashroe.eu> Date: Wed, 30 Sep 2020 09:34:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH V5 1/2] dpdk: resolve compiling errors for per-queue stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 28/09/2020 09:59, Ferruh Yigit wrote: > On 9/27/2020 4:16 AM, Min Hu (Connor) wrote: >> From: Huisong Li >> >> Currently, only statistics of rx/tx queues with queue_id less than >> RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain >> application scenario that it needs to use 256 or more than 256 queues >> and display all statistics of rx/tx queue. At this moment, we have to >> change the macro to be equaled to the queue number. >> >> However, modifying the macro to be greater than 256 will trigger >> many errors and warnings from test-pmd, PMD drivers and librte_ethdev >> during compiling dpdk project. But it is possible and permitted that >> rx/tx queue number is greater than 256 and all statistics of rx/tx >> queue need to be displayed. In addition, the data type of rx/tx queue >> number in rte_eth_dev_configure API is 'uint16_t'. So It is unreasonable >> to use the 'uint8_t' type for variables that control which per-queue >> statistics can be displayed. >> >> Fixes: ed30d9b691b2 ("app/testpmd: add stats per queue") >> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") >> Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") >> Fixes: e6defdfddc3b ("net/igc: enable statistics") >> Fixes: 2265e4b4e84b ("net/octeontx2: add basic stats operation") >> Fixes: 6c3169a3dc04 ("virtio: move to drivers/net/") >> >> Signed-off-by: Huisong Li >> Signed-off-by: Min Hu (Connor) >> Reviewed-by: Wei Hu (Xavier) >> Reviewed-by: Dongdong Liu >> --- >> V4 -> V5: >> add release notes updated. >> >> --- >> v3->v4: >> add a change in cmd_setqmap_mapvalue. >> >> --- >> v2->v3: >> change 'uint8_t i' to 'uint16_t i' in nic_stats_display function. >> >> --- >>   app/proc-info/main.c                   | 2 +- >>   app/test-pmd/cmdline.c                 | 4 ++-- >>   app/test-pmd/config.c                  | 4 ++-- >>   app/test-pmd/testpmd.c                 | 2 +- >>   app/test-pmd/testpmd.h                 | 5 +++-- >>   doc/guides/rel_notes/release_20_11.rst | 5 +++++ >>   drivers/net/igc/igc_ethdev.c           | 4 ++-- >>   drivers/net/ixgbe/ixgbe_ethdev.c       | 4 ++-- >>   drivers/net/memif/rte_eth_memif.c      | 2 +- >>   drivers/net/octeontx2/otx2_ethdev.h    | 2 +- >>   drivers/net/octeontx2/otx2_stats.c     | 2 +- >>   drivers/net/virtio/virtio_ethdev.c     | 4 ++-- >>   lib/librte_ethdev/rte_ethdev.c         | 6 +++--- >>   lib/librte_ethdev/rte_ethdev.h         | 4 ++-- >>   lib/librte_ethdev/rte_ethdev_driver.h  | 2 +- >>   15 files changed, 29 insertions(+), 23 deletions(-) >> [SNIP] > > cc'ed tech-board, > > The patch breaks the ethdev ABI without a deprecation notice from previous release(s). > > It is mainly a fix to the port_id storage type, which we have updated from uint8_t to uint16_t in past but some seems remained for 'rte_eth_dev_set_tx_queue_stats_mapping()' & 'rte_eth_dev_set_rx_queue_stats_mapping()' APIs. > > Since the ethdev library already heavily breaks the ABI this release, I am for getting this fix, instead of waiting the fix for one more year. > > Can you please review the patch, is there any objectio to proceed with it? After reading the rest of the thread, I understand that Thomas has suggested depreciating this entire API and using xstats instead. My 2c is that if changing this value requires an ABI breakage and rebuild, its probably the wrong API. Ray K