From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0078.outbound.protection.outlook.com [104.47.42.78]) by dpdk.org (Postfix) with ESMTP id E48DE2C57 for ; Sun, 14 Jan 2018 14:05:10 +0100 (CET) Received: from MWHPR03CA0007.namprd03.prod.outlook.com (10.175.133.145) by CY4PR03MB2696.namprd03.prod.outlook.com (10.173.43.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Sun, 14 Jan 2018 13:05:09 +0000 Received: from BY2FFO11FD021.protection.gbl (2a01:111:f400:7c0c::169) by MWHPR03CA0007.outlook.office365.com (2603:10b6:300:117::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Sun, 14 Jan 2018 13:05:08 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD021.mail.protection.outlook.com (10.1.15.210) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Sun, 14 Jan 2018 13:05:08 +0000 Received: from [10.214.249.200] ([10.214.249.200]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0ED54dd030876; Sun, 14 Jan 2018 06:05:05 -0700 To: Thomas Monjalon , References: <1512642493-14609-1-git-send-email-hemant.agrawal@nxp.com> <1811467.p4hthpzDLK@xps> CC: , From: Hemant Agrawal Message-ID: <869d21cd-47fa-3ab1-47fe-4d617457c749@nxp.com> Date: Sun, 14 Jan 2018 18:35:04 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1811467.p4hthpzDLK@xps> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131604087087205337; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(376002)(396003)(346002)(2980300002)(1110001)(1109001)(339900001)(189003)(199004)(24454002)(23746002)(85426001)(36756003)(97736004)(50466002)(31686004)(8656006)(104016004)(53936002)(65826007)(65806001)(5660300001)(65956001)(229853002)(83506002)(68736007)(86362001)(67846002)(47776003)(4326008)(64126003)(2950100002)(105606002)(305945005)(81156014)(2906002)(31696002)(8676002)(81166006)(106466001)(230700001)(6246003)(498600001)(8936002)(316002)(110136005)(356003)(76176011)(58126008)(54906003)(53546011)(77096006)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2696; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD021; 1:jsTgVaisp4tLosaVKBd0wa92E1W7gE9VtjJI7KskGInCPy/BLckpojF6nS4jnpfkKJf/1jFF1DpVjhXMFEveiTg9Lr8IACEESaMNAHhPHou/UBMMK9uGFzkfFaHhKk1o X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb680946-ec70-46eb-8bd9-08d55b4f7049 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:CY4PR03MB2696; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2696; 3:bXFyX4dffuHaRtwuMVcGt/6lYOV9k/6ztkd5I1m/3cSkEwBkXP0+qH6hEKbsIFjUJ+41XqKqhLZquo8Nxauq03Jrt+WpuACk9qvRM2xnRD8Z/5vHqMa/wQjT04Vn0I2gGKNYA3zz2CD3DacwVMfEdSfJLj4eatlpabLhOpg8fbiuJwmlAtEPkS71F64ekTC9RR5MZlRYHMoqSmKgF1Kbzy0zLUS1ockHKMgFxQyiSwuV3bk3Cle2f63hRpdnF1fpAcyubl8ty0wGSK0yF1Bi4+gjS4NK5JapAYYHwE43uiGfovgBpaRr6KEcd+VloPpQqaE+/j8m+5o0Y6Iltx2eWG8v3VNdntA4pgVH3FIxTrM=; 25:V8QtrVyuBQnGpqP27xOcvo+s6VZhop0+zN3Gnj/xkw3E1lLv3uAhFr2UTnH14fg5ucJ1/a6BPV4qEzAfFD4n8JIzH9nIzzMaRiT4FjXY3z5HumbwAVfmSHnUM9biwOYzU0XjnAdg0TD3erN0K8ZhOcy2Bhy/SaUbKzEx2pYQsSFw00PjLzUMwJlIFzhbgmROy0XBjPsPvZ5eMz19aRAF5NOlFCQa6yOoc44+/6mGR2uxaQenzlg62Z0AAX/bkyqo4mupTgQm8yc6ezg3Dn/nO5+NxtpINh4XlxLoSj2MPhM10JtMDXkw1gRZJLAy9AyVY1toQ+rHRv1cFacCD//UpQ== X-MS-TrafficTypeDiagnostic: CY4PR03MB2696: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2696; 31:PuGwQ/qp0+qRABgrcWjKZQ0aldR0tR55N8ilViFSzI0it3gn1vZKkC1DKqMWIBxSlB3fcqiALICEAJZo+9gaAwlUrLJH3DLxhXYPBhZywin/Jh1192wWRn3FVcJEy9ySEpsIIinNs+XmBuTharldMT5u1ffFSsonE1z4T5CmOHpgX9IhasR8eIWOpSwCVWYxE1lLbrSm+c72NseNqqqNLGjszhv8InrBDCcye+PEj1A=; 4:jSBrzm/WUG7vqoknBz18rLpKg/yF+PQpvEsCbrFcmqVJmLiNzko4ewGo4FQwq6QpWYX00r3U1D/uqxCDTs7qctebiQoSWx9edpBPOSzlXjqI6ut09AHGXb8Q1IoVzFpGYPla9QpYGTSxk0GfS93GJzIxrRKvkx1u6/d2v7AHZ6wOwUWsl0ID809n8Y8HwVnxSaHjYZvY+6b5PxRiJSmIKfLQy/Jn+/Hq4wHTxAtIO+l9/+ntuQYe/LZ/YgqqBJaBu7hIXFtB3c1SpENgliyPKQoLv7dNcoJzJJWCQEuF3OJDx7ZoAJwag7sKjBpfbsVd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231023)(944501161)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703151042153)(20161123556025)(20161123565025)(20161123559100)(20161123561025)(20161123563025)(201708071742011); SRVR:CY4PR03MB2696; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CY4PR03MB2696; X-Forefront-PRVS: 05529C6FDB X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR03MB2696; 23:38cXsQb3NJlTuav+fNP7GG7jA/Af8UONP+Idc?= =?Windows-1252?Q?mTLpKcP6Yg+BGTEsu61MIgA1hQkpsmIMnfwHIJEG0049jzHf/6HPopFc?= =?Windows-1252?Q?ndqSdCrqjyDkmlSqEyTk5iuorIKjCI35KE1wsvgekDsO7uR+pJKsCyvM?= =?Windows-1252?Q?Eh5TgXu8xwmvk/ENtQfqKYqwVhwSmp9gbhrR6DddeJ1XicCD9vcYYw/r?= =?Windows-1252?Q?tohmehnKLwqMV8F6aXuqaoIMqLTttzwcFei5AyVxhG66sJ1Pcky6JnzE?= =?Windows-1252?Q?7h27Pwcebxz8otm2znKbtyA0x7oYGFu5SXPC0W5zAI6dJtgMFQ1AXYwA?= =?Windows-1252?Q?fkpl9oUvtVuUEBZdr02Xr6OR6jIAm19dkl2qcTsSxONjhL1Jugo5qqQj?= =?Windows-1252?Q?c+SwKPG9B3MXDG3ito5HOTI2UpZKgHtmypnUTmU5n8k6sWsjAxDOaB6j?= =?Windows-1252?Q?7TfkyOQ6HQkpddGU/oC+tHid0TLQetUXoMgakuKoAkJX6436V3Ru+sQ/?= =?Windows-1252?Q?r5JNr9+kAbxKHgJ32K2qpqcq1OYRBA/SkF2TdIAfpPz4vusl1y9oklgQ?= =?Windows-1252?Q?wFN5rjXANrUt5k7o1hGqJOVB5KydBr3wN/4La4xtmPv4X9h0EOGm2z6H?= =?Windows-1252?Q?FS/zXu7Gz4ebsuxKkIm8stXOKynJLacvgXPlQM+0tWgWbo+Laih8ZjIv?= =?Windows-1252?Q?1tAkO/bkYPIdHjI/4hGiGSwAzu+YnJK9DbyOKBG4kdgckLFqbpJumnh9?= =?Windows-1252?Q?aKjUOgqRpvK7znhMVgAWLXZ1gGa2fPvi+VwPcPTpI2hh39yk7sW7B6Dm?= =?Windows-1252?Q?F3jWOfEcDpe06UulZkBZAGDIrcSMD/Zflh4+ICKSYJC/ktHRAD9b3N9X?= =?Windows-1252?Q?bvm/9ngI3moZvo7CMrpdoEj7tn9sT+fB0xiIzlB5H9F1vpYHsCN5jtYw?= =?Windows-1252?Q?hV2n8L1ixOUNFps5kM+N81cmN5fYTOJdF3Efxi1PivNMGbRmikqj+xJo?= =?Windows-1252?Q?uduazpyxFIfjxkyfEM4bmlzzhI7r/8ideieNKUQhWc6+3ExDAT8jgZLm?= =?Windows-1252?Q?Lvn3dfminn3lFMeINUgHJX9HKRzq+VpXcUmTCKWVIGDmwhWl3h6gmaWY?= =?Windows-1252?Q?4IHN/+A9QK1ffxYyKv5J2IAdGcQynu2o+TNVOWVPQcmpS/wyO/v5l33s?= =?Windows-1252?Q?0B9xZz2hX3awlqeTcS2SVmNjJH30a9h9WiZpASqOXEcV1jDrrmltujvH?= =?Windows-1252?Q?HK9mlYXxrOYg6J99ldJFUnY8NCI6S3QjX57NH0acidEKct+i6hFj19Qf?= =?Windows-1252?Q?Ufu88C0YNf7MFj2DoXT1Lqxm/OeCv7pkX6IxVDzCOq7s7kO3Y6i20qyq?= =?Windows-1252?Q?yEPsxgkIc8s5EXSpYcl/p32unkjLvSknA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2696; 6:GysSr32BnuU3eaWT8M+2g3BSMwy0kbmFBJwl0EbcWzVkLloTybbZ/gC7H5KN0bFXPNsEROKiLc3I64GH7wxrwtuDUN+i2nVFnSMBaeV2duPxB5RLtPhLe8aQoTSj6kpPagcLZ6uSK1JD7LK9Bz92Zh1dJdhQMu2M4zGOsiFgcmkIJiDsthmzNp52nextcAFnsP7UmSihRERCaBu9lnOIRIay0Dx/BrfosLqomEZjypLkLejcpey98iz70i8bm45upUP1Ig+LjILIyGXEtTlyQ+tcmMt4D0Bi5pcxtilzF3bTOyieV8u4DMp1fdcLZiZ1scYTB97Bvix+2/XmLsfQMojAccdzQZmL2XBVncAdXcM=; 5:s0ImzRT35PqcgBWb9DYoWBtnapUjx/YAgCIq9A/BmYJHAhsmse6aTSkEPqxOls36QkQESdHK6EXH2an9ZsqFGADXutzCQVgBmnpTbmZBZXLFlExJSdeQucyOJumoF8QFtdsistLsT6CClO2zP7odZohOtMBSeU/nC/5MonvnsEM=; 24:g3UUBHmWf0Cj21TUo+FKt+pkQ6zrECF0aJHMFNuP/iBVzZfUcAEeQjzQiYWw9lURv3c0uhBwzEuZBRqboXA3qIzhcZAhKqMHpzvmuJuseT4=; 7:R+72N1XYjuRIwhOJl5l2vBl/jaVLjB+akDuB/rRg8w+1Vdr36ZyyNv1Y83YHMKDDaQpOozJc7+Q3JsudLK9NtgPwTUPYgx2ABUT4QmMJu396s7FNR3vD58nxWC7azngWg5zNMqjmG4fkKCcKsLNkyClb53jAeGOL+5Lv6wAOf0ur1P+yUGA5IXUTlehDMehQjq+6IWTehXdsYIAd+YTDKtwL3bTZaDvISSYQ6WEgf052n+YdBHU7NKnB3ZdGfKzM SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2018 13:05:08.5333 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb680946-ec70-46eb-8bd9-08d55b4f7049 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2696 Subject: Re: [dpdk-dev] [PATCH 01/2] vfio: expose clear group function for internal usages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jan 2018 13:05:11 -0000 On 1/12/2018 10:06 PM, Thomas Monjalon wrote: > 07/12/2017 11:28, Hemant Agrawal: >> other vfio based module e.g. fslmc will also need to use >> the clear_group call. >> So, exposing it and renaming it to *rte_vfio_clear_group* >> >> Signed-off-by: Hemant Agrawal >> --- >> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h >> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h >> @@ -179,7 +179,7 @@ vfio_get_group_fd(int iommu_group_no); >> >> /* remove group fd from internal VFIO group fd array */ >> int >> -clear_group(int vfio_group_fd); >> +rte_vfio_clear_group(int vfio_group_fd); > > The function should be moved to lib/librte_eal/common/include/rte_vfio.h > and an empty implementation must be added for BSD. > I am sending v2 for that. > Related note: in drivers/bus/fslmc/fslmc_vfio.h there is > #include "eal_vfio.h" > Can it be removed? > Yes but it will be different change. Currently fslmc_vfio.h is is using few "vfio_get_xxx" functions. I will plan that cleanup in different patch.