From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14554455F1; Sat, 13 Jul 2024 02:16:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAB9C40693; Sat, 13 Jul 2024 02:16:25 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2086.outbound.protection.outlook.com [40.107.243.86]) by mails.dpdk.org (Postfix) with ESMTP id 93866402E9 for ; Sat, 13 Jul 2024 02:16:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=svmz5beaq7rjCSPZ1G1Q1vOAj2IWKk8r4dMFm/eWTB7xQCbsJYOuco8S4xjpYrLZVYQ1bm23L9jlntrKNouFgNaMtDDtxcYgIL4a9wLArMPU0Pwf0ZXXBF2rTLs9ZI+Db3L9KN8VJY1ciFW0yEAv1O8Q2YJezKoForlCFSUC6ziDZDsfWm64caoZsqcJzVSqshEbN3A4eJKJR0u8IDZxEGi26uhoovFgfS9pRycfmGZ4drwPLTYPaLIN6CX+N+TYK5pbzahfnAx7xWi6I3MWxyoyyrww8wf23Bsz8H9Jh0OaKuEV+WVCy12qNxssTIpjRkTjxM0KZl2YpOFPYotBRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=74z3+s+9oM22vBNwKk3YmS7TXKkRVuuq48FI+k+6Lnc=; b=NRNVK2xF3x3S8ITQam6kaQI9IzeNYfEeZbI8GhNzSHK1bItAe86KeS+WvTETogI2Dlowwb9XNSN4xw4slZGumGbMWSpHmT3xoevxZrmGMqf62Ok3/CI+meLq1UMDH0LrXdBixuOGBPmCeLocbai3Dq8jUPhizlqywiMQ1g4iHycfQ14FwqRltR7pcErsTcTKwuz0Acv1VulR/weHE6YNUi6tDvlFqQLhicNJ0mph5pt7wtpjlAH00U/Jsc7MyAg0ytp/LKDjnXbJK0bCevKU6PFpIQvXHSUNw2l5x+Ee/j6kHIEGeXG5kwCPR+17hm+MmlfnfMwcXlr7JB47pD0BQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=74z3+s+9oM22vBNwKk3YmS7TXKkRVuuq48FI+k+6Lnc=; b=Lrg7nFqIg3rQK9NTfcRh5fmW8gFsmrSwp5Ma7AQrTBL/wEKhEcsGghCiogmNZs14KfsMcMHOvxTzVp+e3cVbSYCLDMJJob7b4/NSOf66NxqHathblGAwPT49fp5e3jSkQbPzBcOsxYlUj9BNqvFnAFESUmUlbQHOFxpp3fzUSkg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB7174.namprd12.prod.outlook.com (2603:10b6:806:2b1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Sat, 13 Jul 2024 00:16:21 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7762.020; Sat, 13 Jul 2024 00:16:21 +0000 Message-ID: <869db100-0385-4ec2-8f8a-5af8f4458c29@amd.com> Date: Sat, 13 Jul 2024 01:16:17 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 03/21] net/ntnic: add minimal initialization for PCI device To: Serhii Iliushyk , dev@dpdk.org Cc: mko-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru References: <20240530144929.4127931-1-sil-plv@napatech.com> <20240712154737.1339646-1-sil-plv@napatech.com> <20240712154737.1339646-3-sil-plv@napatech.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240712154737.1339646-3-sil-plv@napatech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0074.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB7174:EE_ X-MS-Office365-Filtering-Correlation-Id: 306ef683-17b6-4eda-d4a3-08dca2d1063a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZUJTSnNqbjlDcWxFa0lQbXpMbzJCdlpITXdJWnFUWW5aUU1nWUdIemlUNCs5?= =?utf-8?B?NHJiOVZsb3lzcXBnYVZwSWRVVW0ya21sMEcxdkJha1hIS1FhaVMvc3dqUFdy?= =?utf-8?B?Ty9rTEJBM2lNSUxXZFJXTzA5bXZEUWRmcFl2L0xxL003TmFlQllrZnFEekhw?= =?utf-8?B?YTc5R2VpRktVZXJFbnYvRnFwWlVzZ2RCdHN5dW5sekt0SXFkZGdXUG4xSEc4?= =?utf-8?B?ek1mdmpvclNwU1IwK2RJams5T0VhRFdESDRoMXNXNTRCS0NPZWpDaGtDUW1i?= =?utf-8?B?MW1mVFdFOGh1VVFjVDgxV1pBdi9VdUVlLzF0VHhzOUtpOUJ6M2xrTWdCVXJt?= =?utf-8?B?UFY5NFNEa3RSYlpwL3NqaGlweEg5M2ErVzFseTdNRUdiN2YxMWVyYXluZTJJ?= =?utf-8?B?aHNVTjAya2phU1Q2N2xpUEVaOEhYUGZGR0tjT2dxa3VKOXplL09xWVRMdjFy?= =?utf-8?B?NXNTVjRGaUU0VFJhT1o0bXFKcmJISUpZY3piWDBwdFF3d0IzY0YzRkdSbUZY?= =?utf-8?B?Zm56TGlIOFFkQ0pFNVVJY2tlWUJtSjdNR2RucE03SDhkV1M0Ym0wOUhScDRO?= =?utf-8?B?MDZLaHM5d0tXUGRMNjQwNUthdW5RS09RNHVhQkkvYWZzZERLMWZ2WUFadmZG?= =?utf-8?B?RHV2MHIvOEpnNnRqZXBhZTdobFQ5SkV5enVrWi9NeE9yRk9KZ05RYVZXMzda?= =?utf-8?B?V2VDU0Y4eDVha2tVbmE1WHpCVkpyNkZFT2VZYzRzaFA5dHlZWGxGQngzemdO?= =?utf-8?B?YUhXM0ttNHlrTG02eENhNzlvWGg1YnlqV3RJSXdnR2R4ZGFFQWFIZkpRaEl1?= =?utf-8?B?cmZWeGc1b0djc0t0b1g3cFhvREdhOGtjQlBWTEFwRlBUTjVQSGhvUUlwWDlK?= =?utf-8?B?cE1HREQrWDlKRytNNFlqNzBla3F3aVo0VXp2T0tVWEtuaFJmK09VdFpvNG0r?= =?utf-8?B?c1l3c1V4Uy9HRUJWOE43NnRwTUVQYW1tSFIzWkppTy81bUFtZVVaYkFLSnlT?= =?utf-8?B?QmRHSk43NHBjc09yNFl6WVBtS1VhemVaNmJNZURrK3U5cnQwYkM1NEZxR0Ja?= =?utf-8?B?eWZYRHlUQ2dCcDRyYTY4czBaU3pRRDRSSUtYSXdPbTBzWFY1QVkwb3c3T2JI?= =?utf-8?B?dFVMTm5qQWRTdXlBZFNMSlh0T0h3UTNsT3BjRWkwYmlXNUx4U3AzbnZod29I?= =?utf-8?B?TnpTTkhRMEdnVWMrQjNmRldDWG40SXVkeUtqZjNqcFVGWVY2SzlwNktRQzc3?= =?utf-8?B?TFBRRHI1MFVaNEROa0czaDV4NmlrdUxCbXlGRk55MkUyaDYwVGdIRmFMbktI?= =?utf-8?B?d0MxRVhjVjVMazQ2dHEyKzIvSVU0aUhZTmJGSFlmRHRVMENyMXZqa2hCVU83?= =?utf-8?B?ak8yTGZmWFdPU3MxR09UM01EWkpPU2hzQ2M2TkIvQzhCZUp6Z0gvUWthVTVk?= =?utf-8?B?TjY4dkk5N2RKcWdheGZPMXkwZktleUs2ODhaZ2pNTjRseTE4MjdjK3dHUzhp?= =?utf-8?B?QlF5Y3BLd1lFb0JKRU9uemxOWkJEbzN0WHNvMVdEbzlXOTBtZzhNZjFCR3dw?= =?utf-8?B?YUJjNmljeCsvRFJPSk1KOE9iMHBqemtzcE8xNHJyQkUzcWRBa2tXZzkvODg2?= =?utf-8?B?VWkrNzFXSnJzWHI4QjlwWkhOWjdQV2JEZFNwbHM3dy9oRHlMSUg5VWEzSzBI?= =?utf-8?B?OHhyRjkzRm53NExNSlhOZTVBejlYakZPN2taQzNQeEhrSkVDWWduTXcwU203?= =?utf-8?B?d25FZWFsOENWWDJGaTZlVTJJaEVtdjNCS0Z2a25RTmVpUHNKRVV5eWFHRW9E?= =?utf-8?B?TlpPWnZVSVRRT094R0lTdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmRZZldOMzNWS1JZcEVCcTBuOGVXOTluMjcycWJqMTNZKzZQMXh2RFZsM2dn?= =?utf-8?B?SFZ0VTJteFRsSzZBL0JVSUczd04yRVZEdnJ5c252dmc1WWgzTEEwVGVXdFVk?= =?utf-8?B?TmRwTGFiT2JHbTFvcVl2eE5TZm9BUU9YTjFEMk9aYjlhRDJMSEFRQnJ5U016?= =?utf-8?B?OVlKZWVjSGMxeUN5ejRYWFZNV3VTMm5IbHZ2cG5PZ0FpWVd1RCtsRlZHeHpr?= =?utf-8?B?bThQZjA4S3NCL3FiOENLMG93Qm5DMUV3VE1rOEJBUjlVUFVIenpveVkrSGNW?= =?utf-8?B?dVI4U2FJOXRjUjk1cWE0dTJLUWJHRHRYa0hVZjlHQXd1QTVKb3M5cHRQK0V1?= =?utf-8?B?VndKS3RrTHp5c2RwOHBaQmlwalJLSThtMnZlMEdZT0VySThxOEd6TnQxTUdB?= =?utf-8?B?MGZxUEFSTGpOZlBoRSs3a203cStXWDQ0UnVtU1FGRHVKemplSTFKY1E5aWdl?= =?utf-8?B?QUtRdWdTVzBJMFdnWTdiZUdwMnJrR3FoOFJ5SWdVallsZHEyVFEwbUxuMmdp?= =?utf-8?B?WFZUMkdBSHhuSnRRU2hmaHhwbEhERHRQRGwyaWhrbFlsYXo3Mk02WmtZNHBJ?= =?utf-8?B?Qm1RODh4bmJldEx5ZXFwbUR5NjZyYlkrZDIxYlNGNkR5Tmh2aFdUaTJmb002?= =?utf-8?B?N05SQkdid2JFVkxRb005Y0c3YUhZTjlZL05HYzJVajJSMWVjSVNFOEVUdU5X?= =?utf-8?B?L0t1KzgzNUs4b2g2dExQWWc5dk5tQXRucHd0cnNRMVNhUjhEQjROb1dYTHZp?= =?utf-8?B?TFFVejIyRExmK0puV1c3bVpZWllidHQrYmtCeTE2U2VoeHlPaEpYZlhKZ1Rm?= =?utf-8?B?WGgvekEzMzVRcG1ENStaS3dBQ25FNW1TdGZZVERWVVZnUjBwMWlrU1dOdEpl?= =?utf-8?B?endueHhqRWc0czZobkcwQUxrYXBhRlpmcTBTVktFL1RTbUh1bjJYRmZUWHhl?= =?utf-8?B?NlpBQzNqUzNxWnpnamxzQjg4MDAvUkY1bDRreWFqZjZlV2hiV25ER1lneC92?= =?utf-8?B?am1KQUoxb05maTdyaisrSStWdzkralMvcTBNVWVWcGFXUFFMNG04UU96Zklz?= =?utf-8?B?UGhGVVZsek1BSXU3QWJ2KzBvdG1yQWxZblhDZFdjc2o2a1h1YVVyRmVhUVlG?= =?utf-8?B?TEE1akMyR2JHb3ZGS1grU2ZpZEljSHFZdmZaZXM3ZmxJcTIvTmt4V2toQytF?= =?utf-8?B?TlNFT3U2TzNtTXFXUVlJa0thWnVsTHNoQWhWclZkeXkxQXlwNTJPRVNzL2NQ?= =?utf-8?B?WmxGM0dFQTBDcEdSNDBKaUVCWjQ4R0VwT3J2cUE0QTJERUw2V2g0V1lIRnRP?= =?utf-8?B?SmlUUWZIVkhtdEFzR1VLa3k4elozRU93TGgzb1lMQk15NG16YVNzYVBySmtY?= =?utf-8?B?ZnQ3a3NnRDBDbXNnd0hqOEp0Rjl4aU93NUdZYmFPRUFDS0xUWEhreE91U1dk?= =?utf-8?B?RGdlMzBKblRHSmJKNUJreUZla0NBK0IzWitXTUdKZkJpZThUTlpia3BnUFQz?= =?utf-8?B?RnBVT3ZhdFZZOTFFY1ZlM3d2ZjdUbmtBNGZpdzRaTlVleHRyeDYvQnZSS0pX?= =?utf-8?B?Vk5OYmZRTFhBN01vU25vMWpNM0JFdkJoWVJCd2kxRDlMUDlxRC9NWjh0aE8z?= =?utf-8?B?aTdGdHQ0WUVMQ1hEaDNWL2lqdExDb0ErbWNJVFBSR213MytLRE93TWV1Q1Mz?= =?utf-8?B?UmhoaWxvZ3owZmdrNENVWTROS0FpbVpnZkZwQW80NlBxM25ydnNJZTBiL25R?= =?utf-8?B?TlBwRnhEeEIzQkROUDZ1VHM0YkFWMDlIOC8wZ1lvYVN3dHgwSlZmQm53MnhR?= =?utf-8?B?a2VQUGd0dFBpdE9yeU9pQWdPTFVqK3Y2eEhlMG1VSmZIeTloSitvZnVMV0Jy?= =?utf-8?B?clpHL3FCS3pMeC9uQzl5TTBBaWNSQUU4RnVUOUJUZngzTjZyN1owUmZ5cnJB?= =?utf-8?B?ZTRpaDNQdkdhTitrT0Q0UG81bVJXTTdUMm9qcitVakM1eW5xWjd1SStMc3Vp?= =?utf-8?B?Z1RaQlhld3lldnlHTnoyN29lSUF5dERTUzlseVpmSjVxSStSSUszalRaaWk2?= =?utf-8?B?Skd3VGI5ZFdRTHl1NEwrTThnL05hU0xkV3JqTk52emMzazNCeXJLY2hPemhP?= =?utf-8?Q?BpEAJ2IFApusEtaSmsCSzDfwy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 306ef683-17b6-4eda-d4a3-08dca2d1063a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2024 00:16:21.6969 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zg56Szlzy/M+5MxKvDHwldJ9gIP31Gv9wGtbbjgz+VmmKjdwExVHTYihyatcU/XO X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7174 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/12/2024 4:47 PM, Serhii Iliushyk wrote: > add implementation for probe/init and remove/deinit of the PCI device > > Signed-off-by: Serhii Iliushyk <...> > > static int > nthw_pci_dev_deinit(struct rte_eth_dev *eth_dev __rte_unused) > { > - return 0; > + NT_LOG_DBGX(DEBUG, NTNIC, "PCI device deinitialization\n"); > + > + int i; > + char name[32]; > + > + struct pmd_internals *internals = eth_dev->data->dev_private; > At this stage "struct pmd_internals" is not declerad yet, so I expect this commit will fail to build. Can you please test build with each patch, and make sure all builds? > + ntdrv_4ga_t *p_ntdrv = &internals->p_drv->ntdrv; > + fpga_info_t *fpga_info = &p_ntdrv->adapter_info.fpga_info; > + const int n_phy_ports = fpga_info->n_phy_ports; > + for (i = 0; i < n_phy_ports; i++) { > + sprintf(name, "ntnic%d", i); > + eth_dev = rte_eth_dev_allocated(name); > + if (eth_dev == NULL) > + continue; /* port already released */ > + rte_eth_dev_release_port(eth_dev); > + } > + return 0; > There is double tab, please reduce indentation one level.