From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7DA0AA2EEB
	for <public@inbox.dpdk.org>; Thu, 12 Sep 2019 14:56:38 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C191D1E9BE;
	Thu, 12 Sep 2019 14:56:37 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 9491A1E9AD
 for <dev@dpdk.org>; Thu, 12 Sep 2019 14:56:36 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id E740D85540;
 Thu, 12 Sep 2019 12:56:35 +0000 (UTC)
Received: from [10.36.116.177] (ovpn-116-177.ams2.redhat.com [10.36.116.177])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 8236B60872;
 Thu, 12 Sep 2019 12:56:32 +0000 (UTC)
From: "Eelco Chaudron" <echaudro@redhat.com>
To: "Ye Xiaolong" <xiaolong.ye@intel.com>
Cc: "David Marchand" <david.marchand@redhat.com>,
 "Beilei Xing" <beilei.xing@intel.com>, "Qi Zhang" <qi.z.zhang@intel.com>,
 dev <dev@dpdk.org>
Date: Thu, 12 Sep 2019 14:56:30 +0200
Message-ID: <86F54302-F156-4F8F-9C06-2393F3A38EC1@redhat.com>
In-Reply-To: <20190912124049.GA71525@intel.com>
References: <8daee65a8edeae439ba9c2542877744b5be53684.1568284682.git.echaudro@redhat.com>
 <CAJFAV8whJfx4+ZSfh4SOBFdZRAMAcgmkabrtLK1XrA5o6eU7AQ@mail.gmail.com>
 <20190912124049.GA71525@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.28]); Thu, 12 Sep 2019 12:56:36 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:

> On 09/12, David Marchand wrote:
>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com> 
>> wrote:
>>>
>>> When receiving the unsupported AQ messages, it's taken as an
>>> error. It's not appropriate and triggers too much unnecessary print.
>>>
>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>> unnecessary error log") which made the same change for the PF 
>>> instance.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>> ---
>>>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c 
>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>> index c77b30c54..7b1d485c6 100644
>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>>                         }
>>>                         break;
>>>                 default:
>>> -                       PMD_DRV_LOG(ERR, "Request %u is not 
>>> supported yet",
>>> +                       PMD_DRV_LOG(DEBUG, "Request %u is not 
>>> supported yet",
>>>                                     aq_opc);
>>>                         break;
>>>                 }
>>> --
>>> 2.18.1
>>>
>>
>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>
>>
>> --
>> David Marchand
>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Applied to dpdk-next-net-intel.

Thanks David/Ye