From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"Mody, Rasesh" <Rasesh.Mody@cavium.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix to use rte log
Date: Fri, 9 Nov 2018 21:55:21 +0000 [thread overview]
Message-ID: <86cd2454-233b-5da8-f937-21d772108360@intel.com> (raw)
In-Reply-To: <20181108133842.63548c39@shemminger-XPS-13-9360>
On 11/8/2018 9:38 PM, Stephen Hemminger wrote:
> On Thu, 8 Nov 2018 21:19:26 +0000
> "Mody, Rasesh" <Rasesh.Mody@cavium.com> wrote:
>
>> Use rte_log() rather than RTE_LOG() for dynamic logging. Rearrange
>> dynamic log types to the top and configurable log types to bottom.
>> Remove unused RTE_LIBRTE_BNX2X_DEBUG_TX_FREE
>>
>> Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name")
>>
>> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
>
>
> Looks good to me.
>
> You might also want to address the excessive number of INFO messages in
> bnx2x.c. There are things like debug messages at INFO level, extra new
> lines and banner bars.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-11-09 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 21:19 Mody, Rasesh
2018-11-08 21:19 ` [dpdk-dev] [PATCH 2/2] net/bnx2x: fix VF link status update Mody, Rasesh
2018-11-08 21:38 ` [dpdk-dev] [PATCH 1/2] net/bnx2x: fix to use rte log Stephen Hemminger
2018-11-08 22:57 ` Mody, Rasesh
2018-11-09 21:55 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cd2454-233b-5da8-f937-21d772108360@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=Rasesh.Mody@cavium.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).