From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21ECFA0555; Wed, 19 Feb 2020 09:13:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA3381BF78; Wed, 19 Feb 2020 09:13:54 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id F0A501B13C for ; Wed, 19 Feb 2020 09:13:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582100032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XrB7FypYfnydUGJJovuTMxGeKQ3VW3Dy4sI68W1ovZ8=; b=AMYRbS9GveXdHZhJGavZo6BPN3rj9R8/GZNSpnH+xSLKNtPQbP9C31dDnpdFG3dIfydVmG H8YXyonDIG3JqBkFizvRXtmbilg4fL39Hsl5OVI66yf+HhZbd+p1ab4YhGNBuwXIX/gfdT QwclhFYO2V8Bz8b6eXqd9WE+2jovq1M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-GvxFBDrDPriQdqVcOmZtBA-1; Wed, 19 Feb 2020 03:13:37 -0500 Received: by mail-wm1-f72.google.com with SMTP id d4so1053621wmd.7 for ; Wed, 19 Feb 2020 00:13:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=dc58rDYL2VfHJWcDAEqMjKqP8Z6qnW4gvj21aJ38TM0=; b=RnDDHfnLYGP72oMyDpWnnga3ErmHor6D1XP6KbYkFFAhZ8ajfpbpbgGHkNeD7ewHrL TjHi3vIT1iVgM7wKu/L5IN6yHeaXCPJGRWpYDN6hHPUB5M73EN4phqs6Byzl62jO3jGj TjiU7lXUCGeidzRGcXZsshge/j0By5Cj3KJXqVAp4cnIa71rr10SpqaJroZKPb7wWKyS w9wRBG6tC3Y3tZCOUrNvlOL9lzOeLkbziootyU+KOe3xUVm/gwu3+X3V4u0K9/0z+ZEm kNUEhEh2iMHooPPZEi00zUPbCMrazfPjfqnR4l6IPNzoTGJAeKpRXGrXdbs30Qd1yc+/ TBZQ== X-Gm-Message-State: APjAAAVnTNSLJol4jn42jnshjUxZY4XBIZQRKUh0L7kWMw8uo3unlknO BNuhlvS5AhD12sMvrqybngIPzPfeX2KkQByCAxDOW5U5E4uVguQvGh1YRlMO4xYkKBnTaxeZ9/9 JGek= X-Received: by 2002:a5d:56ca:: with SMTP id m10mr35539627wrw.313.1582100015700; Wed, 19 Feb 2020 00:13:35 -0800 (PST) X-Google-Smtp-Source: APXvYqxMJ2jVYmn4jGPrXHM3V+1ZJ8QLGL46YD2B0lLECwitx1R90eRl4wJiDA4lkDpf7HTsXJ5+RQ== X-Received: by 2002:a5d:56ca:: with SMTP id m10mr35539583wrw.313.1582100015367; Wed, 19 Feb 2020 00:13:35 -0800 (PST) Received: from localhost (91-166-131-130.subs.proxad.net. [91.166.131.130]) by smtp.gmail.com with ESMTPSA id b17sm1911625wrp.49.2020.02.19.00.13.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Feb 2020 00:13:34 -0800 (PST) From: Dodji Seketeli X-Google-Original-From: Dodji Seketeli Received: by localhost (Postfix, from userid 1001) id 61BA91A06CE; Wed, 19 Feb 2020 09:13:32 +0100 (CET) To: David Marchand Cc: Thomas Monjalon , dev , Aaron Conole , Christian Ehrhardt , Kevin Laatz , Michael Santana Organization: Red Hat / France References: <20200217135929.30987-1-david.marchand@redhat.com> <20200218142916.657-1-david.marchand@redhat.com> <4348229.k3LOHGUjKi@xps> X-Operating-System: Red Hat Enterprise Linux Server 7.7 X-URL: http://www.redhat.com Date: Wed, 19 Feb 2020 09:13:32 +0100 In-Reply-To: (David Marchand's message of "Tue, 18 Feb 2020 17:38:47 +0100") Message-ID: <86tv3nyoyb.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-MC-Unique: GvxFBDrDPriQdqVcOmZtBA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] ci: build and use libabigail 1.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, David Marchand writes: >> > + LIBABIGAIL_REPO=3D${LIBABIGAIL_REPO:-https://sourceware.org/git/l= ibabigail.git} >> > + LIBABIGAIL_VERSION=3D${LIBABIGAIL_VERSION:-libabigail-1.6} >> > + >> > + if [ "$(cat libabigail/VERSION 2>/dev/null)" !=3D "$LIBABIGAIL_VE= RSION" ]; then >> > + rm -rf libabigail >> > + # if we change libabigail, invalidate existing abi cache >> > + rm -rf reference >> > + fi >> > + >> > + if [ ! -d libabigail ]; then >> > + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_= REPO libabigail/src >> >> Why not using the tarball? >> http://mirrors.kernel.org/sourceware/libabigail/libabigail-1.6.tar.gz > > No good reason "now". > > I was first bitten by a reference to redhat-hardened-ld in some > libtool script in the tarball (/me looks in Dodji direction). > I then considered switching to different versions of libabigail by > just setting the LIBABIGAIL_VERSION env variable from .travis.yml. > I ended up with the current latest version which is also what is in > Ubuntu latest releases. I think either way (distro package, tarball and git) has some benefits and drawbacks. I think one benefit of /being able/ to use the code from git is for cases where you guys need some new features (and we tend to continuously add fixes/functionalities to the git repository) that is available in git only for now. Hopefully, with time, you'll only need to use the distro package. FWIW, I like the fact that your setup lets you choose between the distro package, the tarball or the git code. That's powerful. Cheers, --=20 =09=09Dodji