From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Cheng Jiang <Cheng1.jiang@intel.com>, chenbo.xia@intel.com
Cc: dev@dpdk.org, jiayu.hu@intel.com, yvonnex.yang@intel.com,
yinan.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: add error propagation in ioat ops
Date: Wed, 3 Feb 2021 10:48:37 +0100 [thread overview]
Message-ID: <8701873a-02c8-ddc0-f02a-54956ecccff1@redhat.com> (raw)
In-Reply-To: <20210131123628.47883-1-Cheng1.jiang@intel.com>
On 1/31/21 1:36 PM, Cheng Jiang wrote:
> It makes more sense to add error propagation for rte_ioat_completed_ops.
>
> Signed-off-by: Cheng Jiang <Cheng1.jiang@intel.com>
> ---
> examples/vhost/ioat.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/examples/vhost/ioat.c b/examples/vhost/ioat.c
> index dbad28d43..60b73be93 100644
> --- a/examples/vhost/ioat.c
> +++ b/examples/vhost/ioat.c
> @@ -22,7 +22,6 @@ struct packet_tracker {
>
> struct packet_tracker cb_tracker[MAX_VHOST_DEVICE];
>
> -
> int
> open_ioat(const char *value)
> {
> @@ -129,7 +128,7 @@ ioat_transfer_data_cb(int vid, uint16_t queue_id,
> struct rte_vhost_async_status *opaque_data, uint16_t count)
> {
> uint32_t i_desc;
> - int dev_id = dma_bind[vid].dmas[queue_id * 2 + VIRTIO_RXQ].dev_id;
> + uint16_t dev_id = dma_bind[vid].dmas[queue_id * 2 + VIRTIO_RXQ].dev_id;
This change from uint16_t to int does not seem related to the purpose of
this patch. Is it?
> struct rte_vhost_iov_iter *src = NULL;
> struct rte_vhost_iov_iter *dst = NULL;
> unsigned long i_seg;
> @@ -182,10 +181,17 @@ ioat_check_completed_copies_cb(int vid, uint16_t queue_id,
> unsigned short mask = MAX_ENQUEUED_SIZE - 1;
> unsigned short i;
>
> - int dev_id = dma_bind[vid].dmas[queue_id * 2
> + uint16_t dev_id = dma_bind[vid].dmas[queue_id * 2
> + VIRTIO_RXQ].dev_id;
> n_seg = rte_ioat_completed_ops(dev_id, 255, dump, dump);
> - if (n_seg <= 0)
> + if (n_seg < 0) {
> + RTE_LOG(ERR,
> + VHOST_DATA,
> + "fail to poll completed buf on IOAT device %u",
> + dev_id);
> + return 0;
> + }
> + if (n_seg == 0)
> return 0;
>
> cb_tracker[dev_id].ioat_space += n_seg;
>
next prev parent reply other threads:[~2021-02-03 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 12:36 Cheng Jiang
2021-02-03 9:48 ` Maxime Coquelin [this message]
2021-02-03 11:52 ` Jiang, Cheng1
2021-02-03 12:48 ` Maxime Coquelin
2021-02-03 13:10 ` Jiang, Cheng1
2021-02-03 14:29 ` [dpdk-dev] [PATCH v2] " Cheng Jiang
2021-02-03 16:43 ` Maxime Coquelin
2021-02-03 17:19 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8701873a-02c8-ddc0-f02a-54956ecccff1@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=Cheng1.jiang@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=yinan.wang@intel.com \
--cc=yvonnex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).