From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1833B5F2B for ; Thu, 22 Mar 2018 19:47:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2018 11:46:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,345,1517904000"; d="scan'208";a="41337361" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.63]) ([10.237.221.63]) by orsmga001.jf.intel.com with ESMTP; 22 Mar 2018 11:46:57 -0700 To: Somnath Kotur , dev@dpdk.org References: <20180222025822.18421-1-somnath.kotur@broadcom.com> From: Ferruh Yigit Message-ID: <8712ecbf-57d5-121f-2171-2a573a49871f@intel.com> Date: Thu, 22 Mar 2018 18:46:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180222025822.18421-1-somnath.kotur@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/bnxt: Fix bug with duplicate filter pattern for flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 18:47:01 -0000 On 2/22/2018 2:58 AM, Somnath Kotur wrote: Please start with lowercase after "net/bnxt: fix" > When user reissues same flow director cmd with a different queue > update the existing filter to redirect flow to the new desired > queue as destination just like the other filters like 5 tuple and > generic flow. Can you please add a fixes line? Also ./devtools/check-git-log.sh complains about long title, what about something like (just a sample): "net/bnxt: fix flow director with same cmd different queue" > > Signed-off-by: Somnath Kotur <...> > @@ -2436,11 +2440,32 @@ bnxt_fdir_filter(struct rte_eth_dev *dev, > goto free_filter; > filter->filter_type = HWRM_CFA_NTUPLE_FILTER; > > - match = bnxt_match_fdir(bp, filter); > + if (fdir->action.behavior == RTE_ETH_FDIR_REJECT) > + vnic = STAILQ_FIRST(&bp->ff_pool[0]); > + else > + vnic = > + STAILQ_FIRST(&bp->ff_pool[fdir->action.rx_queue]); Is this done because of column limit? If so I would prefer a few extra chars instead of this assignment. btw, not related to this patch, but in this switch there are a few "/* FALLTHROUGH */" comments but they may not be required (or wrong), can you please check. <...>