From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A873A0542; Wed, 15 Jul 2020 19:38:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D6DB4C7B; Wed, 15 Jul 2020 19:38:51 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 30D1E3421 for ; Wed, 15 Jul 2020 19:38:50 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id AA5BE581704; Wed, 15 Jul 2020 13:38:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 15 Jul 2020 13:38:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= HVVraRIG7RovxWEXkJOMG0/XyaS1iBY89xf/8qQUa8I=; b=ZNpdzkOdeFdVOciD SA8FD6u+Jkem6SErY5JyEWDnNRptTcddY+tjP9cMaPml14R45bVgEeHP8QATQuo9 nnjWdWNcyQsv6qoxny+eT9woPDPg3XoBn82/sHRW1y75He/ZFaW3h2awPJzJ2Ieq HYuQhENtzKa1TqfFpj5IlLRq4jdea98odFVHuuFHeRaUcLER8kzNIwtPpISEDDQd TOk1rea41gnnWRriIjKd0FP8wUr19DeheBMjdrV0ebGIsQKLc3N8k0qKaOppMlqC FXIE5ZvOeZGaOmZAB1KUCicN1w815q1NN+PQz13FXoDj8c65GZIn0MkFRja9Ac7u lw2qmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=HVVraRIG7RovxWEXkJOMG0/XyaS1iBY89xf/8qQUa 8I=; b=G08hnf9Sc6txiM/X8zQ0Je9BSfZD9aGmophYRc7HMx53lW1AY83MABRky 3QAwSWbbrRFWM78LdMFPj+8tw1iOgjDNaXsJsEKVB5GcyZ6iSJQTpJOBnSa+qzyF 673Pxf44tvgWcU0VUqVHh4XbQgBOBRRloaPs4y4eKTl6pCiO202UknambUlwVxrU kvHLoW6j8nIgjZSYEoI/AKl6Y5yrt6bJG9MH5aMm2Glp5uGZgntl0gMN0R9ZuFld GidkDaE9UJGDB+47ikXeZ6JpR+DferU8KRiJ4ulvL9oxsNdSNTmvPn+vGkMYyzp8 NFsQwxA1qD5HPhqI47RSEtacWwxxQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfedvgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ECFC130600A9; Wed, 15 Jul 2020 13:38:44 -0400 (EDT) From: Thomas Monjalon To: Ori Kam Cc: jerinj@marvell.com, xiang.w.wang@intel.com, matan@mellanox.com, viacheslavo@mellanox.com, dev@dpdk.org, guyk@marvell.com, dev@dpdk.org, pbhagavatula@marvell.com, shahafs@mellanox.com, hemant.agrawal@nxp.com, opher@mellanox.com, alexr@mellanox.com, dovrat@marvell.com, pkapoor@marvell.com, nipun.gupta@nxp.com, bruce.richardson@intel.com, yang.a.hong@intel.com, harry.chang@intel.com, gu.jian1@zte.com.cn, shanjiangh@chinatelecom.cn, zhangy.yun@chinatelecom.cn, lixingfu@huachentel.com, wushuai@inspur.com, yuyingxia@yxlink.com, fanchenggang@sunyainfo.com, davidfgao@tencent.com, liuzhong1@chinaunicom.cn, zhaoyong11@huawei.com, oc@yunify.com, jim@netgate.com, hongjun.ni@intel.com, deri@ntop.org, fc@napatech.com, arthur.su@lionic.com, rasland@mellanox.com, Parav Pandit Date: Wed, 15 Jul 2020 19:38:43 +0200 Message-ID: <8717252.zc5qD4ESC3@thomas> In-Reply-To: <1594587541-110442-7-git-send-email-orika@mellanox.com> References: <1593941027-86651-1-git-send-email-orika@mellanox.com> <1594587541-110442-1-git-send-email-orika@mellanox.com> <1594587541-110442-7-git-send-email-orika@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 06/20] regex/mlx5: add probe function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/07/2020 22:58, Ori Kam: > +/** > + * DPDK callback to register a PCI device. Is this intro useful? Why specifying "DPDK"? > + * > + * This function spawns RegEx device out of a given PCI device. > + * > + * @param[in] pci_drv > + * PCI driver structure (mlx5_regex_driver). > + * @param[in] pci_dev > + * PCI device information. > + * > + * @return > + * 0 on success, 1 to skip this driver, a negative errno value otherwise > + * and rte_errno is set. > + */ Do we really need doxygen in a C file of a driver?