From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: remove useless header inclusion
Date: Mon, 27 Jul 2015 00:18:40 +0200 [thread overview]
Message-ID: <8723827.jzxt2xTp0g@xps13> (raw)
In-Reply-To: <1437635732-29113-3-git-send-email-david.marchand@6wind.com>
2015-07-23 09:15, David Marchand:
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -84,7 +84,6 @@
> #include <cmdline_parse_etheraddr.h>
> #include <cmdline_socket.h>
> #include <cmdline.h>
> -#include <rte_pci_dev_ids.h>
This one is "needed" to check bypass support.
The bypass support should be managed inside the ixgbe driver, and the
specific code in testpmd must be removed.
Waiting this cleanup, the inclusion will be moved in the #ifdef BYPASS.
Note: this ugly bypass code was already signaled few times.
If it's not reworked soon (without ifdef), it could be dropped.
next prev parent reply other threads:[~2015-07-26 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 7:15 [dpdk-dev] [PATCH 0/2] [PATCH 0/2] eal cleanup David Marchand
2015-07-23 7:15 ` [dpdk-dev] [PATCH 1/2] eal: remove dependency on drivers David Marchand
2015-07-23 7:15 ` [dpdk-dev] [PATCH 2/2] eal: remove useless header inclusion David Marchand
2015-07-26 22:18 ` Thomas Monjalon [this message]
2015-07-26 22:24 ` [dpdk-dev] [PATCH 0/2] [PATCH 0/2] eal cleanup Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8723827.jzxt2xTp0g@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).