From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 64EA1C494
 for <dev@dpdk.org>; Mon, 27 Jul 2015 00:19:56 +0200 (CEST)
Received: by wicmv11 with SMTP id mv11so117707105wic.0
 for <dev@dpdk.org>; Sun, 26 Jul 2015 15:19:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=65VggZ9sydmtJrkd0KlooS/H83BM6yeFF2iHA32/19Q=;
 b=G7uJYP9NtRxKAo6OLpUQMx4m5T0jdvfBGPrKbvEmJPGrI90mvp0WBcjLv07qGN+e9v
 mBn890L4IIPojHhXTfBLBzNQq8pT0aRFQn4aLQIlMd+AqhH3FofHA6B2o4HoFCj7OuqS
 3mLeN9lSGjAHlFSnRrULUsYYXJi3wLmwwGEEGMktqWiOmimohBkG0LThiv9pCI71Yhei
 rjjvlNwTdLFvYDkwn8uBHvaUMNKXMqrZoxYXqV9QevivCHB9sro8MqzlB5lC2iQUrpYZ
 9KkJWxMYiGkOzHtbhMmDuOb/d7zFVpOJL27bBRPdrxqtyEjLBz2yu+ADsGfPQqdr3Hsh
 jyoA==
X-Gm-Message-State: ALoCoQmZflXcFWUD8ZDllDclMnHOe9YkE0ukkJI/TrbQHn0fQqQw7kVjq1n22mImW2iDQyK7Zuwa
X-Received: by 10.194.178.99 with SMTP id cx3mr46913735wjc.33.1437949196131;
 Sun, 26 Jul 2015 15:19:56 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id w8sm24539342wja.15.2015.07.26.15.19.54
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 26 Jul 2015 15:19:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Date: Mon, 27 Jul 2015 00:18:40 +0200
Message-ID: <8723827.jzxt2xTp0g@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1437635732-29113-3-git-send-email-david.marchand@6wind.com>
References: <1437635732-29113-1-git-send-email-david.marchand@6wind.com>
 <1437635732-29113-3-git-send-email-david.marchand@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: remove useless header inclusion
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Jul 2015 22:19:56 -0000

2015-07-23 09:15, David Marchand:
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -84,7 +84,6 @@
>  #include <cmdline_parse_etheraddr.h>
>  #include <cmdline_socket.h>
>  #include <cmdline.h>
> -#include <rte_pci_dev_ids.h>

This one is "needed" to check bypass support.
The bypass support should be managed inside the ixgbe driver, and the
specific code in testpmd must be removed.
Waiting this cleanup, the inclusion will be moved in the #ifdef BYPASS.

Note: this ugly bypass code was already signaled few times.
If it's not reworked soon (without ifdef), it could be dropped.