From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id D621D5957 for ; Tue, 20 Oct 2015 18:02:05 +0200 (CEST) Received: by wicll6 with SMTP id ll6so52505511wic.0 for ; Tue, 20 Oct 2015 09:02:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=bgGMgbnVGj15a1+4I83LuCKJwcQfZHQHnf5cd5Sn62Y=; b=iGwIgxKvr0axg98JHa75rXeMhv1XB6OfJ+IwNz/56xj5IyxnvwtXK5d6GbowgH1BMJ jEPY7DBtgAB7qoYNokFInWsBJ/VI4GAC1SLjTHHN//PdtgAkR6pSNpqjd3PHmLaj/ji0 F6+UWw7eUXkAR1lJ3Nnk729bL2u2gibHOYzrWzldNz4c6E/AjUxCpml7YfDAv2h/8TFc VrW4RLdwIee1AxRtbnX1ZIhibcF5fcDROsIzqc796CFoJCPGkd1ji2GUvMYWHD5H3H9N rb2HMbqsHHV0+jy8tC3i22WKftoXWd1ajNUiAsI52xoPk5u7utpUcxVhs5CbXWamhY9I 01EA== X-Gm-Message-State: ALoCoQn2l2oRofkbL8FWGzxicnmkrhm1qpGTbNhLiJK7dqUuEhzLsElCl5Fjf/26VUSLfx1LNEF9 X-Received: by 10.180.216.36 with SMTP id on4mr5559727wic.65.1445356924761; Tue, 20 Oct 2015 09:02:04 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id ki7sm4671330wjc.28.2015.10.20.09.02.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2015 09:02:04 -0700 (PDT) Date: Tue, 20 Oct 2015 09:02:04 -0700 (PDT) X-Google-Original-Date: Tue, 20 Oct 2015 18:01 +0200 From: Thomas Monjalon To: "John W. Linville" Message-ID: <8727896.bTnbiDNnpp@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20150828102742.GA3351@hmsreliant.think-freely.org> References: <1440695833-28778-1-git-send-email-linville@tuxdriver.com> <20150828102742.GA3351@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] rte_eth_af_packet: refactor error handling to avoid NULL pointer dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 16:02:06 -0000 2015-08-28 06:27, Neil Horman: > On Thu, Aug 27, 2015 at 01:17:13PM -0400, John W. Linville wrote: > > Coverity CID # 13321 > > > > Checking *internals != NULL before accessing req is not good enough, > > because **internals is a function argument and the function doesn't > > really know what is passed-in. We can close our eyes and ignore the > > warning on the basis of controlling all the calling code, or we can > > refactor the error exit to avoid the issue entirely... > > > > Signed-off-by: John W. Linville > > Acked-by: Neil Horman Applied, thanks