From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E84E441C2C; Tue, 7 Feb 2023 09:35:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3500427F2; Tue, 7 Feb 2023 09:35:47 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id A083D427E9 for ; Tue, 7 Feb 2023 09:35:46 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 8950B32009E7; Tue, 7 Feb 2023 03:35:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 07 Feb 2023 03:35:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675758942; x= 1675845342; bh=FAfVJL3kO3EiFXrq76snezdl5AC84Whn5SltxnKm5X4=; b=i aCoWGRs6nhqY0OVLFVAIdPf3SWqGWZ0XYu+WMYK+oEHSTGUJrsSITIdoD3rXQkqv q8aqgPYFitz+M1ZDactVpO39u9hdFw7oh8ODT6dewWUQiIfzIsxbCP7j3hrC9ulU ODqItAzH1k3OMJy9SPoetImFKlAOCo1ebnvZTK1EWLlyVyAR/W+D8/gcimLQvjTV KBuK1lkJ8I1VAnFF5LrYHG1SphiQnzrzoW32Fc1US/7fngaLitpGTuCgRfxpS2qP cWMoK0PHyup9qUO9ncnKis/gKkpqGwuqYR8ZxuN+0TQc7J4f5f9j/ENmcJ5VbMhy 9LCzUkywbPnC94OwQglww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675758942; x= 1675845342; bh=FAfVJL3kO3EiFXrq76snezdl5AC84Whn5SltxnKm5X4=; b=l FJT/xkDG5DRjpisqMMkoPNUPxg5A22+fjY2ARRKqCwyM5l79MtPdoNfAPLz88B6/ np0C7Alr5y2EBIAWfm+XUdNgHXBjnIMuTAatGSy4NaVow6dmFwIHUCzrJyYUhuTN 2kDJhdaxkPaH00wXPWM3LP3HQbgtggXiyk41ZxONU0CuRyKjqB6SWQobKD4K+5Ib mim/Qq2Hf5UENptozmUUCFsYoPgPzNVT1o+3XQ1BOxNWpJJXD4axXhHwhwa7RQjQ TX3RXAXpln9Nmafln5vnFr2uZ4RADdnA/OtESwThd37+Gfq8KiSr/XUWUHRBV/e8 /UmoNsU3kd6AI+H8G79Pg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegjedguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepudetieeuhfdtudfgveehfeffieehffdvtdejudfhheevfefh teehfeeigfetheehnecuffhomhgrihhnpehinhhtvghlrdgtohhmnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 03:35:40 -0500 (EST) From: Thomas Monjalon To: David Marchand , "mb@smartsharesystems.com" , "ferruh.yigit@amd.com" , "Zhang, Ke1X" Cc: "dev@dpdk.org" , "Matz, Olivier" , "Zhang, Yuying" , "Xing, Beilei" Subject: Re: [PATCH v2] net/i40e: support enabling/disabling source pruning Date: Tue, 07 Feb 2023 09:35:39 +0100 Message-ID: <8729835.VV5PYv0bhD@thomas> In-Reply-To: References: <20230109022027.190627-1-ke1x.zhang@intel.com> <2296416.n0HT0TaD9V@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/02/2023 02:40, Zhang, Ke1X: > From: Thomas Monjalon > > 31/01/2023 04:28, Zhang, Ke1X: > > > From: David Marchand > > > > On Mon, Jan 30, 2023 at 9:23 AM Ke Zhang > > wrote: > > > > > > > > > > VRRP advertisement packets are dropped on i40e PF devices because > > > > when > > > > > a MAC address is added to a device, packets originating from that > > > > > MAC address are dropped. > > > > > > > > > > This patch adds a PMD specific API to enable/disable source > > > > > pruning to fix above issue. > > > > > > > > > > Bugzilla ID: 648 > > > > > > > > > > Signed-off-by: Ke Zhang > > > > > --- > > > > > app/test-pmd/cmdline.c | 84 > > > > +++++++++++++++++++++++++++++++++ > > > > > drivers/net/i40e/i40e_ethdev.c | 43 +++++++++++++++++ > > > > > drivers/net/i40e/i40e_ethdev.h | 1 + > > > > > drivers/net/i40e/rte_pmd_i40e.c | 20 ++++++++ > > > > > drivers/net/i40e/rte_pmd_i40e.h | 16 +++++++ > > > > > 5 files changed, 164 insertions(+) > > > > > > > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > > > > cb8c174020..76a574affd 100644 > > > > > --- a/app/test-pmd/cmdline.c > > > > > +++ b/app/test-pmd/cmdline.c > > > > > @@ -776,6 +776,9 @@ static void cmd_help_long_parsed(void > > > > > *parsed_result, > > > > > > > > > > "port cleanup (port_id) txq (queue_id) (free_cnt)\n" > > > > > " Cleanup txq mbufs for a specific Tx queue\n\n" > > > > > + > > > > > + "port config (port_id|all) src_prune (on|off)\n" > > > > > + " Set source prune on port_id, or all.\n\n" > > > > > ); > > > > > } > > > > > > > > > > > > > - This seems i40e specific, please move to > > drivers/net/i40e/i40e_testpmd.c. > > > > > > > > - Besides, I would prefer that something in the command name clearly > > > > states this is driver (here, i40e) specific. > > > > Like "port config XX i40e_src_prune" or maybe the other way around, > > > > start with a "driver i40e" prefix. > > > > > > > > Maybe others have an opinion. > > > > > > > > > > > > -- > > > > David Marchand > > > > > > Thanks for your comments, this command could be used for other Intel > > > NIC like ice, And It is only finished for i40e in this story: > > > https://jira.devtools.intel.com/browse/DPDK-29564 > > > > Only Intel has access to this URL. > > > > On the principle, you should not update testpmd commands in a patch for > > i40e. > > We add testpmd commands when adding new features in ethdev. > > > > Here specifically, you are adding rte_pmd_i40e_set_src_prune() with a > > vague explanation: "Enable/Disable source prune on all the PF." > > Without more information, I cannot judge whether the feature is generic or > > not. > > So for now, this is a nack. > > > Thanks for your comments, this feature is only for intel NIC. > Would you please share a solution for this case? Host testpmd code in your driver directory with a command name starting with the name of your driver: "i40e port ...". You can look at what is done for mlx5 in drivers/net/mlx5/mlx5_testpmd.c