From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1645523D for ; Sun, 16 Jul 2017 23:42:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B7BAB20A08; Sun, 16 Jul 2017 17:42:43 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 16 Jul 2017 17:42:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=h1dX1A4u2JHshaA IOPBzn21DiTaU93zd4edWT2eh0yE=; b=NfRc06SbFjfIc/mwKkikGw0L+A5gSBT 0xXPTVHqClNwdbIp2736b03OVip8kK7pEJp7XqjP30nTUFt6xYMK3wphzu/nKqdN /zfnA45dj6rI3y9RHgtGNGU2pxxfjykOZErcjKAKkpvyIuKz4TBV7zapbqWpE+n3 J+46kty5QvZ0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=h1dX1A4u2JHshaAIOPBzn21DiTaU93zd4edWT2eh0yE=; b=kms1eEam iqnHaYWi4ujhSsXnHprpNC2nFxr4qQhWKhabZO5cYY5eic4Ezap4C6XDSzLQYVtx sS3J3bfc08TJvGFUcrGznOhgEyPw+lYMM0APrx6Qy7JW29nWYkmAyOcm4DO/gmjk SuPp5vEdymnP9xK4pcCPKB6rJhjupsVuqweC5qfXCaLeBnVdB6puXdtsMt8350In PvJ4H6PZFGYmXaJ48T4KzypFLpR1+WXL1yxx5yC4jSkBvhdREvsjq1CvDsEq0syT nXkuGSt8563notzta06RqH1MxMnd2a1dCfLjrt+1JuFxPWsscjigLZVxWQkT/gJH +7plerDMRM6BMA== X-ME-Sender: X-Sasl-enc: nPaBrPyExWQ1Pb/izv0QRzFD3HJg5VEDZoluD7qYFzdt 1500241363 Received: from xps.localnet (unknown [37.160.141.193]) by mail.messagingengine.com (Postfix) with ESMTPA id 3BD1D2424F; Sun, 16 Jul 2017 17:42:43 -0400 (EDT) From: Thomas Monjalon To: Wei Dai Cc: dev@dpdk.org, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, john.mcnamara@intel.com Date: Sun, 16 Jul 2017 21:25:34 +0200 Message-ID: <8733823.mcBcVaCldc@xps> In-Reply-To: <1499961223-45281-1-git-send-email-wei.dai@intel.com> References: <1499681144-26031-1-git-send-email-wei.dai@intel.com> <1499961223-45281-1-git-send-email-wei.dai@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jul 2017 21:42:44 -0000 13/07/2017 17:53, Wei Dai: > chagnes: > v7: > add description of NIC reset in doc/poll_mode_drv.rst Thanks for bringing more explanations. The texts have to be reviewed by a native english speaker. About the organization of the doc, it is good to explain the VF use case in the prog guide as you do. But you should not add it to the doxygen. The doxygen must be concise enough and explains only the API: - when it can be called - what a driver is doing when calling reset - what is the expected state of the device after reset