From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E2DBA034C; Fri, 25 Feb 2022 20:35:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDF8D4113D; Fri, 25 Feb 2022 20:35:15 +0100 (CET) Received: from mail-108-mta251.mxroute.com (mail-108-mta251.mxroute.com [136.175.108.251]) by mails.dpdk.org (Postfix) with ESMTP id 10FA5410FD for ; Fri, 25 Feb 2022 20:35:13 +0100 (CET) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta251.mxroute.com (ZoneMTA) with ESMTPSA id 17f326143350005a20.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 25 Feb 2022 19:35:09 +0000 X-Zone-Loop: 08f0fda492e7e9197abf9547a434f4d81634cae29462 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JPzsJ8nveAMCsV8WPmlsH4uqw5RMZBxc4sJCTqWkr4s=; b=hwvIBXMZRRc3v3SawAEvdgrER8 ivlqTog3cuCUnsq1EytzR1AitiUzOa1sTgMkyFxWRVgbY2IWN8OOLoZLGFjAlr3WcYnSvJCpOLwSp AuELCBDByIzuZIYxESHNs6tlAa0K3kqoUttFjb7Q13xK3CAP7TWYungFQvXmvsdToEhkKXPifFTlR R1v0zg741J1EJ9/b6onaM8l73+6f0sN7QixwYVCCxFj27kM8fpaaAfF36OTwRFpsFMOnym9tWtLd8 uDQqR8VPdLs103FOp5uLuY8wKy5MJmYQXcsa4a3NItfljz44b43gMmOXvqnqvkD1k5vPOUC0Wy6Ho mCdhfsqQ==; References: <20220210102533.22192-1-arkadiuszx.kusztal@intel.com> <3125054.AJdgDx1Vlc@thomas> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: Thomas Monjalon Cc: Akhil Goyal , "Kusztal, ArkadiuszX" , "Zhang, Roy Fan" , ray.kinsella@intel.com, david.marchand@redhat.com, dev@dpdk.org Subject: Re: [EXT] [PATCH] crypto: fix misspelled key in qt format In-reply-to: <3125054.AJdgDx1Vlc@thomas> Date: Fri, 25 Feb 2022 14:35:05 -0500 Message-ID: <8735k6g2om.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thomas Monjalon writes: > 18/02/2022 07:11, Kusztal, ArkadiuszX: >> From: Akhil Goyal >> > Fix ABI warning. >> > Add libabigail.abiignore rule. >> >> I think what is worth noticing is a fact that after "random 'k' patch" addition of >> [suppress_type] >> name = rte_crypto_asym_op >> this problem does not show up. >> >> But I think it is safer to send addition of >> [suppress_type] >> name = rte_crypto_rsa_priv_key_type >> anyway. >> Will send v2. > > I don't understand why adding this rule, > and the comment does say nothing about it: > "Ignore name change of rsa qt key type" > > The ABI check is fine without above because of this existing exception: > > ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental > [suppress_type] > name = rte_crypto_asym_op > > So I will just drop the unjustified additional exception while pulling. > > Next time, please make sure such ABI exception is approved by more maintainers. To be fair to those involved, I had been CC'ed on the v2 of this. I didn't respond before the patch was merged however. -- Regards, Ray K