* [dpdk-dev] [PATCH] app/testpmd: terminate without freeing resources
@ 2017-04-27 1:32 Jiayu Hu
2017-04-28 1:32 ` [dpdk-dev] [PATCH v2] app/testpmd: fix exit " Jiayu Hu
0 siblings, 1 reply; 4+ messages in thread
From: Jiayu Hu @ 2017-04-27 1:32 UTC (permalink / raw)
To: dev; +Cc: jianfeng.tan, Jiayu Hu
When testpmd exists, it frees the acquired resources (e.g. stop ports).
However, when we terminate it by Ctrl-d, testpmd exists directly without
releasing the resources. In this patch, we fix this exit issue.
Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
app/test-pmd/testpmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 3a57348..94cefc0 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2289,6 +2289,7 @@ main(int argc, char** argv)
start_packet_forwarding(0);
}
prompt();
+ pmd_test_exit();
} else
#endif
{
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] app/testpmd: fix exit without freeing resources
2017-04-27 1:32 [dpdk-dev] [PATCH] app/testpmd: terminate without freeing resources Jiayu Hu
@ 2017-04-28 1:32 ` Jiayu Hu
2017-04-28 2:02 ` Tan, Jianfeng
0 siblings, 1 reply; 4+ messages in thread
From: Jiayu Hu @ 2017-04-28 1:32 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, stable, jianfeng.tan, Jiayu Hu
When testpmd exists, it frees the acquired resources (e.g. stop ports).
However, when we terminate it by Ctrl-d, testpmd exists directly without
releasing the resources. In this patch, we fix this exit issue.
Fixes:af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
changes in v2:
- Change title and add the bug release
app/test-pmd/testpmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 3a57348..94cefc0 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2289,6 +2289,7 @@ main(int argc, char** argv)
start_packet_forwarding(0);
}
prompt();
+ pmd_test_exit();
} else
#endif
{
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix exit without freeing resources
2017-04-28 1:32 ` [dpdk-dev] [PATCH v2] app/testpmd: fix exit " Jiayu Hu
@ 2017-04-28 2:02 ` Tan, Jianfeng
2017-05-01 13:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Tan, Jianfeng @ 2017-04-28 2:02 UTC (permalink / raw)
To: Hu, Jiayu, dev; +Cc: Wu, Jingjing, stable
> -----Original Message-----
> From: Hu, Jiayu
> Sent: Friday, April 28, 2017 9:33 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; stable@dpdk.org; Tan, Jianfeng; Hu, Jiayu
> Subject: [PATCH v2] app/testpmd: fix exit without freeing resources
>
> When testpmd exists, it frees the acquired resources (e.g. stop ports).
> However, when we terminate it by Ctrl-d, testpmd exists directly without
> releasing the resources. In this patch, we fix this exit issue.
>
> Fixes:af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com>
Thanks,
Jianfeng
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix exit without freeing resources
2017-04-28 2:02 ` Tan, Jianfeng
@ 2017-05-01 13:41 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2017-05-01 13:41 UTC (permalink / raw)
To: Hu, Jiayu; +Cc: stable, Tan, Jianfeng, dev, Wu, Jingjing
28/04/2017 04:02, Tan, Jianfeng:
> From: Hu, Jiayu
> >
> > When testpmd exists, it frees the acquired resources (e.g. stop ports).
> > However, when we terminate it by Ctrl-d, testpmd exists directly without
> > releasing the resources. In this patch, we fix this exit issue.
> >
> > Fixes:af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
>
> Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-01 13:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 1:32 [dpdk-dev] [PATCH] app/testpmd: terminate without freeing resources Jiayu Hu
2017-04-28 1:32 ` [dpdk-dev] [PATCH v2] app/testpmd: fix exit " Jiayu Hu
2017-04-28 2:02 ` Tan, Jianfeng
2017-05-01 13:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).